public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>
Cc: "Tian, Feng" <feng.tian@intel.com>,
	edk2-devel-01 <edk2-devel@ml01.01.org>,
	Leif Lindholm <leif.lindholm@linaro.org>,
	"Gao, Liming" <liming.gao@intel.com>,
	"Kinney, Michael D" <michael.d.kinney@intel.com>
Subject: Re: DxeCore assert during initialization
Date: Thu, 23 Feb 2017 18:51:34 +0100	[thread overview]
Message-ID: <748aaede-bff0-5716-8626-5599a94c3530@redhat.com> (raw)
In-Reply-To: <CAKv+Gu8nMcZsPjXhvjrDeOp+RyCh6GFR-t49H6AqAvSWgxeqXg@mail.gmail.com>

On 02/23/17 18:38, Ard Biesheuvel wrote:
> On 23 February 2017 at 17:33, Laszlo Ersek <lersek@redhat.com> wrote:
>> On 02/23/17 18:29, Laszlo Ersek wrote:
>>
>>> This is with ArmVirtQemu @ c5c9e7e298ed, running on QEMU v2.8.0-1290-gc3618551719b, using TCG.
>>
>> Hm, I have some patches in QEMU, so that hash will likely not resolve on
>> your side. The first upstream ancestor is e295a154c2a9.
>>
> 
> Could you please double check?
> 
> $ git show e295a154c2a9
> fatal: ambiguous argument 'e295a154c2a9': unknown revision or path not
> in the working tree.

That's the QEMU git hash:

e295a154c2a9 ("Merge remote-tracking branch 'remotes/dgilbert/tags/pull-hmp-20170221' into staging", 2017-02-21)

http://git.qemu-project.org/?p=qemu.git;a=commit;h=e295a154c2a9

> 
> In any case, it faults on address 0x1383C6E94 with a data abort due to
> permissions, which can only be caused by a store to read-only region.
> 
> This is at the end of the .text segment of UiApp.dll
> 
> Could you open the .dll in GDB (you may need to do 'set architecture
> aarch64'), and paste the output of
> 
> disas *0x3070

I don't have an aarch64 GDB on my laptop, but I have addr2line:

$ aarch64-linux-gnu-addr2line \
  -e Build/ArmVirtQemu-AARCH64/DEBUG_GCC5/AARCH64/MdeModulePkg/Application/UiApp/UiApp/DEBUG/UiApp.debug \
  0x3070
.../MdeModulePkg/Application/UiApp/FrontPage.c:834

This looks reasonable, because the crash hit after I pressed ESC on the splash screen, and was about to get in the menu.

   826    //
   827    // Set PCD to Inform GraphicsConsole to change video resolution.
   828    // Set PCD to Inform Consplitter to change text mode.
   829    //
   830    Status = PcdSet32S (PcdVideoHorizontalResolution, NewHorizontalResolution);
   831    ASSERT_EFI_ERROR (Status);
   832    Status = PcdSet32S (PcdVideoVerticalResolution, NewVerticalResolution);
   833    ASSERT_EFI_ERROR (Status);
   834    Status = PcdSet32S (PcdConOutColumn, NewColumns); <---------- here
   835    ASSERT_EFI_ERROR (Status);
   836    Status = PcdSet32S (PcdConOutRow, NewRows);
   837    ASSERT_EFI_ERROR (Status);

Disassembly with objdump:

  Status = PcdSet32S (PcdConOutColumn, NewColumns);
    3064:       f00001a0        adrp    x0, 3a000 <mHiiDefaultTypeToWidth+0x3968>
    3068:       913a5000        add     x0, x0, #0xe94
    306c:       b9407ba1        ldr     w1, [x29,#120]
    3070:       b9000001        str     w1, [x0]      <--------- here
    3074:       f90033bf        str     xzr, [x29,#96]

Does this help?

Thanks!
Laszlo


  reply	other threads:[~2017-02-23 17:51 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-23 17:16 DxeCore assert during initialization Marcin Wojtas
2017-02-23 17:17 ` Ard Biesheuvel
2017-02-23 17:29   ` Laszlo Ersek
2017-02-23 17:33     ` Laszlo Ersek
2017-02-23 17:38       ` Ard Biesheuvel
2017-02-23 17:51         ` Laszlo Ersek [this message]
2017-02-23 17:55           ` Ard Biesheuvel
2017-02-23 17:34   ` Marcin Wojtas

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=748aaede-bff0-5716-8626-5599a94c3530@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox