Re: [PATCH 2/3] IntelFsp2Pkg: Fix typo and comments

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Mudusuru, Giri P
> Sent: Tuesday, August 30, 2016 2:14 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Ma, Maurice
> <maurice.ma@intel.com>; Yarlagadda, Satya P
> <satya.p.yarlagadda@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo and comments
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> ---
>  .../Library/BaseFspCommonLib/FspCommonLib.c        | 34
> +++++++++++-----------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> index 58c71f5..def55b9 100644
> --- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> +++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> @@ -58,7 +58,7 @@ typedef struct {
>  /**
>    This function sets the FSP global data pointer.
> 
> -  @param[in] FspData       Fsp global data pointer.
> +  @param[in] FspData       FSP global data pointer.
> 
>  **/
>  VOID
> @@ -191,7 +191,7 @@ SetFspCoreStackPointer (
>  /**
>    This function sets the platform specific data pointer.
> 
> -  @param[in] PlatformData       Fsp platform specific data pointer.
> +  @param[in] PlatformData       FSP platform specific data pointer.
> 
>  **/
>  VOID
> @@ -210,7 +210,7 @@ SetFspPlatformDataPointer (
>  /**
>    This function gets the platform specific data pointer.
> 
> -   @param[in] PlatformData       Fsp platform specific data pointer.
> +   @param[in] PlatformData       FSP platform specific data pointer.
> 
>  **/
>  VOID *
> @@ -240,7 +240,7 @@ SetFspUpdDataPointer (
>    FSP_GLOBAL_DATA  *FspData;
> 
>    //
> -  // Get the Fsp Global Data Pointer
> +  // Get the FSP Global Data Pointer
>    //
>    FspData  = GetFspGlobalDataPointer ();
> 
> @@ -269,9 +269,9 @@ GetFspUpdDataPointer (
> 
> 
>  /**
> -  This function sets the memory init UPD data pointer.
> +  This function sets the FspMemoryInit UPD data pointer.
> 
> -  @param[in] MemoryInitUpdPtr   memory init UPD data pointer.
> +  @param[in] MemoryInitUpdPtr   FspMemoryInit UPD data pointer.
>  **/
>  VOID
>  EFIAPI
> @@ -282,20 +282,20 @@ SetFspMemoryInitUpdDataPointer (
>    FSP_GLOBAL_DATA  *FspData;
> 
>    //
> -  // Get the Fsp Global Data Pointer
> +  // Get the FSP Global Data Pointer
>    //
>    FspData  = GetFspGlobalDataPointer ();
> 
>    //
> -  // Set the memory init UPD pointer.
> +  // Set the FspMemoryInit UPD pointer.
>    //
>    FspData->MemoryInitUpdPtr = MemoryInitUpdPtr;
>  }
> 
>  /**
> -  This function gets the memory init UPD data pointer.
> +  This function gets the FspMemoryInit UPD data pointer.
> 
> -  @return memory init UPD data pointer.
> +  @return FspMemoryInit UPD data pointer.
>  **/
>  VOID *
>  EFIAPI
> @@ -311,9 +311,9 @@ GetFspMemoryInitUpdDataPointer (
> 
> 
>  /**
> -  This function sets the silicon init UPD data pointer.
> +  This function sets the FspSiliconInit UPD data pointer.
> 
> -  @param[in] SiliconInitUpdPtr   silicon init UPD data pointer.
> +  @param[in] SiliconInitUpdPtr   FspSiliconInit UPD data pointer.
>  **/
>  VOID
>  EFIAPI
> @@ -324,20 +324,20 @@ SetFspSiliconInitUpdDataPointer (
>    FSP_GLOBAL_DATA  *FspData;
> 
>    //
> -  // Get the Fsp Global Data Pointer
> +  // Get the FSP Global Data Pointer
>    //
>    FspData  = GetFspGlobalDataPointer ();
> 
>    //
> -  // Set the silicon init UPD data pointer.
> +  // Set the FspSiliconInit UPD data pointer.
>    //
>    FspData->SiliconInitUpdPtr = SiliconInitUpdPtr;
>  }
> 
>  /**
> -  This function gets the silicon init UPD data pointer.
> +  This function gets the FspSiliconInit UPD data pointer.
> 
> -  @return silicon init UPD data pointer.
> +  @return FspSiliconInit UPD data pointer.
>  **/
>  VOID *
>  EFIAPI
> @@ -528,6 +528,6 @@ FspApiReturnStatusReset (
>      SetFspApiReturnStatus ((EFI_STATUS)FspResetType);
>      Pei2LoaderSwitchStack ();
>      DEBUG ((DEBUG_ERROR, "!!!ERROR: FSP has requested BootLoader
> for reset. But BootLoader has not honored the reset\n"));
> -    DEBUG ((DEBUG_ERROR, "!!!ERROR: Please add support in
> BootLoader to honour the reset request from FSP\n"));
> +    DEBUG ((DEBUG_ERROR, "!!!ERROR: Please add support in
> BootLoader to honor the reset request from FSP\n"));
>    } while (LoopUntilReset);
>  }
> --
> 2.9.0.windows.1