[PATCH 1/3] IntelFsp2Pkg: Remove pragma usage to align with UEFI Spec

[PATCH 1/3] IntelFsp2Pkg: Remove pragma usage to align with UEFI Spec

[Giri P Mudusuru]

UEFI spec section 2.3.1 requires all data to be naturally aligned.
Remove the unnecessary pragma usage and use push and pop where needed.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
---
 IntelFsp2Pkg/Include/FspDataTable.h                  | 4 ----
 IntelFsp2Pkg/Include/FspEas/FspApi.h                 | 3 ---
 IntelFsp2Pkg/Include/FspGlobalData.h                 | 4 ----
 IntelFsp2Pkg/Include/Guid/FspHeaderFile.h            | 4 ----
 IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c | 4 ++--
 5 files changed, 2 insertions(+), 17 deletions(-)

diff --git a/IntelFsp2Pkg/Include/FspDataTable.h b/IntelFsp2Pkg/Include/FspDataTable.h
index 3c79f34..a137feb 100644
--- a/IntelFsp2Pkg/Include/FspDataTable.h
+++ b/IntelFsp2Pkg/Include/FspDataTable.h
@@ -15,8 +15,6 @@
 #ifndef _FSP_DATA_TABLE_H_
 #define _FSP_DATA_TABLE_H_
 
-#pragma pack(1)
-
 #define FSP_DATA_SIGNATURE  SIGNATURE_32 ('F', 'S', 'P', 'D')
 
 typedef struct  {
@@ -27,6 +25,4 @@ typedef struct  {
   UINT32  FspsBase;
 } FSP_DATA_TABLE;
 
-#pragma pack()
-
 #endif
diff --git a/IntelFsp2Pkg/Include/FspEas/FspApi.h b/IntelFsp2Pkg/Include/FspEas/FspApi.h
index a2e4813..173b33f 100644
--- a/IntelFsp2Pkg/Include/FspEas/FspApi.h
+++ b/IntelFsp2Pkg/Include/FspEas/FspApi.h
@@ -30,7 +30,6 @@
 #define FSP_STATUS_RESET_REQUIRED_8            0x40000008
 /// @}
 
-#pragma pack(1)
 ///
 /// FSP_UPD_HEADER Configuration.
 ///
@@ -153,8 +152,6 @@ typedef struct {
   FSP_INIT_PHASE     Phase;
 } NOTIFY_PHASE_PARAMS;
 
-#pragma pack()
-
 /**
   This FSP API is called soon after coming out of reset and before memory and stack is
   available. This FSP API will load the microcode update, enable code caching for the
diff --git a/IntelFsp2Pkg/Include/FspGlobalData.h b/IntelFsp2Pkg/Include/FspGlobalData.h
index 8ac3199..605a264 100644
--- a/IntelFsp2Pkg/Include/FspGlobalData.h
+++ b/IntelFsp2Pkg/Include/FspGlobalData.h
@@ -16,8 +16,6 @@
 
 #include <FspEas.h>
 
-#pragma pack(1)
-
 typedef enum {
   TempRamInitApiIndex,
   FspInitApiIndex,
@@ -61,6 +59,4 @@ typedef struct  {
    UINT64             PerfData[32];
 } FSP_GLOBAL_DATA;
 
-#pragma pack()
-
 #endif
diff --git a/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h b/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h
index 96cac00..d36d0a6 100644
--- a/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h
+++ b/IntelFsp2Pkg/Include/Guid/FspHeaderFile.h
@@ -30,8 +30,6 @@
 
 #define FSP_INFO_HEADER_SIGNATURE  SIGNATURE_32 ('F', 'S', 'P', 'H')
 
-#pragma pack(1)
-
 ///
 /// FSP Information Header as described in FSP v2.0 Spec section 5.1.1.
 ///
@@ -197,8 +195,6 @@ typedef struct {
 //UINT32  PatchData[];
 } FSP_PATCH_TABLE;
 
-#pragma pack()
-
 extern EFI_GUID gFspHeaderFileGuid;
 
 #endif
diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
index 660e9fc..58c71f5 100644
--- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
+++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
@@ -20,7 +20,7 @@
 #include <FspDataTable.h>
 #include <Library/FspSwitchStackLib.h>
 
-#pragma pack(1)
+#pragma pack(push, 1)
 
 //
 //   API Parameter                +0x34
@@ -53,7 +53,7 @@ typedef struct {
 
 #define CONTEXT_STACK_OFFSET(x)  (UINT32)&((CONTEXT_STACK *)(UINTN)0)->x
 
-#pragma pack()
+#pragma pack(pop)
 
 /**
   This function sets the FSP global data pointer.
-- 
2.9.0.windows.1

[PATCH 2/3] IntelFsp2Pkg: Fix typo and comments

[Giri P Mudusuru]

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
---
 .../Library/BaseFspCommonLib/FspCommonLib.c        | 34 +++++++++++-----------
 1 file changed, 17 insertions(+), 17 deletions(-)

diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
index 58c71f5..def55b9 100644
--- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
+++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
@@ -58,7 +58,7 @@ typedef struct {
 /**
   This function sets the FSP global data pointer.
 
-  @param[in] FspData       Fsp global data pointer.
+  @param[in] FspData       FSP global data pointer.
 
 **/
 VOID
@@ -191,7 +191,7 @@ SetFspCoreStackPointer (
 /**
   This function sets the platform specific data pointer.
 
-  @param[in] PlatformData       Fsp platform specific data pointer.
+  @param[in] PlatformData       FSP platform specific data pointer.
 
 **/
 VOID
@@ -210,7 +210,7 @@ SetFspPlatformDataPointer (
 /**
   This function gets the platform specific data pointer.
 
-   @param[in] PlatformData       Fsp platform specific data pointer.
+   @param[in] PlatformData       FSP platform specific data pointer.
 
 **/
 VOID *
@@ -240,7 +240,7 @@ SetFspUpdDataPointer (
   FSP_GLOBAL_DATA  *FspData;
 
   //
-  // Get the Fsp Global Data Pointer
+  // Get the FSP Global Data Pointer
   //
   FspData  = GetFspGlobalDataPointer ();
 
@@ -269,9 +269,9 @@ GetFspUpdDataPointer (
 
 
 /**
-  This function sets the memory init UPD data pointer.
+  This function sets the FspMemoryInit UPD data pointer.
 
-  @param[in] MemoryInitUpdPtr   memory init UPD data pointer.
+  @param[in] MemoryInitUpdPtr   FspMemoryInit UPD data pointer.
 **/
 VOID
 EFIAPI
@@ -282,20 +282,20 @@ SetFspMemoryInitUpdDataPointer (
   FSP_GLOBAL_DATA  *FspData;
 
   //
-  // Get the Fsp Global Data Pointer
+  // Get the FSP Global Data Pointer
   //
   FspData  = GetFspGlobalDataPointer ();
 
   //
-  // Set the memory init UPD pointer.
+  // Set the FspMemoryInit UPD pointer.
   //
   FspData->MemoryInitUpdPtr = MemoryInitUpdPtr;
 }
 
 /**
-  This function gets the memory init UPD data pointer.
+  This function gets the FspMemoryInit UPD data pointer.
 
-  @return memory init UPD data pointer.
+  @return FspMemoryInit UPD data pointer.
 **/
 VOID *
 EFIAPI
@@ -311,9 +311,9 @@ GetFspMemoryInitUpdDataPointer (
 
 
 /**
-  This function sets the silicon init UPD data pointer.
+  This function sets the FspSiliconInit UPD data pointer.
 
-  @param[in] SiliconInitUpdPtr   silicon init UPD data pointer.
+  @param[in] SiliconInitUpdPtr   FspSiliconInit UPD data pointer.
 **/
 VOID
 EFIAPI
@@ -324,20 +324,20 @@ SetFspSiliconInitUpdDataPointer (
   FSP_GLOBAL_DATA  *FspData;
 
   //
-  // Get the Fsp Global Data Pointer
+  // Get the FSP Global Data Pointer
   //
   FspData  = GetFspGlobalDataPointer ();
 
   //
-  // Set the silicon init UPD data pointer.
+  // Set the FspSiliconInit UPD data pointer.
   //
   FspData->SiliconInitUpdPtr = SiliconInitUpdPtr;
 }
 
 /**
-  This function gets the silicon init UPD data pointer.
+  This function gets the FspSiliconInit UPD data pointer.
 
-  @return silicon init UPD data pointer.
+  @return FspSiliconInit UPD data pointer.
 **/
 VOID *
 EFIAPI
@@ -528,6 +528,6 @@ FspApiReturnStatusReset (
     SetFspApiReturnStatus ((EFI_STATUS)FspResetType);
     Pei2LoaderSwitchStack ();
     DEBUG ((DEBUG_ERROR, "!!!ERROR: FSP has requested BootLoader for reset. But BootLoader has not honored the reset\n"));
-    DEBUG ((DEBUG_ERROR, "!!!ERROR: Please add support in BootLoader to honour the reset request from FSP\n"));
+    DEBUG ((DEBUG_ERROR, "!!!ERROR: Please add support in BootLoader to honor the reset request from FSP\n"));
   } while (LoopUntilReset);
 }
-- 
2.9.0.windows.1

[PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop

[Giri P Mudusuru]

Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Maurice Ma <maurice.ma@intel.com>
Cc: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
Cc: Michael Kinney <michael.d.kinney@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
---
 .../Library/BaseFspWrapperApiLib/X64/DispatchExecute.c                | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
index 061d381..5f4b75e 100644
--- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
+++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
@@ -18,7 +18,7 @@
 #include <Library/BaseLib.h>
 #include <FspEas.h>
 
-#pragma pack(1)
+#pragma pack(push, 1)
 typedef union {
   struct {
     UINT32  LimitLow    : 16;
@@ -37,7 +37,7 @@ typedef union {
   } Bits;
   UINT64  Uint64;
 } IA32_GDT;
-#pragma pack()
+#pragma pack(pop)
 
 GLOBAL_REMOVE_IF_UNREFERENCED IA32_GDT mGdtEntries[] = {
   {{0,      0,  0,  0,    0,  0,  0,  0,    0,  0, 0,  0,  0}}, /* 0x0:  reserve */
-- 
2.9.0.windows.1

Re: [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop

[Kinney, Michael D]

Giri,

Just leave this as #pragma pack(1) and #pragma pack() to follow the 
style used everywhere else.

EDK II sources assume the default packing is natural packing. The compiler
Configuration in tools_def.txt need to make sure natural packing is the default.

Mike

> -----Original Message-----
> From: Mudusuru, Giri P
> Sent: Monday, August 29, 2016 11:14 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Ma, Maurice <maurice.ma@intel.com>; Yarlagadda,
> Satya P <satya.p.yarlagadda@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
> Subject: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> ---
>  .../Library/BaseFspWrapperApiLib/X64/DispatchExecute.c                | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> index 061d381..5f4b75e 100644
> --- a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> +++ b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> @@ -18,7 +18,7 @@
>  #include <Library/BaseLib.h>
>  #include <FspEas.h>
> 
> -#pragma pack(1)
> +#pragma pack(push, 1)
>  typedef union {
>    struct {
>      UINT32  LimitLow    : 16;
> @@ -37,7 +37,7 @@ typedef union {
>    } Bits;
>    UINT64  Uint64;
>  } IA32_GDT;
> -#pragma pack()
> +#pragma pack(pop)
> 
>  GLOBAL_REMOVE_IF_UNREFERENCED IA32_GDT mGdtEntries[] = {
>    {{0,      0,  0,  0,    0,  0,  0,  0,    0,  0, 0,  0,  0}}, /* 0x0:  reserve */
> --
> 2.9.0.windows.1

Re: [PATCH 2/3] IntelFsp2Pkg: Fix typo and comments

[Yao, Jiewen]

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Mudusuru, Giri P
> Sent: Tuesday, August 30, 2016 2:14 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Ma, Maurice
> <maurice.ma@intel.com>; Yarlagadda, Satya P
> <satya.p.yarlagadda@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> Subject: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo and comments
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Maurice Ma <maurice.ma@intel.com>
> Cc: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> ---
>  .../Library/BaseFspCommonLib/FspCommonLib.c        | 34
> +++++++++++-----------
>  1 file changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> index 58c71f5..def55b9 100644
> --- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> +++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c
> @@ -58,7 +58,7 @@ typedef struct {
>  /**
>    This function sets the FSP global data pointer.
> 
> -  @param[in] FspData       Fsp global data pointer.
> +  @param[in] FspData       FSP global data pointer.
> 
>  **/
>  VOID
> @@ -191,7 +191,7 @@ SetFspCoreStackPointer (
>  /**
>    This function sets the platform specific data pointer.
> 
> -  @param[in] PlatformData       Fsp platform specific data pointer.
> +  @param[in] PlatformData       FSP platform specific data pointer.
> 
>  **/
>  VOID
> @@ -210,7 +210,7 @@ SetFspPlatformDataPointer (
>  /**
>    This function gets the platform specific data pointer.
> 
> -   @param[in] PlatformData       Fsp platform specific data pointer.
> +   @param[in] PlatformData       FSP platform specific data pointer.
> 
>  **/
>  VOID *
> @@ -240,7 +240,7 @@ SetFspUpdDataPointer (
>    FSP_GLOBAL_DATA  *FspData;
> 
>    //
> -  // Get the Fsp Global Data Pointer
> +  // Get the FSP Global Data Pointer
>    //
>    FspData  = GetFspGlobalDataPointer ();
> 
> @@ -269,9 +269,9 @@ GetFspUpdDataPointer (
> 
> 
>  /**
> -  This function sets the memory init UPD data pointer.
> +  This function sets the FspMemoryInit UPD data pointer.
> 
> -  @param[in] MemoryInitUpdPtr   memory init UPD data pointer.
> +  @param[in] MemoryInitUpdPtr   FspMemoryInit UPD data pointer.
>  **/
>  VOID
>  EFIAPI
> @@ -282,20 +282,20 @@ SetFspMemoryInitUpdDataPointer (
>    FSP_GLOBAL_DATA  *FspData;
> 
>    //
> -  // Get the Fsp Global Data Pointer
> +  // Get the FSP Global Data Pointer
>    //
>    FspData  = GetFspGlobalDataPointer ();
> 
>    //
> -  // Set the memory init UPD pointer.
> +  // Set the FspMemoryInit UPD pointer.
>    //
>    FspData->MemoryInitUpdPtr = MemoryInitUpdPtr;
>  }
> 
>  /**
> -  This function gets the memory init UPD data pointer.
> +  This function gets the FspMemoryInit UPD data pointer.
> 
> -  @return memory init UPD data pointer.
> +  @return FspMemoryInit UPD data pointer.
>  **/
>  VOID *
>  EFIAPI
> @@ -311,9 +311,9 @@ GetFspMemoryInitUpdDataPointer (
> 
> 
>  /**
> -  This function sets the silicon init UPD data pointer.
> +  This function sets the FspSiliconInit UPD data pointer.
> 
> -  @param[in] SiliconInitUpdPtr   silicon init UPD data pointer.
> +  @param[in] SiliconInitUpdPtr   FspSiliconInit UPD data pointer.
>  **/
>  VOID
>  EFIAPI
> @@ -324,20 +324,20 @@ SetFspSiliconInitUpdDataPointer (
>    FSP_GLOBAL_DATA  *FspData;
> 
>    //
> -  // Get the Fsp Global Data Pointer
> +  // Get the FSP Global Data Pointer
>    //
>    FspData  = GetFspGlobalDataPointer ();
> 
>    //
> -  // Set the silicon init UPD data pointer.
> +  // Set the FspSiliconInit UPD data pointer.
>    //
>    FspData->SiliconInitUpdPtr = SiliconInitUpdPtr;
>  }
> 
>  /**
> -  This function gets the silicon init UPD data pointer.
> +  This function gets the FspSiliconInit UPD data pointer.
> 
> -  @return silicon init UPD data pointer.
> +  @return FspSiliconInit UPD data pointer.
>  **/
>  VOID *
>  EFIAPI
> @@ -528,6 +528,6 @@ FspApiReturnStatusReset (
>      SetFspApiReturnStatus ((EFI_STATUS)FspResetType);
>      Pei2LoaderSwitchStack ();
>      DEBUG ((DEBUG_ERROR, "!!!ERROR: FSP has requested BootLoader
> for reset. But BootLoader has not honored the reset\n"));
> -    DEBUG ((DEBUG_ERROR, "!!!ERROR: Please add support in
> BootLoader to honour the reset request from FSP\n"));
> +    DEBUG ((DEBUG_ERROR, "!!!ERROR: Please add support in
> BootLoader to honor the reset request from FSP\n"));
>    } while (LoopUntilReset);
>  }
> --
> 2.9.0.windows.1

Re: [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push and pop

[Mudusuru, Giri P]

Thanks Mike, sent updated patch v2 removing the push, pop change.

Thanks,
-Giri

> -----Original Message-----
> From: Kinney, Michael D
> Sent: Monday, August 29, 2016 11:45 AM
> To: Mudusuru, Giri P <giri.p.mudusuru@intel.com>; edk2-devel@lists.01.org;
> Kinney, Michael D <michael.d.kinney@intel.com>
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Ma, Maurice
> <maurice.ma@intel.com>; Yarlagadda, Satya P
> <satya.p.yarlagadda@intel.com>
> Subject: RE: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use
> push and pop
> 
> Giri,
> 
> Just leave this as #pragma pack(1) and #pragma pack() to follow the
> style used everywhere else.
> 
> EDK II sources assume the default packing is natural packing. The compiler
> Configuration in tools_def.txt need to make sure natural packing is the default.
> 
> Mike
> 
> > -----Original Message-----
> > From: Mudusuru, Giri P
> > Sent: Monday, August 29, 2016 11:14 AM
> > To: edk2-devel@lists.01.org
> > Cc: Yao, Jiewen <jiewen.yao@intel.com>; Ma, Maurice
> <maurice.ma@intel.com>; Yarlagadda,
> > Satya P <satya.p.yarlagadda@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>
> > Subject: [edk2] [PATCH 3/3] IntelFsp2WrapperPkg: Update pragma to use push
> and pop
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com>
> > Cc: Maurice Ma <maurice.ma@intel.com>
> > Cc: Satya Yarlagadda <satya.p.yarlagadda@intel.com>
> > Cc: Michael Kinney <michael.d.kinney@intel.com>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> > ---
> >  .../Library/BaseFspWrapperApiLib/X64/DispatchExecute.c                | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> >
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> > index 061d381..5f4b75e 100644
> > ---
> a/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> > +++
> b/IntelFsp2WrapperPkg/Library/BaseFspWrapperApiLib/X64/DispatchExecute.c
> > @@ -18,7 +18,7 @@
> >  #include <Library/BaseLib.h>
> >  #include <FspEas.h>
> >
> > -#pragma pack(1)
> > +#pragma pack(push, 1)
> >  typedef union {
> >    struct {
> >      UINT32  LimitLow    : 16;
> > @@ -37,7 +37,7 @@ typedef union {
> >    } Bits;
> >    UINT64  Uint64;
> >  } IA32_GDT;
> > -#pragma pack()
> > +#pragma pack(pop)
> >
> >  GLOBAL_REMOVE_IF_UNREFERENCED IA32_GDT mGdtEntries[] = {
> >    {{0,      0,  0,  0,    0,  0,  0,  0,    0,  0, 0,  0,  0}}, /* 0x0:  reserve */
> > --
> > 2.9.0.windows.1