From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 048F21A1E05 for ; Mon, 29 Aug 2016 16:29:37 -0700 (PDT) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga103.fm.intel.com with ESMTP; 29 Aug 2016 16:29:37 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,253,1470726000"; d="scan'208";a="162226785" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga004.fm.intel.com with ESMTP; 29 Aug 2016 16:29:38 -0700 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 29 Aug 2016 16:29:37 -0700 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 29 Aug 2016 16:29:36 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.174]) with mapi id 14.03.0248.002; Tue, 30 Aug 2016 07:29:34 +0800 From: "Yao, Jiewen" To: "Mudusuru, Giri P" , "edk2-devel@lists.01.org" CC: "Ma, Maurice" , "Yarlagadda, Satya P" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo and comments Thread-Index: AQHSAiEQ/VKlWxJG8EqV8Kz8KRp1AKBglgsw Date: Mon, 29 Aug 2016 23:29:34 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50385F355F@shsmsx102.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 2/3] IntelFsp2Pkg: Fix typo and comments X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 29 Aug 2016 23:29:38 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@intel.com > -----Original Message----- > From: Mudusuru, Giri P > Sent: Tuesday, August 30, 2016 2:14 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Ma, Maurice > ; Yarlagadda, Satya P > ; Kinney, Michael D > > Subject: [edk2] [PATCH 2/3] IntelFsp2Pkg: Fix typo and comments >=20 > Cc: Jiewen Yao > Cc: Maurice Ma > Cc: Satya Yarlagadda > Cc: Michael Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Giri P Mudusuru > --- > .../Library/BaseFspCommonLib/FspCommonLib.c | 34 > +++++++++++----------- > 1 file changed, 17 insertions(+), 17 deletions(-) >=20 > diff --git a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c > b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c > index 58c71f5..def55b9 100644 > --- a/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c > +++ b/IntelFsp2Pkg/Library/BaseFspCommonLib/FspCommonLib.c > @@ -58,7 +58,7 @@ typedef struct { > /** > This function sets the FSP global data pointer. >=20 > - @param[in] FspData Fsp global data pointer. > + @param[in] FspData FSP global data pointer. >=20 > **/ > VOID > @@ -191,7 +191,7 @@ SetFspCoreStackPointer ( > /** > This function sets the platform specific data pointer. >=20 > - @param[in] PlatformData Fsp platform specific data pointer. > + @param[in] PlatformData FSP platform specific data pointer. >=20 > **/ > VOID > @@ -210,7 +210,7 @@ SetFspPlatformDataPointer ( > /** > This function gets the platform specific data pointer. >=20 > - @param[in] PlatformData Fsp platform specific data pointer. > + @param[in] PlatformData FSP platform specific data pointer. >=20 > **/ > VOID * > @@ -240,7 +240,7 @@ SetFspUpdDataPointer ( > FSP_GLOBAL_DATA *FspData; >=20 > // > - // Get the Fsp Global Data Pointer > + // Get the FSP Global Data Pointer > // > FspData =3D GetFspGlobalDataPointer (); >=20 > @@ -269,9 +269,9 @@ GetFspUpdDataPointer ( >=20 >=20 > /** > - This function sets the memory init UPD data pointer. > + This function sets the FspMemoryInit UPD data pointer. >=20 > - @param[in] MemoryInitUpdPtr memory init UPD data pointer. > + @param[in] MemoryInitUpdPtr FspMemoryInit UPD data pointer. > **/ > VOID > EFIAPI > @@ -282,20 +282,20 @@ SetFspMemoryInitUpdDataPointer ( > FSP_GLOBAL_DATA *FspData; >=20 > // > - // Get the Fsp Global Data Pointer > + // Get the FSP Global Data Pointer > // > FspData =3D GetFspGlobalDataPointer (); >=20 > // > - // Set the memory init UPD pointer. > + // Set the FspMemoryInit UPD pointer. > // > FspData->MemoryInitUpdPtr =3D MemoryInitUpdPtr; > } >=20 > /** > - This function gets the memory init UPD data pointer. > + This function gets the FspMemoryInit UPD data pointer. >=20 > - @return memory init UPD data pointer. > + @return FspMemoryInit UPD data pointer. > **/ > VOID * > EFIAPI > @@ -311,9 +311,9 @@ GetFspMemoryInitUpdDataPointer ( >=20 >=20 > /** > - This function sets the silicon init UPD data pointer. > + This function sets the FspSiliconInit UPD data pointer. >=20 > - @param[in] SiliconInitUpdPtr silicon init UPD data pointer. > + @param[in] SiliconInitUpdPtr FspSiliconInit UPD data pointer. > **/ > VOID > EFIAPI > @@ -324,20 +324,20 @@ SetFspSiliconInitUpdDataPointer ( > FSP_GLOBAL_DATA *FspData; >=20 > // > - // Get the Fsp Global Data Pointer > + // Get the FSP Global Data Pointer > // > FspData =3D GetFspGlobalDataPointer (); >=20 > // > - // Set the silicon init UPD data pointer. > + // Set the FspSiliconInit UPD data pointer. > // > FspData->SiliconInitUpdPtr =3D SiliconInitUpdPtr; > } >=20 > /** > - This function gets the silicon init UPD data pointer. > + This function gets the FspSiliconInit UPD data pointer. >=20 > - @return silicon init UPD data pointer. > + @return FspSiliconInit UPD data pointer. > **/ > VOID * > EFIAPI > @@ -528,6 +528,6 @@ FspApiReturnStatusReset ( > SetFspApiReturnStatus ((EFI_STATUS)FspResetType); > Pei2LoaderSwitchStack (); > DEBUG ((DEBUG_ERROR, "!!!ERROR: FSP has requested BootLoader > for reset. But BootLoader has not honored the reset\n")); > - DEBUG ((DEBUG_ERROR, "!!!ERROR: Please add support in > BootLoader to honour the reset request from FSP\n")); > + DEBUG ((DEBUG_ERROR, "!!!ERROR: Please add support in > BootLoader to honor the reset request from FSP\n")); > } while (LoopUntilReset); > } > -- > 2.9.0.windows.1