From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D20D91A1EA0 for ; Wed, 7 Sep 2016 01:00:50 -0700 (PDT) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP; 07 Sep 2016 01:00:51 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,295,1470726000"; d="scan'208,217";a="5369236" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by fmsmga005.fm.intel.com with ESMTP; 07 Sep 2016 01:00:50 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 7 Sep 2016 01:00:49 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.109]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.166]) with mapi id 14.03.0248.002; Wed, 7 Sep 2016 16:00:46 +0800 From: "Yao, Jiewen" To: "Yao, Jiewen" , "Justen, Jordan L" , "edk2-devel@lists.01.org" CC: "Chan, Amy" , "Yao, Jiewen" Thread-Topic: [edk2] [PATCH] Maintainers.txt: Add Giri as 2nd maintainer Thread-Index: AQHSCKYsFj4kukfp/0+nXXtIhG4baqBtFd0AgACJEQCAAAYsgA== Date: Wed, 7 Sep 2016 08:00:46 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50385FAA16@shsmsx102.ccr.corp.intel.com> References: <1473211270-12320-1-git-send-email-jiewen.yao@intel.com> <147323211068.9581.7670554499055950051@jljusten-ivb> <74D8A39837DF1E4DA445A8C0B3885C50385FA9CA@shsmsx102.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C50385FA9CA@shsmsx102.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH] Maintainers.txt: Add Giri as 2nd maintainer X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 07 Sep 2016 08:00:51 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Jordan I have a quick check: Here is my observation: 1) From https://github.com/tianocore/tianocore.github.io/wiki/Commit-M= essage-Format, it mentions: * The length of 'Pkg-Module: Brief-single-line-summary' should not exce= ed 70 characters 2) In the PatchCheck.py, we have below code: if count >=3D 1 and len(lines[0]) > 76: self.error('First line of commit message (subject line) ' + 'is too long.') 3) You recommendation "Maintainers.txt: Add Giri as IntelFsp2*Pkg, Int= elSiliconPkg maintainer", it is 71 char. However, if we add "[edk2] [PATCH]", it becomes 85 char. I am confused on the rule. So I have 2 suggestion: 1) wiki mentions *70* char, but tool checks *76* char. It seems mismat= ch. We had better fix that. Can we make them consistent? 2) In most cases, the patch subject is start with *[edk2] [PATCH]*. Th= ese 14 additional char had better be excluded in the total 70 or 76 char (I= am not sure what is right number), when the subject is calculated. I have no problem to fix this patch manually. I do hope we can have consistent rule and tool to help us do the check. Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,= Jiewen Sent: Wednesday, September 7, 2016 3:21 PM To: Justen, Jordan L ; edk2-devel@lists.01.org Cc: Chan, Amy Subject: Re: [edk2] [PATCH] Maintainers.txt: Add Giri as 2nd maintainer Jordan I got error from BaseTools\Scripts\PatchCheck.py, if I add it. Can you fix the tool to remove such limitation? =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Checking patch file: C:\home\EdkIITransition\AllComboGit\edk2\0001-Maintain= ers.t xt-Add-Giri-as-2nd-maintainer-to-IntelF.patch The commit message format is not valid: * First line of commit message (subject line) is too long. https://github.com/tianocore/tianocore.github.io/wiki/Commit-Message-Format The code passed all checks. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Jord= an Justen Sent: Wednesday, September 7, 2016 3:09 PM To: Yao, Jiewen >; edk2-d= evel@lists.01.org Cc: Chan, Amy > Subject: Re: [edk2] [PATCH] Maintainers.txt: Add Giri as 2nd maintainer What about this patch subject instead? Maintainers.txt: Add Giri as IntelFsp2*Pkg, IntelSiliconPkg maintainer This way we can see the affected packages from the subject line. -Jordan On 2016-09-06 18:21:10, Jiewen Yao wrote: > Add Giri as 2nd maintainer to IntelFsp2*Pkg and IntelSiliconPkg. > > Cc: Giri P Mudusuru = >> > Cc: Amy Chan >> > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao >> > --- > Maintainers.txt | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index b2e679d..6ac7085 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -130,10 +130,12 @@ M: Jeff Fan >> > IntelFsp2Pkg > W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFsp2Pkg > M: Jiewen Yao >> > +M: Giri P Mudusuru = >> > > IntelFsp2WrapperPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFsp2Wrappe= rPkg > M: Jiewen Yao >> > +M: Giri P Mudusuru = >> > > IntelFspPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/IntelFspPkg > @@ -146,6 +148,7 @@ M: Jiewen Yao >> > IntelSiliconPkg > W: https://github.com/tianocore/tianocore.github.io/wiki/IntelSiliconPkg > M: Jiewen Yao >> > +M: Giri P Mudusuru = >> > > MdeModulePkg > W: https://github.com/tianocore/tianocore.github.io/wiki/MdeModulePkg > -- > 2.7.4.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org> > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel