Re: [PATCH 45/45] Vlv2TbltDevicePkg/bat: add capsule generation in bat.

["Yao, Jiewen" <jiewen.yao@intel.com>]

That is very good suggestion.
I will generate one more patch to add help info.



> -----Original Message-----
> From: Wei, David
> Sent: Wednesday, September 21, 2016 3:54 PM
> To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
> Cc: Tian, Feng <feng.tian@intel.com>; Zeng, Star <star.zeng@intel.com>;
> Kinney, Michael D <michael.d.kinney@intel.com>; Gao, Liming
> <liming.gao@intel.com>; Zhang, Chao B <chao.b.zhang@intel.com>; Wei,
> David <david.wei@intel.com>
> Subject: RE: [PATCH 45/45] Vlv2TbltDevicePkg/bat: add capsule generation
> in bat.
> 
> Hi Jiewen,
> 
> Only one comment: it's better if we add a help message for this build option.
> 
> Reviewed-by: David Wei <david.wei@intel.com>
> 
> Thanks,
> David  Wei
> 
> 
> -----Original Message-----
> From: Yao, Jiewen
> Sent: Wednesday, September 21, 2016 2:45 PM
> To: edk2-devel@lists.01.org
> Cc: Wei, David <david.wei@intel.com>; Tian, Feng <feng.tian@intel.com>;
> Zeng, Star <star.zeng@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Gao, Liming <liming.gao@intel.com>; Zhang,
> Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH 45/45] Vlv2TbltDevicePkg/bat: add capsule generation in
> bat.
> 
> If OPENSSL_PATH is set, the build process generates capsule.
> 
> Cc: David Wei <david.wei@intel.com>
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
> ---
>  Vlv2TbltDevicePkg/bld_vlv.bat | 8 +++++++-
>  1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Vlv2TbltDevicePkg/bld_vlv.bat b/Vlv2TbltDevicePkg/bld_vlv.bat
> index 547b2b1..a01a459 100644
> --- a/Vlv2TbltDevicePkg/bld_vlv.bat
> +++ b/Vlv2TbltDevicePkg/bld_vlv.bat
> @@ -1,7 +1,7 @@
>  @REM @file
>  @REM   Windows batch file to build BIOS ROM
>  @REM
> -@REM Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
> +@REM Copyright (c) 2006 - 2016, Intel Corporation. All rights
> reserved.<BR>
>  @REM This program and the accompanying materials
>  @REM are licensed and made available under the terms and conditions of
> the BSD License
>  @REM which accompanies this distribution.  The full text of the license
> may be found at
> @@ -234,6 +234,7 @@ del /f/q ver_strings >nul
> 
>  set
> BIOS_Name=%BOARD_ID%_%Arch%_%BUILD_TYPE%_%VERSION_MAJOR%
> _%VERSION_MINOR%.ROM
>  copy
> /y/b %BUILD_PATH%\FV\Vlv%Arch%.fd  %WORKSPACE%\%BIOS_Name% >
> nul
> +copy
> /y/b %BUILD_PATH%\FV\Vlv%Arch%.fd  %BUILD_PATH%\FV\Vlv.ROM >nul
> 
>  echo.
>  echo Build location:     %BUILD_PATH%
> @@ -241,6 +242,11 @@ echo BIOS ROM Created:   %BIOS_Name%
>  echo.
>  echo -------------------- The EDKII BIOS build has successfully completed.
> --------------------
>  echo.
> +
> +@REM build capsule here
> +if "%openssl_path%" == "" goto Exit
> +build -p %PLATFORM_PACKAGE%\PlatformCapsule.dsc
> +
>  goto Exit
> 
>  :Usage
> --
> 2.7.4.windows.1