From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 414A01A1E6E for ; Wed, 21 Sep 2016 00:54:49 -0700 (PDT) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by orsmga101.jf.intel.com with ESMTP; 21 Sep 2016 00:54:49 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,372,1470726000"; d="scan'208";a="11552075" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by fmsmga006.fm.intel.com with ESMTP; 21 Sep 2016 00:54:49 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 21 Sep 2016 00:54:48 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.234]) with mapi id 14.03.0248.002; Wed, 21 Sep 2016 15:54:47 +0800 From: "Yao, Jiewen" To: "Wei, David" , "edk2-devel@lists.01.org" CC: "Tian, Feng" , "Zeng, Star" , "Kinney, Michael D" , "Gao, Liming" , "Zhang, Chao B" , "Yao, Jiewen" Thread-Topic: [PATCH 45/45] Vlv2TbltDevicePkg/bat: add capsule generation in bat. Thread-Index: AQHSE91IKxFPr35U6kqjhhJRvnaZ66CDkvpg Date: Wed, 21 Sep 2016 07:54:46 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503869657F@shsmsx102.ccr.corp.intel.com> References: <1474440326-9292-1-git-send-email-jiewen.yao@intel.com> <1474440326-9292-46-git-send-email-jiewen.yao@intel.com> <89954A0B46707A448411A627AD4EEE3466379A34@SHSMSX101.ccr.corp.intel.com> In-Reply-To: <89954A0B46707A448411A627AD4EEE3466379A34@SHSMSX101.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 45/45] Vlv2TbltDevicePkg/bat: add capsule generation in bat. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Sep 2016 07:54:49 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That is very good suggestion. I will generate one more patch to add help info. > -----Original Message----- > From: Wei, David > Sent: Wednesday, September 21, 2016 3:54 PM > To: Yao, Jiewen ; edk2-devel@lists.01.org > Cc: Tian, Feng ; Zeng, Star ; > Kinney, Michael D ; Gao, Liming > ; Zhang, Chao B ; Wei, > David > Subject: RE: [PATCH 45/45] Vlv2TbltDevicePkg/bat: add capsule generation > in bat. >=20 > Hi Jiewen, >=20 > Only one comment: it's better if we add a help message for this build opt= ion. >=20 > Reviewed-by: David Wei >=20 > Thanks, > David Wei >=20 >=20 > -----Original Message----- > From: Yao, Jiewen > Sent: Wednesday, September 21, 2016 2:45 PM > To: edk2-devel@lists.01.org > Cc: Wei, David ; Tian, Feng ; > Zeng, Star ; Kinney, Michael D > ; Gao, Liming ; Zhang, > Chao B > Subject: [PATCH 45/45] Vlv2TbltDevicePkg/bat: add capsule generation in > bat. >=20 > If OPENSSL_PATH is set, the build process generates capsule. >=20 > Cc: David Wei > Cc: Feng Tian > Cc: Star Zeng > Cc: Michael D Kinney > Cc: Liming Gao > Cc: Chao Zhang > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > --- > Vlv2TbltDevicePkg/bld_vlv.bat | 8 +++++++- > 1 file changed, 7 insertions(+), 1 deletion(-) >=20 > diff --git a/Vlv2TbltDevicePkg/bld_vlv.bat b/Vlv2TbltDevicePkg/bld_vlv.ba= t > index 547b2b1..a01a459 100644 > --- a/Vlv2TbltDevicePkg/bld_vlv.bat > +++ b/Vlv2TbltDevicePkg/bld_vlv.bat > @@ -1,7 +1,7 @@ > @REM @file > @REM Windows batch file to build BIOS ROM > @REM > -@REM Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<= BR> > +@REM Copyright (c) 2006 - 2016, Intel Corporation. All rights > reserved.
> @REM This program and the accompanying materials > @REM are licensed and made available under the terms and conditions of > the BSD License > @REM which accompanies this distribution. The full text of the license > may be found at > @@ -234,6 +234,7 @@ del /f/q ver_strings >nul >=20 > set > BIOS_Name=3D%BOARD_ID%_%Arch%_%BUILD_TYPE%_%VERSION_MAJOR% > _%VERSION_MINOR%.ROM > copy > /y/b %BUILD_PATH%\FV\Vlv%Arch%.fd %WORKSPACE%\%BIOS_Name% > > nul > +copy > /y/b %BUILD_PATH%\FV\Vlv%Arch%.fd %BUILD_PATH%\FV\Vlv.ROM >nul >=20 > echo. > echo Build location: %BUILD_PATH% > @@ -241,6 +242,11 @@ echo BIOS ROM Created: %BIOS_Name% > echo. > echo -------------------- The EDKII BIOS build has successfully complete= d. > -------------------- > echo. > + > +@REM build capsule here > +if "%openssl_path%" =3D=3D "" goto Exit > +build -p %PLATFORM_PACKAGE%\PlatformCapsule.dsc > + > goto Exit >=20 > :Usage > -- > 2.7.4.windows.1