From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH] SecurityPkg Tcg2Pei: Fix GCC build failure caused by 5919a9600e07
Date: Fri, 23 Sep 2016 02:09:12 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386984CE@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1474596401-182748-1-git-send-email-star.zeng@intel.com>
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Star Zeng
> Sent: Friday, September 23, 2016 10:07 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] SecurityPkg Tcg2Pei: Fix GCC build failure caused by
> 5919a9600e07
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao B Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
> SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> index 8bd5f2cfa507..377f8d9fe45b 100644
> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> @@ -229,9 +229,9 @@ SyncPcrAllocationsAndPcrMask (
> if ((TpmActivePcrBanks & Tpm2PcrMask) != TpmActivePcrBanks) {
> NewTpmActivePcrBanks = TpmActivePcrBanks & Tpm2PcrMask;
>
> - DEBUG ((EFI_D_INFO, __FUNCTION__" - Reallocating PCR banks from
> 0x%X to 0x%X.\n", TpmActivePcrBanks, NewTpmActivePcrBanks ));
> + DEBUG ((EFI_D_INFO, "%a - Reallocating PCR banks from 0x%X to
> 0x%X.\n", __FUNCTION__, TpmActivePcrBanks, NewTpmActivePcrBanks));
> if (NewTpmActivePcrBanks == 0) {
> - DEBUG ((EFI_D_ERROR, __FUNCTION__" - No viable PCRs active!
> Please set a less restrictive value for PcdTpm2HashMask!\n"));
> + DEBUG ((EFI_D_ERROR, "%a - No viable PCRs active! Please set a
> less restrictive value for PcdTpm2HashMask!\n", __FUNCTION__));
> ASSERT (FALSE);
> } else {
> Status = Tpm2PcrAllocateBanks (NULL,
> (UINT32)TpmHashAlgorithmBitmap, NewTpmActivePcrBanks);
> @@ -239,7 +239,7 @@ SyncPcrAllocationsAndPcrMask (
> //
> // We can't do much here, but we hope that this doesn't happen.
> //
> - DEBUG ((EFI_D_ERROR, __FUNCTION__" - Failed to reallocate
> PCRs!\n"));
> + DEBUG ((EFI_D_ERROR, "%a - Failed to reallocate PCRs!\n",
> __FUNCTION__));
> ASSERT_EFI_ERROR (Status);
> }
> //
> @@ -256,9 +256,9 @@ SyncPcrAllocationsAndPcrMask (
> if ((Tpm2PcrMask & TpmHashAlgorithmBitmap) != Tpm2PcrMask) {
> NewTpm2PcrMask = Tpm2PcrMask & TpmHashAlgorithmBitmap;
>
> - DEBUG ((EFI_D_INFO, __FUNCTION__" - Updating PcdTpm2HashMask
> from 0x%X to 0x%X.\n", Tpm2PcrMask, NewTpm2PcrMask ));
> + DEBUG ((EFI_D_INFO, "%a - Updating PcdTpm2HashMask from 0x%X
> to 0x%X.\n", __FUNCTION__, Tpm2PcrMask, NewTpm2PcrMask));
> if (NewTpm2PcrMask == 0) {
> - DEBUG ((EFI_D_ERROR, __FUNCTION__" - No viable PCRs
> supported! Please set a less restrictive value for PcdTpm2HashMask!\n"));
> + DEBUG ((EFI_D_ERROR, "%a - No viable PCRs supported! Please set
> a less restrictive value for PcdTpm2HashMask!\n", __FUNCTION__));
> ASSERT (FALSE);
> }
>
> --
> 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
prev parent reply other threads:[~2016-09-23 2:09 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-23 2:06 [PATCH] SecurityPkg Tcg2Pei: Fix GCC build failure caused by 5919a9600e07 Star Zeng
2016-09-23 2:09 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C50386984CE@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox