From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 92FE91A1E28 for ; Sat, 8 Oct 2016 17:56:25 -0700 (PDT) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga104.jf.intel.com with ESMTP; 08 Oct 2016 17:56:25 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,315,1473145200"; d="scan'208,217";a="770447626" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by FMSMGA003.fm.intel.com with ESMTP; 08 Oct 2016 17:56:25 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 8 Oct 2016 17:56:24 -0700 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 8 Oct 2016 17:56:08 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Sun, 9 Oct 2016 08:56:06 +0800 From: "Yao, Jiewen" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Ni, Ruiyu" , "Tian, Feng" , "Gao, Liming" , "Zeng, Star" , "Dong, Eric" , "Yao, Jiewen" Thread-Topic: [edk2] [PATCH 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD. Thread-Index: AQHSIRAb9s9lfe1OWkqafe7eDB6wLKCexwyAgACGWBA= Date: Sun, 9 Oct 2016 00:56:04 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503869F172@shsmsx102.ccr.corp.intel.com> References: <1475895597-156-1-git-send-email-jiewen.yao@intel.com> <1475895597-156-2-git-send-email-jiewen.yao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 09 Oct 2016 00:56:25 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, I agree. Thanks to catch that. Thank you Yao Jiewen From: Kinney, Michael D Sent: Sunday, October 9, 2016 8:54 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Mi= chael D Cc: Ni, Ruiyu ; Tian, Feng ; Gao, = Liming ; Zeng, Star ; Dong, Eric= Subject: RE: [edk2] [PATCH 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName P= CD. Jiewen, This new PCD is restricted to only support PatchableInMoule. I think it should be moved to support all types and be in section: [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= ewen Yao > Sent: Friday, October 7, 2016 8:00 PM > To: edk2-devel@lists.01.org > Cc: Ni, Ruiyu >; Tian, Feng= >; Gao, Liming > >; Zeng, Star >; Dong, Eric > > > Subject: [edk2] [PATCH 1/3] MdeModulePkg/dec: Add PcdRecoveryFileName PCD= . > > This PCD is used to indicated the recovery file name. > The previous name - FvMain.Fv is hardcoded in FatPei and CdExpressPei. > It does not make sense to force the name. > > Now a platform may use any recovery file name. > > Cc: Feng Tian > > Cc: Star Zeng > > Cc: Liming Gao > > Cc: Eric Dong > > Cc: Ruiyu Ni > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > > --- > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > 1 file changed, 6 insertions(+) > > diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.de= c > index 1e88568..0d0691a 100644 > --- a/MdeModulePkg/MdeModulePkg.dec > +++ b/MdeModulePkg/MdeModulePkg.dec > @@ -1674,6 +1674,12 @@ > # @ValidList 0x80000001 | 0 > > gEfiMdeModulePkgTokenSpaceGuid.PcdLoadFixAddressSmmCodePageNumber|0|UINT3= 2|0x0000002c > > + ## This is recover file name in PEI phase. > + # The file must be in the root directory. > + # The file name must be the 8.3 format. > + # The PCD data must be in UNICODE format. > + gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"FVMAIN.FV"|VOID*|= 0x00001019 > + > [PcdsDynamic, PcdsDynamicEx] > ## This dynamic PCD hold an address to point to private data structure= used in > DxeS3BootScriptLib library > # instance which records the S3 boot script table start address, leng= th, etc. To > introduce this PCD is > -- > 2.7.4.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel