From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C347C1A1E6B for ; Mon, 10 Oct 2016 17:46:34 -0700 (PDT) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 10 Oct 2016 17:46:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,327,1473145200"; d="scan'208,217";a="18295548" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 10 Oct 2016 17:46:33 -0700 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 10 Oct 2016 17:46:22 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 10 Oct 2016 17:46:16 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.15]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.95]) with mapi id 14.03.0248.002; Tue, 11 Oct 2016 08:46:03 +0800 From: "Yao, Jiewen" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Thread-Index: AQHSIcx4TZvpF7UsKE6reSwKh1TvCKCf3H4AgAEu5UCAANvIAIAAhltQ Date: Tue, 11 Oct 2016 00:46:02 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386A0EBB@shsmsx102.ccr.corp.intel.com> References: <1475976509-7580-1-git-send-email-jiewen.yao@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386A07B8@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH V2 0/3] Add PcdRecoveryFileName PCD. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 11 Oct 2016 00:46:34 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes. I just fixed that yesterday on my side. I am surprise it does not appear before. Anyway I will send out V2 patch. From: Kinney, Michael D Sent: Tuesday, October 11, 2016 8:43 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Mi= chael D Subject: RE: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Jiewen, I have resolved my build issue. I have verified that using a recovery filename of L"QUARKREC.Cap" works. However, as part of my testing, I added this PCD to a [PcdsFixedAtBuild] section and the FAT PEIM does not build. With this PCD type the PcdGetPtr(= ) function returns a CONST pointer and the FindRecoveryFile() requires a non CONST pointer. The fix is to cast the value returned by PcdGetPtr() to CHAR16 *. - Status =3D FindRecoveryFile (PrivateData, Index, PcdGetPtr(PcdRecovery= FileName), &Handle); + Status =3D FindRecoveryFile (PrivateData, Index, (CHAR16 *)PcdGetPtr (= PcdRecoveryFileName), &Handle); There are 3 instances of this in the FAT PEIM that need to be fixed. Thanks, Mike From: Yao, Jiewen Sent: Sunday, October 9, 2016 8:37 PM To: Kinney, Michael D >; edk2-devel@lists.01.org Cc: Yao, Jiewen > Subject: RE: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Hi Mike I am surprised to hear that. I double check it just now. It still works well. I am using below: gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"QUARKREC.Cap" What do you configure? Thank you Yao Jiewen From: Kinney, Michael D Sent: Monday, October 10, 2016 1:32 AM To: Yao, Jiewen >; edk2-d= evel@lists.01.org; Kinney, Michael D > Subject: RE: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. Jiewen, Not sure what is wrong, but if I set this PCD to a different value, the recovery image can not be found on the recovery media. For example, if I update Quark DSC to use the value QUARKREC.CAP, and I put that file on the same USB FLASH drive that worked with default value of FVMAIN.FV, the file can not be found. Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= ewen Yao > Sent: Saturday, October 8, 2016 6:28 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH V2 0/3] Add PcdRecoveryFileName PCD. > > The V2 version moves PCD to [PcdsFixedAtBuild, > PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx] > > =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D > This PCD is used to indicated the recovery file name. > The previous name - FvMain.Fv is hardcoded in FatPei and CdExpressPei. > It does not make sense to force the name. > > Now a platform may use any recovery file name. > > Jiewen Yao (3): > MdeModulePkg/dec: Add PcdRecoveryFileName PCD. > MdeModulePkg/CdExpressPei: Use PcdRecoveryFileName PCD. > FatPkg/FatPei: Use PcdRecoveryFileName PCD. > > FatPkg/FatPei/FatLiteApi.c | 8 ++++---- > FatPkg/FatPei/FatLitePeim.h | 4 +--- > FatPkg/FatPei/FatPei.inf | 5 ++++- > MdeModulePkg/MdeModulePkg.dec | 6 ++++++ > MdeModulePkg/Universal/Disk/CdExpressPei/CdExpressPei.inf | 5 ++++- > MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.c | 16 +++++++++= +++++-- > MdeModulePkg/Universal/Disk/CdExpressPei/PeiCdExpress.h | 7 +------ > 7 files changed, 34 insertions(+), 17 deletions(-) > > -- > 2.7.4.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel