From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Mudusuru, Giri P" <giri.p.mudusuru@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH] IntelSiliconPkg: Fixing syntax bug in IGD_OPREGION_HEADER
Date: Wed, 12 Oct 2016 05:10:08 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386B0082@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <2503a66472539eb7d50b87fa5bb88ef325cb72d7.1476248642.git.giri.p.mudusuru@intel.com>
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Mudusuru, Giri P
> Sent: Wednesday, October 12, 2016 1:07 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [edk2] [PATCH] IntelSiliconPkg: Fixing syntax bug in
> IGD_OPREGION_HEADER
>
> Added missing ; for DVER in IGD_OPREGION_HEADER
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> ---
> IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> index 4d5637c..c66a452 100644
> --- a/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> +++ b/IntelSiliconPkg/Include/IndustryStandard/IgdOpRegion.h
> @@ -50,7 +50,7 @@ typedef struct {
> UINT32 MBOX; ///< Offset 0x58 Supported Mailboxes
> UINT32 DMOD; ///< Offset 0x5C Driver Model
> UINT32 PCON; ///< Offset 0x60 Platform Configuration
> - CHAR16 DVER[0x10] ///< Offset 0x64 GOP Version
> + CHAR16 DVER[0x10]; ///< Offset 0x64 GOP Version
> UINT8 RM01[0x7C]; ///< Offset 0x84 Reserved Must be zero
> } IGD_OPREGION_HEADER;
>
> --
> 2.9.0.windows.1
prev parent reply other threads:[~2016-10-12 5:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-12 5:06 [PATCH] IntelSiliconPkg: Fixing syntax bug in IGD_OPREGION_HEADER Giri P Mudusuru
2016-10-12 5:10 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C50386B0082@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox