From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 1FD2D1A1E3A for ; Sat, 15 Oct 2016 06:29:47 -0700 (PDT) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga102.jf.intel.com with ESMTP; 15 Oct 2016 06:29:46 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,497,1473145200"; d="scan'208,217";a="890285884" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga003.jf.intel.com with ESMTP; 15 Oct 2016 06:29:48 -0700 Received: from fmsmsx121.amr.corp.intel.com (10.18.125.36) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 15 Oct 2016 06:29:46 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx121.amr.corp.intel.com (10.18.125.36) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sat, 15 Oct 2016 06:29:45 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0248.002; Sat, 15 Oct 2016 21:29:43 +0800 From: "Yao, Jiewen" To: Tim Lewis , "Ni, Ruiyu" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg Thread-Index: AQHSJf+gvTKmauG0MkuZtnxGccAA7KCn64/QgAABTVD//678gIAB5YXQ Date: Sat, 15 Oct 2016 13:29:42 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386B1CEE@shsmsx102.ccr.corp.intel.com> References: <20161014094431.473584-1-ruiyu.ni@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386B192B@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386B1971@shsmsx102.ccr.corp.intel.com> <7236196A5DF6C040855A6D96F556A53F3F6BEF@msmail.insydesw.com.tw> In-Reply-To: <7236196A5DF6C040855A6D96F556A53F3F6BEF@msmail.insydesw.com.tw> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH 0/5] Move Shell protocol definitions to MdePkg X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 15 Oct 2016 13:29:47 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Of course, it is fine to give a good name in MdePkg. :) My concern is only about "Compatibility". This series patch only updated ArmPkg and EmbeddedPkg. But there might be more close source IP protected packages using the origin= al header file. That is why I propose a compatible way: We give a good file name in MdePkg.= At same time, we can keep the old file name in ShellPkg to include the goo= d name in MdePkg. I recommend we give a solution to make close source package unchanged after= this patch is applied. Thank you Yao Jiewen From: Tim Lewis [mailto:tim.lewis@insyde.com] Sent: Saturday, October 15, 2016 12:21 AM To: Yao, Jiewen ; Ni, Ruiyu ; edk= 2-devel@lists.01.org Subject: RE: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg I prefer the renamed .h file, even though I have substantial investment in = the current infrastructure. Why? Because engineers don't have time to remember "how does protocol X tra= nslate to header file Y" It should be a consistent rule. How many times hav= e I needed to grep the header file name just because I got a build error be= cause the rule wasn't predictable. 1) remove the EFI_ prefix and the _PROTOCOL suffix (EFI_BLOCK_IO_PROTOCOL = -> BLOCK_IO 2) Convert to upper-and-lower case, BLOCK_IO -> Block_Io 3) Remove the _ (Block_Io -> BlockIo) 4) add a .h BlockIo -> BlockIo.h Most protocol and PPI header files already follow this rule. The current he= ader files for shell are among the few exceptions, because they don't follo= w this. Tim -----Original Message----- From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,= Jiewen Sent: Friday, October 14, 2016 6:14 AM To: Yao, Jiewen >; Ni, Ru= iyu >; edk2-devel@lists.01.or= g Subject: Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg Or if you really think we should give a better name. My recommendation is: 1) We add content in MdePkg. 2) We can keep the old protocol file in ShellPkg, but let .h in shellP= kg include the .h in MdePkg. Then we can avoid duplicated code and make it a compatible solution to avoi= d other module update. Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,= Jiewen Sent: Friday, October 14, 2016 9:09 PM To: Ni, Ruiyu >; edk2-devel@l= ists.01.org Subject: Re: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg Hi I think the requests is just to *move*. There is no request to *rename*. Can we just move to avoid other update? > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Ruiyu Ni > Sent: Friday, October 14, 2016 5:44 PM > To: edk2-devel@lists.01.org> > Subject: [edk2] [PATCH 0/5] Move Shell protocol definitions to MdePkg > > The patches moves Shell spec defined protocol definitions to MdePkg > and updates all references. > Content of ShellBase.h is moved to Protocol/Shell.h and ShellBase.h is > removed. > > Ruiyu Ni (5): > ShellPkg: Move SHELL_FREE_NON_NULL from ShellBase.h to ShellLib.h > MdePkg: Include Shell/ShellDynamicCommand/ShellParameters > definitions > ArmPkg/LinuxLoader: Reference Shell protocols in MdePkg > EmbeddedPkg/FdtPlatformDxe: Reference Shell protocols in MdePkg > ShellPkg: Remove Shell/ShellDynamicCommand/ShellParameter > definitions > > ArmPkg/Application/LinuxLoader/LinuxLoader.h | 4 +- > EmbeddedPkg/Drivers/FdtPlatformDxe/FdtPlatform.h | 4 +- > .../EfiShell.h =3D> MdePkg/Include/Protocol/Shell.h | 134 > +++++++++++++++++- > .../Include/Protocol/ShellDynamicCommand.h | 7 +- > .../Include/Protocol/ShellParameters.h | 4 +- > MdePkg/MdePkg.dec | 15 ++ > ShellPkg/Application/Shell/Shell.h | 5 +- > ShellPkg/Include/Library/ShellCommandLib.h | 5 +- > ShellPkg/Include/Library/ShellLib.h | 14 +- > ShellPkg/Include/ShellBase.h | 157 > --------------------- > ShellPkg/Library/UefiDpLib/Dp.h | 3 +- > ShellPkg/Library/UefiDpLib/UefiDpLib.h | 7 +- > .../UefiHandleParsingLib/UefiHandleParsingLib.h | 8 +- > .../UefiShellBcfgCommandLib.c | 5 +- > .../UefiShellCEntryLib/UefiShellCEntryLib.c | 6 +- > .../UefiShellCommandLib/UefiShellCommandLib.h | 7 +- > .../Library/UefiShellDebug1CommandsLib/Compress.c | 7 +- > .../UefiShellDebug1CommandsLib.h | 7 +- > .../UefiShellDriver1CommandsLib.h | 7 +- > .../UefiShellLevel1CommandsLib.h | 7 +- > .../UefiShellLevel2CommandsLib.h | 7 +- > ShellPkg/Library/UefiShellLevel3CommandsLib/Help.c | 2 +- > .../UefiShellLevel3CommandsLib.h | 7 +- > ShellPkg/Library/UefiShellLib/UefiShellLib.c | 1 - > ShellPkg/Library/UefiShellLib/UefiShellLib.h | 6 +- > .../UefiShellNetwork1CommandsLib.h | 3 +- > .../UefiShellTftpCommandLib.h | 3 +- > ShellPkg/ShellPkg.dec | 3 - > ShellPkg/ShellPkg.dsc | 2 + > 29 files changed, 213 insertions(+), 234 deletions(-) rename > ShellPkg/Include/Protocol/EfiShell.h =3D> > MdePkg/Include/Protocol/Shell.h (92%) rename > ShellPkg/Include/Protocol/EfiShellDynamicCommand.h =3D> > MdePkg/Include/Protocol/ShellDynamicCommand.h (92%) rename > ShellPkg/Include/Protocol/EfiShellParameters.h =3D> > MdePkg/Include/Protocol/ShellParameters.h (92%) delete mode 100644 > ShellPkg/Include/ShellBase.h > > -- > 2.9.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org> > https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org> https://lists.01.org/mailman/listinfo/edk2-devel _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel