Re: [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

["Yao, Jiewen" <jiewen.yao@intel.com>]

I remember our deprecation process is:

1)      Core defines DISABLE_NEW_DEPRECATED_INTERFACES and puts a deprecated content in it. (Platform does not use DISABLE_NEW_DEPRECATED_INTERFACES and deprecated function can still be used at this moment. But we strongly recommend a platform doing clean up at same time.)

2)      Platform defines DISABLE_NEW_DEPRECATED_INTERFACES and deprecated function cannot be used after the clean up work.

3)      Core removes the deprecated content and DISABLE_NEW_DEPRECATED_INTERFACES, if we can make sure no platform using it.

4)      Platform may remove DISABLE_NEW_DEPRECATED_INTERFACES.

We do not want to remove a function directly, to break lots of platforms. We just want to give a buffer to let platform do code cleanup.

Thank you
Yao Jiewen

From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Laszlo Ersek
Sent: Saturday, October 22, 2016 6:31 AM
To: Justen, Jordan L <jordan.l.justen@intel.com>; Andrew Fish <afish@apple.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel-01 <edk2-devel@ml01.01.org>; Leif Lindholm <leif.lindholm@linaro.org>; Gao, Liming <liming.gao@intel.com>; Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files

On 10/22/16 00:10, Jordan Justen wrote:
> On 2016-10-21 14:02:44, Laszlo Ersek wrote:

>> Honestly, I imagined that DISABLE_NEW_DEPRECATED_INTERFACES would be
>> temporary in the edk2 tree. That is, it's a means so we can gradually
>> transition with all the in-tree stuff to a deprecationless code base.
>> Once that's done -- i.e., *all* platform DSCs within the edk2 tree
>> specify this feature test macro under their respective [BuildOptions]
>> sections --, then whatever the macro excises from the core packages can
>> be removed permanently, together with those platform [BuildOptions].
>>
>
> That could be reasonable, although I'd argue that we could flip it
> around. Opt-in to the deprecated interfaces on all platforms, and then
> start marking deprecated interfaces. Finally we could clean up
> platforms and removed the override.

That's a valid idea, IMO.

> But ... I think DISABLE_NEW_DEPRECATED_INTERFACES was first added in:
>
> commit bf4a3dbd4751b6411bdfc98bf3ac2c4f928bdfdf
> Author: ydong10 <ydong10@6f19259b-4bc3-4df7-8a09-765794883524>
> Date:   Wed May 30 07:36:00 2012 +0000
>
> So, I guess it is not going to be removed anytime soon. :(

I believe we just need to make progress with the individual platforms
(and their dependencies from other Pkgs). It's not a lot of fun, but the
BZs exist (well, they can be filed) now, and then we can address them...

I mean, I didn't care (or, really, know) about
DISABLE_NEW_DEPRECATED_INTERFACES until the ArmVirtPkg / OvmfPkg BZs got
filed. Bugzilla is great. I like the attention that it gets, from others
and from myself.

Thanks
Laszlo
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel