From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 4E7781A1DF8 for ; Fri, 21 Oct 2016 16:13:20 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 21 Oct 2016 16:13:19 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,527,1473145200"; d="scan'208,217";a="1073934391" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga002.fm.intel.com with ESMTP; 21 Oct 2016 16:13:19 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 21 Oct 2016 16:13:19 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 21 Oct 2016 16:13:19 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0248.002; Sat, 22 Oct 2016 07:13:17 +0800 From: "Yao, Jiewen" To: Laszlo Ersek , "Justen, Jordan L" , Andrew Fish CC: "Kinney, Michael D" , edk2-devel-01 , Leif Lindholm , "Gao, Liming" , Ard Biesheuvel Thread-Topic: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files Thread-Index: AQHSK9KZT/STCFLtk0ywZ7+xg57HkaCyzUwAgAAGLICAAAU3gIAABn8AgAAS5QCAAAXjAIAAjqkg Date: Fri, 21 Oct 2016 23:13:16 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386B5630@shsmsx102.ccr.corp.intel.com> References: <147707992484.13791.10042868456965197315@jljusten-ivb> <147708236992.14194.656313834108120082@jljusten-ivb> <147708782254.15094.11260195572460159641@jljusten-ivb> <32ac0268-7b31-5a41-358a-b876ad6ae8cd@redhat.com> In-Reply-To: <32ac0268-7b31-5a41-358a-b876ad6ae8cd@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECATED_INTERFACES" in package DSC files X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2016 23:13:20 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I remember our deprecation process is: 1) Core defines DISABLE_NEW_DEPRECATED_INTERFACES and puts a deprecate= d content in it. (Platform does not use DISABLE_NEW_DEPRECATED_INTERFACES a= nd deprecated function can still be used at this moment. But we strongly re= commend a platform doing clean up at same time.) 2) Platform defines DISABLE_NEW_DEPRECATED_INTERFACES and deprecated f= unction cannot be used after the clean up work. 3) Core removes the deprecated content and DISABLE_NEW_DEPRECATED_INTE= RFACES, if we can make sure no platform using it. 4) Platform may remove DISABLE_NEW_DEPRECATED_INTERFACES. We do not want to remove a function directly, to break lots of platforms. W= e just want to give a buffer to let platform do code cleanup. Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Lasz= lo Ersek Sent: Saturday, October 22, 2016 6:31 AM To: Justen, Jordan L ; Andrew Fish Cc: Kinney, Michael D ; edk2-devel-01 ; Leif Lindholm ; Gao, Liming ; Ard Biesheuvel Subject: Re: [edk2] [Bug 164] Add the build option "/D DISABLE_NEW_DEPRECAT= ED_INTERFACES" in package DSC files On 10/22/16 00:10, Jordan Justen wrote: > On 2016-10-21 14:02:44, Laszlo Ersek wrote: >> Honestly, I imagined that DISABLE_NEW_DEPRECATED_INTERFACES would be >> temporary in the edk2 tree. That is, it's a means so we can gradually >> transition with all the in-tree stuff to a deprecationless code base. >> Once that's done -- i.e., *all* platform DSCs within the edk2 tree >> specify this feature test macro under their respective [BuildOptions] >> sections --, then whatever the macro excises from the core packages can >> be removed permanently, together with those platform [BuildOptions]. >> > > That could be reasonable, although I'd argue that we could flip it > around. Opt-in to the deprecated interfaces on all platforms, and then > start marking deprecated interfaces. Finally we could clean up > platforms and removed the override. That's a valid idea, IMO. > But ... I think DISABLE_NEW_DEPRECATED_INTERFACES was first added in: > > commit bf4a3dbd4751b6411bdfc98bf3ac2c4f928bdfdf > Author: ydong10 > Date: Wed May 30 07:36:00 2012 +0000 > > So, I guess it is not going to be removed anytime soon. :( I believe we just need to make progress with the individual platforms (and their dependencies from other Pkgs). It's not a lot of fun, but the BZs exist (well, they can be filed) now, and then we can address them... I mean, I didn't care (or, really, know) about DISABLE_NEW_DEPRECATED_INTERFACES until the ArmVirtPkg / OvmfPkg BZs got filed. Bugzilla is great. I like the attention that it gets, from others and from myself. Thanks Laszlo _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel