Re: [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB and VBT data

["Yao, Jiewen" <jiewen.yao@intel.com>]

Thanks for the patch. I have 2 minor comments:

1) below update seems unnecessary. It makes me confused. We did not change anything right? Can we skip it?
-  DEC_SPECIFICATION              = 0x00010005
-  PACKAGE_NAME                   = IntelSiliconPkg
-  PACKAGE_GUID                   = F7A58914-FA0E-4F71-BD6A-220FDF824A49
-  PACKAGE_VERSION                = 0.1
+  DEC_SPECIFICATION               = 0x00010005
+  PACKAGE_NAME                    = IntelSiliconPkg
+  PACKAGE_GUID                    = F7A58914-FA0E-4F71-BD6A-220FDF824A49
+  PACKAGE_VERSION                 = 0.1

2) Can we add one line to describe the VBT in more detail? If this is FFS GUID, or HOB GUID, PROTOCOL GUID? How is produced and consumed?
> +  ## GUID for Graphics Video BIOS Table (VBT) Data
> +  gIntelGraphicsVbtDataGuid       = { 0x56752da9, 0xde6b, 0x4895,
> { 0x88, 0x19, 0x19, 0x45, 0xb6, 0xb7, 0x6c, 0x22 }}

I think below example is much better:
> +  ## HOB GUID to publish SMBIOS data records from PEI phase
> +  # Generic DXE Library / Driver can locate HOB(s) and add SMBIOS records
> into SMBIOS table
> +  gIntelSmbiosDataHobGuid         = { 0x798e722e, 0x15b2, 0x4e13,
> { 0x8a, 0xe9, 0x6b, 0xa3, 0x0f, 0xf7, 0xf1, 0x67 }}



Thank you
Yao Jiewen


> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Giri P Mudusuru
> Sent: Saturday, October 22, 2016 12:18 AM
> To: edk2-devel@lists.01.org
> Cc: Kinney, Michael D <michael.d.kinney@intel.com>; Yao, Jiewen
> <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB
> and VBT data
> 
> Add gIntelSmbiosDataHobGuid and gIntelGraphicsVbtDataGuid GUIDs
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Michael Kinney <michael.d.kinney@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com>
> ---
>  IntelSiliconPkg/IntelSiliconPkg.dec | 19 ++++++++++++++-----
>  1 file changed, 14 insertions(+), 5 deletions(-)
> 
> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec
> b/IntelSiliconPkg/IntelSiliconPkg.dec
> index e42dbad..556fe76 100644
> --- a/IntelSiliconPkg/IntelSiliconPkg.dec
> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec
> @@ -1,5 +1,5 @@
>  ## @file
> -# IntelSilicon Package
> +# Intel Silicon Package
>  #
>  # This package provides common open source Intel silicon modules.
>  #
> @@ -15,10 +15,19 @@
>  ##
> 
>  [Defines]
> -  DEC_SPECIFICATION              = 0x00010005
> -  PACKAGE_NAME                   = IntelSiliconPkg
> -  PACKAGE_GUID                   =
> F7A58914-FA0E-4F71-BD6A-220FDF824A49
> -  PACKAGE_VERSION                = 0.1
> +  DEC_SPECIFICATION               = 0x00010005
> +  PACKAGE_NAME                    = IntelSiliconPkg
> +  PACKAGE_GUID                    =
> F7A58914-FA0E-4F71-BD6A-220FDF824A49
> +  PACKAGE_VERSION                 = 0.1
> 
>  [Includes]
>    Include
> +
> +[Guids]
> +  ## GUID for Graphics Video BIOS Table (VBT) Data
> +  gIntelGraphicsVbtDataGuid       = { 0x56752da9, 0xde6b, 0x4895,
> { 0x88, 0x19, 0x19, 0x45, 0xb6, 0xb7, 0x6c, 0x22 }}
> +
> +  ## HOB GUID to publish SMBIOS data records from PEI phase
> +  # Generic DXE Library / Driver can locate HOB(s) and add SMBIOS records
> into SMBIOS table
> +  gIntelSmbiosDataHobGuid         = { 0x798e722e, 0x15b2, 0x4e13,
> { 0x8a, 0xe9, 0x6b, 0xa3, 0x0f, 0xf7, 0xf1, 0x67 }}
> +
> --
> 2.9.0.windows.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel