From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A8FA61A1DF8 for ; Fri, 21 Oct 2016 16:42:39 -0700 (PDT) Received: from fmsmga002.fm.intel.com ([10.253.24.26]) by orsmga102.jf.intel.com with ESMTP; 21 Oct 2016 16:42:39 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,527,1473145200"; d="scan'208";a="1073942487" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga002.fm.intel.com with ESMTP; 21 Oct 2016 16:42:39 -0700 Received: from fmsmsx154.amr.corp.intel.com (10.18.116.70) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 21 Oct 2016 16:42:39 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX154.amr.corp.intel.com (10.18.116.70) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 21 Oct 2016 16:42:38 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0248.002; Sat, 22 Oct 2016 07:42:36 +0800 From: "Yao, Jiewen" To: "Mudusuru, Giri P" , "edk2-devel@lists.01.org" CC: "Kinney, Michael D" , "Zeng, Star" , "Yao, Jiewen" Thread-Topic: [edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB and VBT data Thread-Index: AQHSK7a6JkPcBd2g9Uu84Cxn0KI7KqCzkT4Q Date: Fri, 21 Oct 2016 23:42:35 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386B5703@shsmsx102.ccr.corp.intel.com> References: In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB and VBT data X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 21 Oct 2016 23:42:39 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks for the patch. I have 2 minor comments: 1) below update seems unnecessary. It makes me confused. We did not change = anything right? Can we skip it? - DEC_SPECIFICATION =3D 0x00010005 - PACKAGE_NAME =3D IntelSiliconPkg - PACKAGE_GUID =3D F7A58914-FA0E-4F71-BD6A-220FDF824A49 - PACKAGE_VERSION =3D 0.1 + DEC_SPECIFICATION =3D 0x00010005 + PACKAGE_NAME =3D IntelSiliconPkg + PACKAGE_GUID =3D F7A58914-FA0E-4F71-BD6A-220FDF824A49 + PACKAGE_VERSION =3D 0.1 2) Can we add one line to describe the VBT in more detail? If this is FFS G= UID, or HOB GUID, PROTOCOL GUID? How is produced and consumed? > + ## GUID for Graphics Video BIOS Table (VBT) Data > + gIntelGraphicsVbtDataGuid =3D { 0x56752da9, 0xde6b, 0x4895, > { 0x88, 0x19, 0x19, 0x45, 0xb6, 0xb7, 0x6c, 0x22 }} I think below example is much better: > + ## HOB GUID to publish SMBIOS data records from PEI phase > + # Generic DXE Library / Driver can locate HOB(s) and add SMBIOS record= s > into SMBIOS table > + gIntelSmbiosDataHobGuid =3D { 0x798e722e, 0x15b2, 0x4e13, > { 0x8a, 0xe9, 0x6b, 0xa3, 0x0f, 0xf7, 0xf1, 0x67 }} Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Giri P Mudusuru > Sent: Saturday, October 22, 2016 12:18 AM > To: edk2-devel@lists.01.org > Cc: Kinney, Michael D ; Yao, Jiewen > ; Zeng, Star > Subject: [edk2] [PATCH] IntelSiliconPkg: Add GUIDs for SMBIOS data HOB > and VBT data >=20 > Add gIntelSmbiosDataHobGuid and gIntelGraphicsVbtDataGuid GUIDs >=20 > Cc: Jiewen Yao > Cc: Star Zeng > Cc: Michael Kinney > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Giri P Mudusuru > --- > IntelSiliconPkg/IntelSiliconPkg.dec | 19 ++++++++++++++----- > 1 file changed, 14 insertions(+), 5 deletions(-) >=20 > diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec > b/IntelSiliconPkg/IntelSiliconPkg.dec > index e42dbad..556fe76 100644 > --- a/IntelSiliconPkg/IntelSiliconPkg.dec > +++ b/IntelSiliconPkg/IntelSiliconPkg.dec > @@ -1,5 +1,5 @@ > ## @file > -# IntelSilicon Package > +# Intel Silicon Package > # > # This package provides common open source Intel silicon modules. > # > @@ -15,10 +15,19 @@ > ## >=20 > [Defines] > - DEC_SPECIFICATION =3D 0x00010005 > - PACKAGE_NAME =3D IntelSiliconPkg > - PACKAGE_GUID =3D > F7A58914-FA0E-4F71-BD6A-220FDF824A49 > - PACKAGE_VERSION =3D 0.1 > + DEC_SPECIFICATION =3D 0x00010005 > + PACKAGE_NAME =3D IntelSiliconPkg > + PACKAGE_GUID =3D > F7A58914-FA0E-4F71-BD6A-220FDF824A49 > + PACKAGE_VERSION =3D 0.1 >=20 > [Includes] > Include > + > +[Guids] > + ## GUID for Graphics Video BIOS Table (VBT) Data > + gIntelGraphicsVbtDataGuid =3D { 0x56752da9, 0xde6b, 0x4895, > { 0x88, 0x19, 0x19, 0x45, 0xb6, 0xb7, 0x6c, 0x22 }} > + > + ## HOB GUID to publish SMBIOS data records from PEI phase > + # Generic DXE Library / Driver can locate HOB(s) and add SMBIOS record= s > into SMBIOS table > + gIntelSmbiosDataHobGuid =3D { 0x798e722e, 0x15b2, 0x4e13, > { 0x8a, 0xe9, 0x6b, 0xa3, 0x0f, 0xf7, 0xf1, 0x67 }} > + > -- > 2.9.0.windows.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel