From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1 with cipher CAMELLIA256-SHA (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 373251A1E43 for ; Wed, 26 Oct 2016 18:31:42 -0700 (PDT) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga102.fm.intel.com with ESMTP; 26 Oct 2016 18:31:41 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,404,1473145200"; d="scan'208,217";a="1050824444" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by orsmga001.jf.intel.com with ESMTP; 26 Oct 2016 18:31:41 -0700 Received: from fmsmsx153.amr.corp.intel.com (10.18.125.6) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 26 Oct 2016 18:31:41 -0700 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX153.amr.corp.intel.com (10.18.125.6) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 26 Oct 2016 18:31:40 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.139]) with mapi id 14.03.0248.002; Thu, 27 Oct 2016 09:31:38 +0800 From: "Yao, Jiewen" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Tian, Feng" , "Gao, Liming" , "Zeng, Star" , "Zhang, Chao B" Thread-Topic: [edk2] [PATCH V4 1/8] QuarkPlatformPkg/dec: Add test key file guid. Thread-Index: AQHSLNWi4908bquLt0ausc1ubVt286C7As+AgACHKOA= Date: Thu, 27 Oct 2016 01:31:37 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386B8261@shsmsx102.ccr.corp.intel.com> References: <1477189908-8336-1-git-send-email-jiewen.yao@intel.com> <1477189908-8336-2-git-send-email-jiewen.yao@intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH V4 1/8] QuarkPlatformPkg/dec: Add test key file guid. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 27 Oct 2016 01:31:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Agree. I will move the 2 PCD to SignedCapsulePkg. From: Kinney, Michael D Sent: Thursday, October 27, 2016 9:28 AM To: Yao, Jiewen ; edk2-devel@lists.01.org; Kinney, Mi= chael D Cc: Tian, Feng ; Gao, Liming ; Z= eng, Star ; Zhang, Chao B Subject: RE: [edk2] [PATCH V4 1/8] QuarkPlatformPkg/dec: Add test key file = guid. Jiewen, Why are these 2 PCDs added to a platform specific DEC file? The same feedback applies to the Vlv2 platform. Since we want platform agnostic detection for the use of test keys, these PCDs should be added to SignedCapsulePkg. I think the best place to do the check for use of test keys and set the gEfiMdeModulePkgTokenSpaceGuid.PcdTestKeyUsed PCD is in a module in SignedCapsulePkg that is required to be present and run every boot before BDS runs when recovery or capsule support is enabled. In a previous feedback email I suggested that this test key check be moved to BdsEntry.c, but that will not work because that module does not have access to PCDs defined in SignedCapsulePkg. Best regards, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ji= ewen Yao > Sent: Saturday, October 22, 2016 7:32 PM > To: edk2-devel@lists.01.org > Cc: Tian, Feng >; Gao, Li= ming >; Zeng, Star > >; Kinney, Michael D >; Zhang, Chao B > > > Subject: [edk2] [PATCH V4 1/8] QuarkPlatformPkg/dec: Add test key file gu= id. > > We will add PKCS7 and RSA2048SHA256 test key file to FDF, > to check if the platform is using default test key, > or different production key. > > Cc: Michael D Kinney > > Cc: Kelly Steele > > Cc: Feng Tian > > Cc: Star Zeng > > Cc: Liming Gao > > Cc: Chao Zhang > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > > --- > QuarkPlatformPkg/QuarkPlatformPkg.dec | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/QuarkPlatformPkg/QuarkPlatformPkg.dec > b/QuarkPlatformPkg/QuarkPlatformPkg.dec > index f4ab18c..fbd7987 100644 > --- a/QuarkPlatformPkg/QuarkPlatformPkg.dec > +++ b/QuarkPlatformPkg/QuarkPlatformPkg.dec > @@ -895,6 +895,9 @@ > gQuarkPlatformTokenSpaceGuid.PcdFlashFvRecoveryBase|0xFFEC0400|UINT32|= 0xA00002AB > gQuarkPlatformTokenSpaceGuid.PcdFlashFvRecoverySize|0x0003F000|UINT32|= 0xA00002AC > > + gQuarkPlatformTokenSpaceGuid.PcdEdkiiRsa2048Sha256TestPublicKeyFileGui= d|{0x04, 0xe1, > 0xfe, 0xc4, 0x57, 0x66, 0x36, 0x49, 0xa6, 0x11, 0x13, 0x8d, 0xbc, 0x2a, 0= x76, > 0xad}|VOID*|0xA0010001 > + gQuarkPlatformTokenSpaceGuid.PcdEdkiiPkcs7TestPublicKeyFileGuid|{0xba,= 0xf5, 0x93, > 0xf0, 0x37, 0x6f, 0x16, 0x48, 0x9e, 0x52, 0x91, 0xbe, 0xa0, 0xf7, 0xe0, > 0xb8}|VOID*|0xA0010002 > + > [PcdsDynamic, PcdsDynamicEx] > ## Provides the ability to enable the Fast Boot feature of the BIOS. = This > # enables the system to boot faster but may only enumerate the hardwa= re > -- > 2.7.4.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel