Re: [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID

["Yao, Jiewen" <jiewen.yao@intel.com>]

Ah, I see. That makes sense. No need to add .h file.

reviewed-by: Jiewen.yao@intel.com<mailto:Jiewen.yao@intel.com>


From: Mudusuru, Giri P
Sent: Tuesday, November 1, 2016 9:50 AM
To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
Cc: Zeng, Star <star.zeng@intel.com>; Kinney, Michael D <michael.d.kinney@intel.com>
Subject: RE: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID

Hi Jiewen,
With the feature added last year (see below patch) the AutoGen.h will include the extern for the GUIDs. So no need for additional .h file.
https://github.com/tianocore/edk2/commit/8262037ff851b4beaa011ca96012876bf7c40f94

Thanks,
-Giri

From: Yao, Jiewen
Sent: Monday, October 31, 2016 5:48 PM
To: Mudusuru, Giri P <giri.p.mudusuru@intel.com<mailto:giri.p.mudusuru@intel.com>>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
Cc: Zeng, Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>; Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
Subject: RE: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID

HI Giri
I believe we also need .h file to let .c file include this GUID, right?

Will there be another patch to address that?

If so, this patch is reviewed-by: Jiewen.yao@intel.com<mailto:Jiewen.yao@intel.com>



> -----Original Message-----
> From: Mudusuru, Giri P
> Sent: Tuesday, November 1, 2016 12:57 AM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Zeng, Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>;
> Kinney, Michael D <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> Subject: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID
>
> Add gIntelSmbiosDataHobGuid used to publish SMBIOS data from PEI phase.
> The HOB data format will be same as SMBIOS spec define formats for
> Types 0 to 127 and OEM defined types for 128 to 255.
>
> Generic library or DXE driver can add SMBIOS records using this HOB(s).
>
> Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> Cc: Star Zeng <star.zeng@intel.com<mailto:star.zeng@intel.com>>
> Cc: Michael Kinney <michael.d.kinney@intel.com<mailto:michael.d.kinney@intel.com>>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Giri P Mudusuru <giri.p.mudusuru@intel.com<mailto:giri.p.mudusuru@intel.com>>
> ---
>  IntelSiliconPkg/IntelSiliconPkg.dec | 7 +++++++
>  1 file changed, 7 insertions(+)
>
> diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec
> b/IntelSiliconPkg/IntelSiliconPkg.dec
> index e42dbad..84b0764 100644
> --- a/IntelSiliconPkg/IntelSiliconPkg.dec
> +++ b/IntelSiliconPkg/IntelSiliconPkg.dec
> @@ -22,3 +22,10 @@
>
>  [Includes]
>    Include
> +
> +[Guids]
> +  ## HOB GUID to publish SMBIOS data records from PEI phase
> +  # HOB data format is same as SMBIOS records defined in SMBIOS spec or
> OEM defined types
> +  # Generic DXE Library / Driver can locate HOB(s) and add SMBIOS records
> into SMBIOS table
> +  gIntelSmbiosDataHobGuid         = { 0x798e722e, 0x15b2, 0x4e13,
> { 0x8a, 0xe9, 0x6b, 0xa3, 0x0f, 0xf7, 0xf1, 0x67 }}
> +
> --
> 2.9.0.windows.1