From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id E574881CE6 for ; Mon, 31 Oct 2016 18:57:16 -0700 (PDT) Received: from fmsmga001.fm.intel.com ([10.253.24.23]) by orsmga104.jf.intel.com with ESMTP; 31 Oct 2016 18:57:17 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,577,1473145200"; d="scan'208,217";a="1062107673" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by fmsmga001.fm.intel.com with ESMTP; 31 Oct 2016 18:57:17 -0700 Received: from fmsmsx116.amr.corp.intel.com (10.18.116.20) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 31 Oct 2016 18:57:17 -0700 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by fmsmsx116.amr.corp.intel.com (10.18.116.20) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 31 Oct 2016 18:57:17 -0700 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.206]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.2]) with mapi id 14.03.0248.002; Tue, 1 Nov 2016 09:57:16 +0800 From: "Yao, Jiewen" To: "Mudusuru, Giri P" , "edk2-devel@lists.01.org" CC: "Zeng, Star" , "Kinney, Michael D" Thread-Topic: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID Thread-Index: AQHSM5fIe+3InFsL6Uen/jFR9Vs8h6DDS4Dg//+LoQCAAIgLMA== Date: Tue, 1 Nov 2016 01:57:15 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386BAA0A@shsmsx102.ccr.corp.intel.com> References: <4b866b9ccd55f9b8a745593c143a253eda54dadc.1477926962.git.giri.p.mudusuru@intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386BA8AC@shsmsx102.ccr.corp.intel.com> <4666AEFED60F8E4198B42BB01DCEABDF76F2EB18@ORSMSX113.amr.corp.intel.com> In-Reply-To: <4666AEFED60F8E4198B42BB01DCEABDF76F2EB18@ORSMSX113.amr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 01 Nov 2016 01:57:17 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ah, I see. That makes sense. No need to add .h file. reviewed-by: Jiewen.yao@intel.com From: Mudusuru, Giri P Sent: Tuesday, November 1, 2016 9:50 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Zeng, Star ; Kinney, Michael D Subject: RE: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID Hi Jiewen, With the feature added last year (see below patch) the AutoGen.h will inclu= de the extern for the GUIDs. So no need for additional .h file. https://github.com/tianocore/edk2/commit/8262037ff851b4beaa011ca96012876bf7= c40f94 Thanks, -Giri From: Yao, Jiewen Sent: Monday, October 31, 2016 5:48 PM To: Mudusuru, Giri P >; edk2-devel@lists.01.org Cc: Zeng, Star >; Kinney, M= ichael D > Subject: RE: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID HI Giri I believe we also need .h file to let .c file include this GUID, right? Will there be another patch to address that? If so, this patch is reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Mudusuru, Giri P > Sent: Tuesday, November 1, 2016 12:57 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen >; Zeng= , Star >; > Kinney, Michael D > > Subject: [edk2] [PATCH] IntelSiliconPkg: Add SMBIOS data HOB GUID > > Add gIntelSmbiosDataHobGuid used to publish SMBIOS data from PEI phase. > The HOB data format will be same as SMBIOS spec define formats for > Types 0 to 127 and OEM defined types for 128 to 255. > > Generic library or DXE driver can add SMBIOS records using this HOB(s). > > Cc: Jiewen Yao > > Cc: Star Zeng > > Cc: Michael Kinney > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Giri P Mudusuru > > --- > IntelSiliconPkg/IntelSiliconPkg.dec | 7 +++++++ > 1 file changed, 7 insertions(+) > > diff --git a/IntelSiliconPkg/IntelSiliconPkg.dec > b/IntelSiliconPkg/IntelSiliconPkg.dec > index e42dbad..84b0764 100644 > --- a/IntelSiliconPkg/IntelSiliconPkg.dec > +++ b/IntelSiliconPkg/IntelSiliconPkg.dec > @@ -22,3 +22,10 @@ > > [Includes] > Include > + > +[Guids] > + ## HOB GUID to publish SMBIOS data records from PEI phase > + # HOB data format is same as SMBIOS records defined in SMBIOS spec or > OEM defined types > + # Generic DXE Library / Driver can locate HOB(s) and add SMBIOS record= s > into SMBIOS table > + gIntelSmbiosDataHobGuid =3D { 0x798e722e, 0x15b2, 0x4e13, > { 0x8a, 0xe9, 0x6b, 0xa3, 0x0f, 0xf7, 0xf1, 0x67 }} > + > -- > 2.9.0.windows.1