From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Yao, Jiewen" <jiewen.yao@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Tian, Feng" <feng.tian@intel.com>,
"Kinney, Michael D" <michael.d.kinney@intel.com>,
Paolo Bonzini <pbonzini@redhat.com>,
"Laszlo Ersek" <lersek@redhat.com>,
"Fan, Jeff" <jeff.fan@intel.com>,
"Zeng, Star" <star.zeng@intel.com>
Subject: Re: [PATCH V3 0/6] Enable SMM page level protection.
Date: Fri, 11 Nov 2016 09:12:16 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386CF501@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1478854859-11096-1-git-send-email-jiewen.yao@intel.com>
HI Laszlo
I fixed the IA32 boot issue in this patch with DEBUG message update you suggested.
My unit test failed before. Now it can pass.
I validated on a real IA32 and Windows OVMF with and without XD.
For QEMU installation, it is still on progress.
We have setup a Fedora 24 host, download QEMU, and install it.
But we are still struggling to make QEMU boot on Fedora.
Your step by step is great. There is still some minor place we stuck in due to my ignorance.
My goal is still to setup an environment like yours for our validation or issue reproduce.
It just need take some time, more than I expected. sign...
Thank you
Yao Jiewen
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Jiewen Yao
> Sent: Friday, November 11, 2016 5:01 PM
> To: edk2-devel@lists.01.org
> Cc: Tian, Feng <feng.tian@intel.com>; Kinney, Michael D
> <michael.d.kinney@intel.com>; Paolo Bonzini <pbonzini@redhat.com>;
> Laszlo Ersek <lersek@redhat.com>; Fan, Jeff <jeff.fan@intel.com>; Zeng,
> Star <star.zeng@intel.com>
> Subject: [edk2] [PATCH V3 0/6] Enable SMM page level protection.
>
>
> ==== below is V3 description ====
> 1) PiSmmCpu: Fix CpuIndex corruption issue due to stack malposition.
> (Many thanks to Laszlo Ersek <lersek@redhat.com> for catching it.)
> 2) PiSmmCpu: Add ASSERT for CpuIndex check.
> 3) PiSmmCpu: Use DEBUG_VERBOSE for page table update.
> 4) PiSmmCpu: Do not report DEBUG message for Ap non present
> when PcdCpuSmmSyncMode==1 (Relex mode).
> 5) PiSmmCpu: Do not report DEBUG message for AP removed
> when PcdCpuHotPlugSupport==TRUE.
>
> Tested combination:
> 1) XD disabled
> 2) XD enabled in SMM and disabled in non-SMM.
> 3) XD enabled in SMM and enabled in non-SMM.
>
> ==== below is V2 description ====
> 1) PiSmmCpu: resolve OVMF multiple processors boot hang issue.
> 2) PiSmmCpu: Add debug info on StartupAp() fails.
> 3) PiSmmCpu: Add ASSERT for AllocatePages().
> 4) PiSmmCpu: Add protection detail in commit message.
> 5) UefiCpuPkg.dsc: Add page table footprint info in commit message.
>
> ==== below is V1 description ====
> This series patch enables SMM page level protection.
> Features are:
> 1) PiSmmCore reports SMM PE image code/data information
> in EdkiiPiSmmMemoryAttributeTable, if the SMM image is page aligned.
> 2) PiSmmCpu consumes EdkiiPiSmmMemoryAttributeTable
> and set XD for data page and RO for code page.
> 3) PiSmmCpu enables Static Paging for X64 according to
> PcdCpuSmmStaticPageTable. If it is true, 1G paging for above 4G
> is used as long as it is supported.
> 4) PiSmmCpu sets importance data structure to be read only,
> such as Gdt, Idt, SmmEntrypoint, and PageTable itself.
>
> tested platform:
> 1) Intel internal platform (X64).
> 2) EDKII Quark IA32
> 3) EDKII Vlv2 X64
> 4) EDKII OVMF IA32 and IA32X64. (with -smp 8)
>
> Cc: Jeff Fan <jeff.fan@intel.com>
> Cc: Feng Tian <feng.tian@intel.com>
> Cc: Star Zeng <star.zeng@intel.com>
> Cc: Michael D Kinney <michael.d.kinney@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Paolo Bonzini <pbonzini@redhat.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com>
>
> Jiewen Yao (6):
> MdeModulePkg/Include: Add PiSmmMemoryAttributesTable.h
> MdeModulePkg/dec: Add gEdkiiPiSmmMemoryAttributesTableGuid.
> MdeModulePkg/PiSmmCore: Add MemoryAttributes support.
> UefiCpuPkg/dec: Add PcdCpuSmmStaticPageTable.
> UefiCpuPkg/PiSmmCpuDxeSmm: Add paging protection.
> QuarkPlatformPkg/dsc: enable Smm paging protection.
>
> MdeModulePkg/Core/PiSmmCore/Dispatcher.c | 66 +
> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 1509
> ++++++++++++++++++++
> MdeModulePkg/Core/PiSmmCore/Page.c | 775
> +++++++++-
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.c | 40
> +
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.h | 91
> ++
> MdeModulePkg/Core/PiSmmCore/PiSmmCore.inf | 2
> +
> MdeModulePkg/Core/PiSmmCore/Pool.c | 16
> +
> MdeModulePkg/Include/Guid/PiSmmMemoryAttributesTable.h | 51 +
> MdeModulePkg/MdeModulePkg.dec |
> 3 +
> QuarkPlatformPkg/Quark.dsc | 6 +
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/PageTbl.c | 71
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.S | 75
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.asm | 75
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiEntry.nasm | 79
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.S | 226
> +--
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.asm | 36
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmiException.nasm | 36
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmFuncsArch.c | 37
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/Ia32/SmmProfileArch.c | 4
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 135
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.c |
> 144 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.h |
> 156 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/PiSmmCpuDxeSmm.inf |
> 5 +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c |
> 871 +++++++++++
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.c | 39
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmProfile.h | 15
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/PageTbl.c | 274
> +++-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.S | 59
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.asm | 62
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiEntry.nasm | 69
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.S | 250
> +---
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.asm | 35
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmiException.nasm | 31
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmFuncsArch.c | 30
> +-
> UefiCpuPkg/PiSmmCpuDxeSmm/X64/SmmProfileArch.c | 7
> +-
> UefiCpuPkg/UefiCpuPkg.dec | 8 +
> 36 files changed, 4585 insertions(+), 803 deletions(-)
> create mode 100644
> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> create mode 100644
> MdeModulePkg/Include/Guid/PiSmmMemoryAttributesTable.h
> create mode 100644
> UefiCpuPkg/PiSmmCpuDxeSmm/SmmCpuMemoryManagement.c
>
> --
> 2.7.4.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
next prev parent reply other threads:[~2016-11-11 9:12 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-11 9:00 [PATCH V3 0/6] Enable SMM page level protection Jiewen Yao
2016-11-11 9:00 ` [PATCH V3 1/6] MdeModulePkg/Include: Add PiSmmMemoryAttributesTable.h Jiewen Yao
2016-11-11 9:00 ` [PATCH V3 2/6] MdeModulePkg/dec: Add gEdkiiPiSmmMemoryAttributesTableGuid Jiewen Yao
2016-11-11 9:00 ` [PATCH V3 3/6] MdeModulePkg/PiSmmCore: Add MemoryAttributes support Jiewen Yao
2016-11-11 9:00 ` [PATCH V3 4/6] UefiCpuPkg/dec: Add PcdCpuSmmStaticPageTable Jiewen Yao
2016-11-11 9:00 ` [PATCH V3 5/6] UefiCpuPkg/PiSmmCpuDxeSmm: Add paging protection Jiewen Yao
2016-11-11 9:00 ` [PATCH V3 6/6] QuarkPlatformPkg/dsc: enable Smm " Jiewen Yao
2016-11-11 9:12 ` Yao, Jiewen [this message]
2016-11-11 12:26 ` [PATCH V3 0/6] Enable SMM page level protection Laszlo Ersek
2016-11-11 12:38 ` Fan, Jeff
2016-11-11 12:52 ` Laszlo Ersek
2016-11-11 12:53 ` Yao, Jiewen
2016-11-11 12:59 ` Laszlo Ersek
2016-11-15 2:47 ` Laszlo Ersek
2016-11-16 15:53 ` Laszlo Ersek
2016-11-16 16:14 ` Yao, Jiewen
2016-11-17 0:45 ` Fan, Jeff
2016-11-17 1:30 ` Kinney, Michael D
2016-11-17 1:36 ` Yao, Jiewen
2016-11-17 9:55 ` Laszlo Ersek
2016-11-17 12:03 ` Yao, Jiewen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C50386CF501@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox