From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 7D5EC81EE7 for ; Fri, 11 Nov 2016 15:48:21 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP; 11 Nov 2016 15:48:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,475,1473145200"; d="scan'208";a="30397840" Received: from fmsmsx108.amr.corp.intel.com ([10.18.124.206]) by orsmga005.jf.intel.com with ESMTP; 11 Nov 2016 15:48:25 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by FMSMSX108.amr.corp.intel.com (10.18.124.206) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Nov 2016 15:48:24 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 11 Nov 2016 15:48:24 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.142]) with mapi id 14.03.0248.002; Sat, 12 Nov 2016 07:48:22 +0800 From: "Yao, Jiewen" To: Pete Batard , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger Thread-Index: AQHSPDN5qWBNkmWS6kux4COS3Hty5aDUcwQA Date: Fri, 11 Nov 2016 23:48:21 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386CF903@shsmsx102.ccr.corp.intel.com> References: <22709fc2-7dec-f9eb-43f7-d06405349b7e@akeo.ie> In-Reply-To: <22709fc2-7dec-f9eb-43f7-d06405349b7e@akeo.ie> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 11 Nov 2016 23:48:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable That is great news. Thank you Pete. I have worked on this for EDK-I, but just did not have resource to do the p= orting for EDK-II. Thank you for doing this. Please give me some time, and I will review the patch soon. Thank you Yao Jiewen > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Pete Batard > Sent: Friday, November 11, 2016 11:51 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH 0/2] MdeModulePkg/EbcDxe: add EBC Debugger >=20 > The EBC Debugger [1], which was present in Tianocore [2], is an > invaluable tool for EBC development. > This patch adds it back into the EDK2, allowing, for instance, the > compilation of an AARCH64 EBC debugger. >=20 > Note 1: The patch is split in two, so that the changes to the existing > EbcDxe code are clearer. >=20 > Note 2: The diff between the original and the new sources can be found > at [3]. Most of the changes were for whitespaces/API names/compiler > warnings, with the notable exception of: > - Bumping of the EBCdebugger version to 1.0. > - Dropping of the DebuggerConfiguration protocol (which would require > introducing a new global GUID and protocol). I didn't see it as > particularly useful to caary on and would rather see if there is actual > demand for it, before adding it back. > - Add of an EFIAPI qualifier for most of the support functions, > especially the ones dealing with VPrint() ouput. This is required to > avoid garbage text output in some instances. > - Fixing of the erroneous display of 32 and 64 bit indexes in the > disassembly. > - Replacement of one assignation with CopyMem() to avoid an intrinsic > memcpy(). >=20 > Note 3: I tested the debugger built for AARCH64 and X64 using gcc on > Linux (Debian/Sid) as well as the one built for IA32 and X64 using > VS2015 on Windows. I haven't tested an IA64 version for lack of a toolcha= in. >=20 > Regards, >=20 > /Pete >=20 > [1] http://www.uefi.org/node/550 > [2] > https://github.com/tianocore/edk/tree/master/Sample/Universal/Ebc/Dxe > [3] > https://github.com/pbatard/EbcDebugger/commit/906e87ed6ceab1c361ba > 6f681bef48179baf549e > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel