public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zeng, Star" <star.zeng@intel.com>,
	"Yao, Jiewen" <jiewen.yao@intel.com>,
	 "Gao, Liming" <liming.gao@intel.com>
Subject: Re: [PATCH] MdeModulePkg DxeCore: Show error message on unaligned FvImage issue
Date: Mon, 14 Nov 2016 01:27:57 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386CFE0D@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <0C09AFA07DD0434D9E2A0C6AEB048310395B315F@shsmsx102.ccr.corp.intel.com>

Reviewed-by: jiewen.yao@intel.com

> 
> 
> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, November 11, 2016 1:59 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Gao, Liming <liming.gao@intel.com>
> Subject: [PATCH] MdeModulePkg DxeCore: Show error message on
> unaligned FvImage issue
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=205
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 9 ++++++++-
>  1 file changed, 8 insertions(+), 1 deletion(-)
> 
> diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> index f031ef110c19..bc7b34140f84 100644
> --- a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> +++ b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> @@ -4,7 +4,7 @@
>    It consumes FV HOBs and creates read-only Firmare Volume Block
> protocol
>    instances for each of them.
> 
> -Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials  are licensed and made
> available under the terms and conditions of the BSD License  which
> accompanies this distribution.  The full text of the license may be found at
> @@ -495,6 +495,13 @@ ProduceFVBProtocolOnBuffer (
>        //
>        // FvImage buffer is not at its required alignment.
>        //
> +      DEBUG ((
> +        DEBUG_ERROR,
> +        "Unaligned FvImage found at 0x%lx:0x%lx, the required
> alignment is 0x%x\n",
> +        BaseAddress,
> +        Length,
> +        FvAlignment
> +        ));
>        return EFI_VOLUME_CORRUPTED;
>      }
>    }
> --
> 2.7.0.windows.1



  parent reply	other threads:[~2016-11-14  1:27 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-11  5:58 [PATCH] MdeModulePkg DxeCore: Show error message on unaligned FvImage issue Star Zeng
     [not found] ` <0C09AFA07DD0434D9E2A0C6AEB048310395B315F@shsmsx102.ccr.corp.intel.com>
2016-11-14  1:27   ` Yao, Jiewen [this message]
2016-11-14  1:40     ` Kinney, Michael D
2016-11-14  1:43       ` Yao, Jiewen
2016-11-14  3:25         ` Zeng, Star

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C50386CFE0D@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox