Re: [PATCH] MdeModulePkg DxeCore: Show error message on unaligned FvImage issue

["Yao, Jiewen" <jiewen.yao@intel.com>]

Ah, yes. Definitely.

I think it is a good idea to catch such issue as early as possible.

Thank you
Yao Jiewen

From: Kinney, Michael D
Sent: Monday, November 14, 2016 9:41 AM
To: Yao, Jiewen <jiewen.yao@intel.com>; Zeng, Star <star.zeng@intel.com>; edk2-devel@lists.01.org; Kinney, Michael D <michael.d.kinney@intel.com>
Cc: Yao, Jiewen <jiewen.yao@intel.com>; Gao, Liming <liming.gao@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: RE: [PATCH] MdeModulePkg DxeCore: Show error message on unaligned FvImage issue

Jiewen,

Do you think it would be a good idea to add a similar DEBUG()
message in the HobLib when an FV HOBs are created?  There are
other ways FV HOBs can be created, so I think the DEBUG() message
in this patch is very important, but getting a message when
the an FV HOB is created will make fixing the issue easier.

Thanks,

Mike

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,
> Jiewen
> Sent: Sunday, November 13, 2016 5:28 PM
> To: Zeng, Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>; edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>; Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>; Zeng,
> Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>
> Subject: Re: [edk2] [PATCH] MdeModulePkg DxeCore: Show error message on unaligned
> FvImage issue
>
> Reviewed-by: jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>
>
> >
> >
> > -----Original Message-----
> > From: Zeng, Star
> > Sent: Friday, November 11, 2016 1:59 PM
> > To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> > Cc: Zeng, Star <star.zeng@intel.com<mailto:star.zeng@intel.com>>; Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>;
> > Gao, Liming <liming.gao@intel.com<mailto:liming.gao@intel.com>>
> > Subject: [PATCH] MdeModulePkg DxeCore: Show error message on
> > unaligned FvImage issue
> >
> > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=205
> >
> > Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> > Cc: Liming Gao <liming.gao@intel.com<mailto:liming.gao@intel.com>>
> > Contributed-under: TianoCore Contribution Agreement 1.0
> > Signed-off-by: Star Zeng <star.zeng@intel.com<mailto:star.zeng@intel.com>>
> > ---
> >  MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 9 ++++++++-
> >  1 file changed, 8 insertions(+), 1 deletion(-)
> >
> > diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> > b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> > index f031ef110c19..bc7b34140f84 100644
> > --- a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> > +++ b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c
> > @@ -4,7 +4,7 @@
> >    It consumes FV HOBs and creates read-only Firmare Volume Block
> > protocol
> >    instances for each of them.
> >
> > -Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.<BR>
> > +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.<BR>
> >  This program and the accompanying materials  are licensed and made
> > available under the terms and conditions of the BSD License  which
> > accompanies this distribution.  The full text of the license may be found at
> > @@ -495,6 +495,13 @@ ProduceFVBProtocolOnBuffer (
> >        //
> >        // FvImage buffer is not at its required alignment.
> >        //
> > +      DEBUG ((
> > +        DEBUG_ERROR,
> > +        "Unaligned FvImage found at 0x%lx:0x%lx, the required
> > alignment is 0x%x\n",
> > +        BaseAddress,
> > +        Length,
> > +        FvAlignment
> > +        ));
> >        return EFI_VOLUME_CORRUPTED;
> >      }
> >    }
> > --
> > 2.7.0.windows.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> https://lists.01.org/mailman/listinfo/edk2-devel