From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 28CC581DCA for ; Sun, 13 Nov 2016 17:43:21 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by fmsmga101.fm.intel.com with ESMTP; 13 Nov 2016 17:43:25 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,487,1473145200"; d="scan'208,217";a="901017132" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga003.jf.intel.com with ESMTP; 13 Nov 2016 17:43:25 -0800 Received: from fmsmsx113.amr.corp.intel.com (10.18.116.7) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 13 Nov 2016 17:43:24 -0800 Received: from shsmsx104.ccr.corp.intel.com (10.239.4.70) by FMSMSX113.amr.corp.intel.com (10.18.116.7) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 13 Nov 2016 17:43:23 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX104.ccr.corp.intel.com ([169.254.5.142]) with mapi id 14.03.0248.002; Mon, 14 Nov 2016 09:43:21 +0800 From: "Yao, Jiewen" To: "Kinney, Michael D" , "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Gao, Liming" , "Zeng, Star" Thread-Topic: [PATCH] MdeModulePkg DxeCore: Show error message on unaligned FvImage issue Thread-Index: AQHSO+C8heLQn4N7U0mi9fIrFiMt5qDXtJpwgAAAIuD//32ugIAAhokA Date: Mon, 14 Nov 2016 01:43:21 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386CFE70@shsmsx102.ccr.corp.intel.com> References: <1478843939-23164-1-git-send-email-star.zeng@intel.com> <0C09AFA07DD0434D9E2A0C6AEB048310395B315F@shsmsx102.ccr.corp.intel.com> <74D8A39837DF1E4DA445A8C0B3885C50386CFE0D@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH] MdeModulePkg DxeCore: Show error message on unaligned FvImage issue X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 01:43:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Ah, yes. Definitely. I think it is a good idea to catch such issue as early as possible. Thank you Yao Jiewen From: Kinney, Michael D Sent: Monday, November 14, 2016 9:41 AM To: Yao, Jiewen ; Zeng, Star ; e= dk2-devel@lists.01.org; Kinney, Michael D Cc: Yao, Jiewen ; Gao, Liming ;= Zeng, Star Subject: RE: [PATCH] MdeModulePkg DxeCore: Show error message on unaligned = FvImage issue Jiewen, Do you think it would be a good idea to add a similar DEBUG() message in the HobLib when an FV HOBs are created? There are other ways FV HOBs can be created, so I think the DEBUG() message in this patch is very important, but getting a message when the an FV HOB is created will make fixing the issue easier. Thanks, Mike > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Ya= o, > Jiewen > Sent: Sunday, November 13, 2016 5:28 PM > To: Zeng, Star >; edk2-de= vel@lists.01.org > Cc: Yao, Jiewen >; Gao,= Liming >; Zeng, > Star > > Subject: Re: [edk2] [PATCH] MdeModulePkg DxeCore: Show error message on u= naligned > FvImage issue > > Reviewed-by: jiewen.yao@intel.com > > > > > > > -----Original Message----- > > From: Zeng, Star > > Sent: Friday, November 11, 2016 1:59 PM > > To: edk2-devel@lists.01.org > > Cc: Zeng, Star >; Yao, = Jiewen >; > > Gao, Liming > > > Subject: [PATCH] MdeModulePkg DxeCore: Show error message on > > unaligned FvImage issue > > > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=3D205 > > > > Cc: Jiewen Yao > > > Cc: Liming Gao > > > Contributed-under: TianoCore Contribution Agreement 1.0 > > Signed-off-by: Star Zeng > > > --- > > MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c | 9 ++++++++- > > 1 file changed, 8 insertions(+), 1 deletion(-) > > > > diff --git a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c > > b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c > > index f031ef110c19..bc7b34140f84 100644 > > --- a/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c > > +++ b/MdeModulePkg/Core/Dxe/FwVolBlock/FwVolBlock.c > > @@ -4,7 +4,7 @@ > > It consumes FV HOBs and creates read-only Firmare Volume Block > > protocol > > instances for each of them. > > > > -Copyright (c) 2006 - 2014, Intel Corporation. All rights reserved.
> > +Copyright (c) 2006 - 2016, Intel Corporation. All rights reserved.
> > This program and the accompanying materials are licensed and made > > available under the terms and conditions of the BSD License which > > accompanies this distribution. The full text of the license may be fou= nd at > > @@ -495,6 +495,13 @@ ProduceFVBProtocolOnBuffer ( > > // > > // FvImage buffer is not at its required alignment. > > // > > + DEBUG (( > > + DEBUG_ERROR, > > + "Unaligned FvImage found at 0x%lx:0x%lx, the required > > alignment is 0x%x\n", > > + BaseAddress, > > + Length, > > + FvAlignment > > + )); > > return EFI_VOLUME_CORRUPTED; > > } > > } > > -- > > 2.7.0.windows.1 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel