public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: Pete Batard <pete@akeo.ie>, Laszlo Ersek <lersek@redhat.com>
Cc: "Kinney, Michael D" <michael.d.kinney@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@ml01.01.org>
Subject: Re: [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger
Date: Mon, 14 Nov 2016 13:58:40 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386D0543@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <9f4d4fac-a603-ee66-aad3-e4fcd0a57c8d@akeo.ie>

Thanks Pete.
Now I can apply this version GIT patch.
Good update, and thanks Laszlo's BKM on GIT configuration.

I like your 3-step patch. Very clear.

One minor concern I have is that: I found you include below in Protocol/Ebc.h

#define GETOPERANDS(pVM)  (UINT8) (*(UINT8 *) (pVM->Ip + 1))
#define GETOPCODE(pVM)    (UINT8) (*(UINT8 *) pVM->Ip)
#define OPERAND1_REGDATA(pvm, op) pvm->Gpr[OPERAND1_REGNUM (op)]
#define OPERAND2_REGDATA(pvm, op) pvm->Gpr[OPERAND2_REGNUM (op)]

However, pvm->Gpr and pVM->Ip are defined in Protocol/EbcVmTest.h.
I recommend that we had better move PVM related definition there.

Thank you
Yao Jiewen

From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Pete Batard
Sent: Monday, November 14, 2016 9:18 PM
To: Laszlo Ersek <lersek@redhat.com>
Cc: Kinney, Michael D <michael.d.kinney@intel.com>; edk2-devel@lists.01.org <edk2-devel@ml01.01.org>
Subject: Re: [edk2] [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger

Hi Laszlo,

Thanks for the pointers... which I probably should have read sooner -
sorry about that!

It's certainly a wild ride to get git on Windows to e-mail formatted
patches to the list, but hopefully, the new set has been posted and will
be more palatable.

Regards,

/Pete

On 2016.11.14 11:53, Laszlo Ersek wrote:
> On 11/14/16 12:51, Laszlo Ersek wrote:
>
>>   git send-email --thread --no-chain-reply-to
>
> (I apologize for tooting my own horn, but for completeness: this is
> mentioned in
> <https://github.com/tianocore/tianocore.github.io/wiki/Laszlo's-unkempt-git-guide-for-edk2-contributors-and-maintainers#contrib-05>:
>
>  git config sendemail.chainreplyto false
>  git config sendemail.thread       true
>
> )
>
> Thanks
> Laszlo
>

_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel


  reply	other threads:[~2016-11-14 13:58 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-14 11:06 [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger Pete Batard
2016-11-14 11:51 ` Laszlo Ersek
2016-11-14 11:53   ` Laszlo Ersek
2016-11-14 13:18     ` Pete Batard
2016-11-14 13:58       ` Yao, Jiewen [this message]
2016-11-14 14:11         ` Pete Batard
2016-11-14 14:39           ` Yao, Jiewen
2016-11-16  2:08             ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C50386D0543@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox