From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 23A3081E12 for ; Mon, 14 Nov 2016 05:58:42 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by orsmga101.jf.intel.com with ESMTP; 14 Nov 2016 05:58:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,638,1473145200"; d="scan'208,217";a="786213749" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by FMSMGA003.fm.intel.com with ESMTP; 14 Nov 2016 05:58:45 -0800 Received: from fmsmsx124.amr.corp.intel.com (10.18.125.39) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 14 Nov 2016 05:58:45 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx124.amr.corp.intel.com (10.18.125.39) with Microsoft SMTP Server (TLS) id 14.3.248.2; Mon, 14 Nov 2016 05:58:44 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Mon, 14 Nov 2016 21:58:41 +0800 From: "Yao, Jiewen" To: Pete Batard , Laszlo Ersek CC: "Kinney, Michael D" , "edk2-devel@lists.01.org" Thread-Topic: [edk2] [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger Thread-Index: AQHSPmd+0iW6zOo0OkKEKt/4TzVJdqDX19eAgAAAroCAABe8AIAAjwuA Date: Mon, 14 Nov 2016 13:58:40 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386D0543@shsmsx102.ccr.corp.intel.com> References: <637b6291-5132-a825-3207-dbae9b586228@redhat.com> <3fa49493-5d95-6fce-a92e-7c1c73f65a5f@redhat.com> <9f4d4fac-a603-ee66-aad3-e4fcd0a57c8d@akeo.ie> In-Reply-To: <9f4d4fac-a603-ee66-aad3-e4fcd0a57c8d@akeo.ie> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 14 Nov 2016 13:58:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Thanks Pete. Now I can apply this version GIT patch. Good update, and thanks Laszlo's BKM on GIT configuration. I like your 3-step patch. Very clear. One minor concern I have is that: I found you include below in Protocol/Ebc= .h #define GETOPERANDS(pVM) (UINT8) (*(UINT8 *) (pVM->Ip + 1)) #define GETOPCODE(pVM) (UINT8) (*(UINT8 *) pVM->Ip) #define OPERAND1_REGDATA(pvm, op) pvm->Gpr[OPERAND1_REGNUM (op)] #define OPERAND2_REGDATA(pvm, op) pvm->Gpr[OPERAND2_REGNUM (op)] However, pvm->Gpr and pVM->Ip are defined in Protocol/EbcVmTest.h. I recommend that we had better move PVM related definition there. Thank you Yao Jiewen From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Pete= Batard Sent: Monday, November 14, 2016 9:18 PM To: Laszlo Ersek Cc: Kinney, Michael D ; edk2-devel@lists.01.org= Subject: Re: [edk2] [PATCH v2 0/3] MdeModulePkg/EbcDxe: add EBC Debugger Hi Laszlo, Thanks for the pointers... which I probably should have read sooner - sorry about that! It's certainly a wild ride to get git on Windows to e-mail formatted patches to the list, but hopefully, the new set has been posted and will be more palatable. Regards, /Pete On 2016.11.14 11:53, Laszlo Ersek wrote: > On 11/14/16 12:51, Laszlo Ersek wrote: > >> git send-email --thread --no-chain-reply-to > > (I apologize for tooting my own horn, but for completeness: this is > mentioned in > : > > git config sendemail.chainreplyto false > git config sendemail.thread true > > ) > > Thanks > Laszlo > _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel