* [PATCH] SignedCapsulePkg Universal: Init local variables before using them
@ 2016-11-16 8:26 Hao Wu
2016-11-16 8:37 ` Yao, Jiewen
0 siblings, 1 reply; 2+ messages in thread
From: Hao Wu @ 2016-11-16 8:26 UTC (permalink / raw)
To: edk2-devel; +Cc: Hao Wu, Jiewen Yao
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
.../Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c | 3 +++
.../Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.c | 3 +++
.../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c | 3 +++
3 files changed, 9 insertions(+)
diff --git a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c
index 58a15e4..c8c5ba0 100644
--- a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c
+++ b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c
@@ -579,6 +579,9 @@ ProcessRecoveryImage (
VOID *AuthenticatedImage;
UINTN AuthenticatedImageSize;
+ AuthenticatedImage = NULL;
+ AuthenticatedImageSize = 0;
+
Status = CapsuleAuthenticateSystemFirmware(Image, Length, TRUE, &LastAttemptVersion, &LastAttemptStatus, &AuthenticatedImage, &AuthenticatedImageSize);
if (EFI_ERROR(Status)) {
DEBUG((DEBUG_INFO, "CapsuleAuthenticateSystemFirmware - %r\n", Status));
diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.c
index 9d5832f..f5f9827 100644
--- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.c
+++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.c
@@ -58,6 +58,9 @@ DispatchSystemFmpImages (
EFI_FIRMWARE_VOLUME_HEADER *FvImage;
BOOLEAN Result;
+ AuthenticatedImage = NULL;
+ AuthenticatedImageSize = 0;
+
DEBUG((DEBUG_INFO, "DispatchSystemFmpImages\n"));
//
diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
index ae783ff..fd6641e 100644
--- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
+++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
@@ -223,6 +223,9 @@ SystemFirmwareAuthenticatedUpdate (
VOID *AuthenticatedImage;
UINTN AuthenticatedImageSize;
+ AuthenticatedImage = NULL;
+ AuthenticatedImageSize = 0;
+
DEBUG((DEBUG_INFO, "SystemFirmwareAuthenticatedUpdate...\n"));
Status = CapsuleAuthenticateSystemFirmware(Image, ImageSize, FALSE, LastAttemptVersion, LastAttemptStatus, &AuthenticatedImage, &AuthenticatedImageSize);
--
1.9.5.msysgit.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] SignedCapsulePkg Universal: Init local variables before using them
2016-11-16 8:26 [PATCH] SignedCapsulePkg Universal: Init local variables before using them Hao Wu
@ 2016-11-16 8:37 ` Yao, Jiewen
0 siblings, 0 replies; 2+ messages in thread
From: Yao, Jiewen @ 2016-11-16 8:37 UTC (permalink / raw)
To: Wu, Hao A, edk2-devel@lists.01.org
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Wu, Hao A
> Sent: Wednesday, November 16, 2016 4:26 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH] SignedCapsulePkg Universal: Init local variables before
> using them
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
> .../Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.c
> | 3 +++
> .../Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.c
> | 3 +++
> .../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.c
> | 3 +++
> 3 files changed, 9 insertions(+)
>
> diff --git
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLo
> adPei.c
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLo
> adPei.c
> index 58a15e4..c8c5ba0 100644
> ---
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLo
> adPei.c
> +++
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLo
> adPei.c
> @@ -579,6 +579,9 @@ ProcessRecoveryImage (
> VOID *AuthenticatedImage;
> UINTN AuthenticatedImageSize;
>
> + AuthenticatedImage = NULL;
> + AuthenticatedImageSize = 0;
> +
> Status = CapsuleAuthenticateSystemFirmware(Image, Length, TRUE,
> &LastAttemptVersion, &LastAttemptStatus, &AuthenticatedImage,
> &AuthenticatedImageSize);
> if (EFI_ERROR(Status)) {
> DEBUG((DEBUG_INFO, "CapsuleAuthenticateSystemFirmware - %r\n",
> Status));
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRep
> ortDxe.c
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRep
> ortDxe.c
> index 9d5832f..f5f9827 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRep
> ortDxe.c
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareRep
> ortDxe.c
> @@ -58,6 +58,9 @@ DispatchSystemFmpImages (
> EFI_FIRMWARE_VOLUME_HEADER *FvImage;
> BOOLEAN Result;
>
> + AuthenticatedImage = NULL;
> + AuthenticatedImageSize = 0;
> +
> DEBUG((DEBUG_INFO, "DispatchSystemFmpImages\n"));
>
> //
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUp
> dateDxe.c
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUp
> dateDxe.c
> index ae783ff..fd6641e 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUp
> dateDxe.c
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUp
> dateDxe.c
> @@ -223,6 +223,9 @@ SystemFirmwareAuthenticatedUpdate (
> VOID *AuthenticatedImage;
> UINTN AuthenticatedImageSize;
>
> + AuthenticatedImage = NULL;
> + AuthenticatedImageSize = 0;
> +
> DEBUG((DEBUG_INFO, "SystemFirmwareAuthenticatedUpdate...\n"));
>
> Status = CapsuleAuthenticateSystemFirmware(Image, ImageSize, FALSE,
> LastAttemptVersion, LastAttemptStatus, &AuthenticatedImage,
> &AuthenticatedImageSize);
> --
> 1.9.5.msysgit.0
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2016-11-16 8:37 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-16 8:26 [PATCH] SignedCapsulePkg Universal: Init local variables before using them Hao Wu
2016-11-16 8:37 ` Yao, Jiewen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox