From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id D7C0E81EBA for ; Wed, 16 Nov 2016 04:20:36 -0800 (PST) Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga102.fm.intel.com with ESMTP; 16 Nov 2016 04:20:41 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,647,1473145200"; d="scan'208,217";a="787106136" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by FMSMGA003.fm.intel.com with ESMTP; 16 Nov 2016 04:20:41 -0800 Received: from fmsmsx114.amr.corp.intel.com (10.18.116.8) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 16 Nov 2016 04:20:41 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX114.amr.corp.intel.com (10.18.116.8) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 16 Nov 2016 04:20:39 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.96]) with mapi id 14.03.0248.002; Wed, 16 Nov 2016 20:20:38 +0800 From: "Yao, Jiewen" To: Pete Batard , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" Thread-Topic: [edk2] [PATCH v3 0/3] MdeModulePkg/EbcDxe: add EBC Debugger Thread-Index: AQHSP/1W5JOh0BkIRUCE4+yiXoCJlqDbhlHg Date: Wed, 16 Nov 2016 12:20:36 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386D5BA1@shsmsx102.ccr.corp.intel.com> References: <20161116113339.11472-1-pete@akeo.ie> In-Reply-To: <20161116113339.11472-1-pete@akeo.ie> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH v3 0/3] MdeModulePkg/EbcDxe: add EBC Debugger X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 16 Nov 2016 12:20:37 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable HI Pete I think this content is good. I am ready to give reviewed-by. However, I am not sure if you have notices my previous review comments seve= ral hours ago: =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D I forget to mention that: One process we need to do is to run BaseTools\Scr= ipts\PatchCheck.py to check if a patch meets check in criteria. You can find info at https://github.com/tianocore/tianocore.github.io/wiki/= Commit-Message-Format and https://github.com/tianocore/tianocore.github.io/wiki/Code-Style-C I found PatchCheck.py complain a lot for these 3 patches, especially [edk2]= -[PATCH-(RESEND)-v2-2-3]-MdeModulePkg-EbcDxe-add-EBC-Debugger.patch. :) Please run the tool and make sure zero issue reported. If you have any question, feel free to ask please. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D I run patch check tool again. It still reports below error on 0002. You may consider submitting one more patch to fix all below issues. =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D Checking patch file: C:\Users\jyao1\Desktop\0002-MdeModulePkg-EbcDxe-add-EB= C-Debugger.patch The commit message format passed all checks. Code format is not valid: * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c Line: DEBUG ((EFI_D_ERROR, "Hello EBC Debugger!\n")); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c Line: DEBUG ((EFI_D_ERROR, "Goodbye EBC Debugger!\n")); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c Line: DEBUG ((EFI_D_ERROR, "PatchSymbol RVA successfully!\n")); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DEBUG ((EFI_D_ERROR, " Symbol: %a, Address: 0x%016lx (%d)\n",= Name, (UINT64)Address, (UINTN)Type)); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DEBUG ((EFI_D_ERROR, " Symbol: %a, Address: 0x%08x (%d)\n", N= ame, Address, (UINTN)Type)); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DEBUG ((EFI_D_ERROR, "Unload Duplicated Symbol File Error!\n= ")); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DEBUG ((EFI_D_ERROR, "Symbol File: %s\n", FileName)); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DEBUG ((EFI_D_ERROR, "DebugImageInfoTableHeader: %x\n", mDebugge= rPrivate.DebugImageInfoTableHeader)); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DEBUG ((EFI_D_ERROR, "ImageBase: %x\n", ImageBase)); * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: .686P * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: .387 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _TEXT SEGMENT PARA PUBLIC USE32 'CODE' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _TEXT ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA SEGMENT PARA PUBLIC USE32 'DATA' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: ALIGN 010H * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _BSS SEGMENT PARA PUBLIC USE32 'BSS' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: ALIGN 010H * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _BSS ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _VARBSS SEGMENT PARA PUBLIC USE32 'BSS' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: ALIGN 010H * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _VARBSS ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: ASSUME CS:FLAT,DS:FLAT,SS:FLAT * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA SEGMENT PARA PUBLIC USE32 'DATA' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: TestVariable2 DD 000000003H,000000000H ; u64 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA SEGMENT PARA PUBLIC USE32 'DATA' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _TEXT SEGMENT PARA PUBLIC USE32 'CODE' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: PUBLIC EfiMain * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: EfiMain PROC NEAR * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _TEXT ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA SEGMENT PARA PUBLIC USE32 'DATA' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DB 3 DUP (0) ; pad * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: __STRING$2 DW 71 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 111 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 111 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 100 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 98 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 121 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 101 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 32 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 69 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 66 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 67 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 32 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 84 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 101 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 115 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 116 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 33 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 10 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 13 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 0 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: __STRING$1 DW 72 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 101 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 108 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 108 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 111 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 32 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 69 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 66 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 67 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 32 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 84 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 101 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 115 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 116 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 33 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 10 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 13 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 0 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA SEGMENT PARA PUBLIC USE32 'DATA' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA SEGMENT PARA PUBLIC USE32 'DATA' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: __STRING$0 DW 55 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 56 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 57 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 52 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 53 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 54 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 49 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 50 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 51 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 13 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 10 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DW 0 ; u16 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _VARBSS SEGMENT PARA PUBLIC USE32 'BSS' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: PUBLIC TestStr * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: TestStr DD 2 DUP (?) ; pad * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: PUBLIC TestVariable1 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: TestVariable1 DD 2 DUP (?) ; pad * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _VARBSS ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _VARBSS_INIT SEGMENT DWORD PUBLIC USE32 'CODE' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: PUBLIC varbss_init_C:\efi_src\TIANO\Edk\Sample\Universal\E= bc\Dxe\EbcTest\EbcTest$c45b815d2 * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: varbss_init_C:\efi_src\TIANO\Edk\Sample\Universal\Ebc\Dxe\EbcTest\= EbcTest$c45b815d2 PROC NEAR * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _VARBSS_INIT ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA SEGMENT PARA PUBLIC USE32 'DATA' * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: _DATA ENDS * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: EXTRN TestSubRoutineSub:PROC * Tab character used File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: END * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DEBUG ((EFI_D_ERROR, "Unload Duplicated Code File Error!\n= ")); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DEBUG ((EFI_D_ERROR, "Delete Duplicated Code File Error!\n= ")); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: DEBUG ((EFI_D_ERROR, " CodeSymbol: %a, FuncOffset: 0x05%x\n= ", Object->Entry[EntryIndex].Name, Object->Entry[EntryIndex].FuncOffsetBase= )); * EFI_D_ERROR was used, but DEBUG_ERROR is now recommended File: MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c Line: // DEBUG ((EFI_D_ERROR, " [CODE]:\n%a\n", Object->Entry[Entr= yIndex].CodBuffer)); * Trailing whitespace found File: MdeModulePkg/Universal/EbcDxe/EbcDebuggerExtra.uni Line: #string STR_PROPERTIES_MODULE_NAME * Trailing whitespace found File: MdeModulePkg/Universal/EbcDxe/EbcDebuggerExtra.uni Line: #language en-US =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Pete Batard > Sent: Wednesday, November 16, 2016 7:34 PM > To: edk2-devel@lists.01.org > Subject: [edk2] [PATCH v3 0/3] MdeModulePkg/EbcDxe: add EBC Debugger > > This is a slightly updated re-post of the patch series to add the EBC > Debugger. > > Changes from v2 are minimal, and take into account Jiewen's remarks about > moving some VM related macros into EbcVmTest.h, as well as one removal > of > copy/paste leftovers in the comments of EbcDebuggerExtra.uni. > > I'm hoping this version can be considered for review and integration. > > For reference, a github branch with these changes can be found at: > https://github.com/pbatard/edk2/tree/EbcDebugger_v3 > > Regards, > > /Pete > > Pete Batard (3): > MdeModulePkg/EbcDxe: prepare support for EBC Debugger > MdeModulePkg/EbcDxe: add EBC Debugger > MdeModulePkg/EbcDxe: reorganize EBC header definitions > > MdeModulePkg/Include/Protocol/EbcVmTest.h | 49 + > MdeModulePkg/MdeModulePkg.dsc | 3 +- > MdeModulePkg/Universal/EbcDxe/AArch64/EbcSupport.c | 3 + > MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf | 120 + > MdeModulePkg/Universal/EbcDxe/EbcDebugger.uni | 19 + > MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c | 659 +++++ > MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.h | 58 + > .../Universal/EbcDxe/EbcDebugger/EdbCmdBranch.c | 336 +++ > .../Universal/EbcDxe/EbcDebugger/EdbCmdBreak.c | 327 +++ > .../EbcDxe/EbcDebugger/EdbCmdBreakpoint.c | 614 +++++ > .../Universal/EbcDxe/EbcDebugger/EdbCmdExtIo.c | 219 ++ > .../Universal/EbcDxe/EbcDebugger/EdbCmdExtPci.c | 186 ++ > .../Universal/EbcDxe/EbcDebugger/EdbCmdGo.c | 93 + > .../Universal/EbcDxe/EbcDebugger/EdbCmdHelp.c | 86 + > .../Universal/EbcDxe/EbcDebugger/EdbCmdMemory.c | 683 +++++ > .../Universal/EbcDxe/EbcDebugger/EdbCmdQuit.c | 50 + > .../Universal/EbcDxe/EbcDebugger/EdbCmdRegister.c | 136 + > .../Universal/EbcDxe/EbcDebugger/EdbCmdScope.c | 123 + > .../Universal/EbcDxe/EbcDebugger/EdbCmdStep.c | 198 ++ > .../Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 952 +++++++ > .../Universal/EbcDxe/EbcDebugger/EdbCommand.c | 680 +++++ > .../Universal/EbcDxe/EbcDebugger/EdbCommand.h | 106 + > .../Universal/EbcDxe/EbcDebugger/EdbCommon.h | 251 ++ > .../Universal/EbcDxe/EbcDebugger/EdbDisasm.c | 1907 > ++++++++++++++ > .../Universal/EbcDxe/EbcDebugger/EdbDisasm.h | 42 + > .../EbcDxe/EbcDebugger/EdbDisasmSupport.c | 1461 > +++++++++++ > .../EbcDxe/EbcDebugger/EdbDisasmSupport.h | 241 ++ > .../Universal/EbcDxe/EbcDebugger/EdbHook.c | 1003 ++++++++ > .../Universal/EbcDxe/EbcDebugger/EdbHook.h | 27 + > .../Universal/EbcDxe/EbcDebugger/EdbSupport.h | 240 ++ > .../Universal/EbcDxe/EbcDebugger/EdbSupportFile.c | 415 +++ > .../EbcDxe/EbcDebugger/EdbSupportString.c | 991 ++++++++ > .../Universal/EbcDxe/EbcDebugger/EdbSupportUI.c | 708 ++++++ > .../Universal/EbcDxe/EbcDebugger/EdbSymbol.c | 2669 > ++++++++++++++++++++ > .../Universal/EbcDxe/EbcDebugger/EdbSymbol.h | 128 + > MdeModulePkg/Universal/EbcDxe/EbcDebuggerExtra.uni | 17 + > MdeModulePkg/Universal/EbcDxe/EbcDebuggerHook.c | 156 ++ > MdeModulePkg/Universal/EbcDxe/EbcDebuggerHook.h | 136 + > MdeModulePkg/Universal/EbcDxe/EbcDxe.inf | 4 +- > MdeModulePkg/Universal/EbcDxe/EbcExecute.c | 39 + > MdeModulePkg/Universal/EbcDxe/EbcExecute.h | 198 -- > MdeModulePkg/Universal/EbcDxe/EbcInt.c | 6 + > MdeModulePkg/Universal/EbcDxe/EbcInt.h | 29 - > MdeModulePkg/Universal/EbcDxe/Ia32/EbcSupport.c | 7 +- > MdeModulePkg/Universal/EbcDxe/Ipf/EbcSupport.c | 9 +- > MdeModulePkg/Universal/EbcDxe/X64/EbcSupport.c | 7 +- > MdePkg/Include/Protocol/Ebc.h | 161 ++ > 47 files changed, 16317 insertions(+), 235 deletions(-) > create mode 100644 MdeModulePkg/Universal/EbcDxe/EbcDebugger.inf > create mode 100644 MdeModulePkg/Universal/EbcDxe/EbcDebugger.uni > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.h > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdBranch.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdBreak.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdBreakpoint.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdExtIo.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdExtPci.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdGo.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdHelp.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdMemory.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdQuit.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdRegister.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdScope.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdStep.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommand.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommand.h > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCommon.h > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasm.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasm.h > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbDisasmSupport.h > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.h > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupport.h > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportFile.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportString.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSupportUI.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.h > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebuggerExtra.uni > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebuggerHook.c > create mode 100644 > MdeModulePkg/Universal/EbcDxe/EbcDebuggerHook.h > > -- > 2.9.3.windows.2 > > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel