public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [PATCH] SecurityPkg Tcg2Pei: Add comments into LogHashEvent()
Date: Fri, 18 Nov 2016 05:47:04 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386D7324@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1479447774-63284-1-git-send-email-star.zeng@intel.com>

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, November 18, 2016 1:43 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH] SecurityPkg Tcg2Pei: Add comments into LogHashEvent()
> 
> Add comments into LogHashEvent() to describe the usage
> of GetDigestListSize (DigestList).
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c | 4 ++++
>  1 file changed, 4 insertions(+)
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> index 377f8d9fe45b..209d843245e4 100644
> --- a/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> +++ b/SecurityPkg/Tcg/Tcg2Pei/Tcg2Pei.c
> @@ -317,6 +317,10 @@ LogHashEvent (
>          }
>          break;
>        case EFI_TCG2_EVENT_LOG_FORMAT_TCG_2:
> +        //
> +        // Use GetDigestListSize (DigestList) in the GUID HOB DataLength
> calculation
> +        // to reserve enough buffer to hold TPML_DIGEST_VALUES
> compact binary.
> +        //
>          HobData = BuildGuidHob (
>                     &gTcgEvent2EntryHobGuid,
>                     sizeof(TcgPcrEvent2->PCRIndex) +
> sizeof(TcgPcrEvent2->EventType) + GetDigestListSize (DigestList) +
> sizeof(TcgPcrEvent2->EventSize) + NewEventHdr->EventSize
> --
> 2.7.0.windows.1



      reply	other threads:[~2016-11-18  5:47 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-18  5:42 [PATCH] SecurityPkg Tcg2Pei: Add comments into LogHashEvent() Star Zeng
2016-11-18  5:47 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C50386D7324@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox