public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Wu, Hao A" <hao.a.wu@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Wu, Hao A" <hao.a.wu@intel.com>,
	"Tian, Feng" <feng.tian@intel.com>,
	"Dong, Eric" <eric.dong@intel.com>
Subject: Re: [PATCH] SecurityPkg TcgStorageCoreLib: ASSERT to ensure 'ByteSeq' is not NULL
Date: Mon, 21 Nov 2016 07:57:35 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386D8139@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1479714734-8604-1-git-send-email-hao.a.wu@intel.com>

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Hao Wu
> Sent: Monday, November 21, 2016 3:52 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Tian, Feng <feng.tian@intel.com>;
> Dong, Eric <eric.dong@intel.com>
> Subject: [edk2] [PATCH] SecurityPkg TcgStorageCoreLib: ASSERT to ensure
> 'ByteSeq' is not NULL
> 
> Add ASSERT to make sure 'ByteSeq' is not NULL before comsumed by
> CopyMem().
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Feng Tian <feng.tian@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> index e333b55..76b25a3 100644
> --- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> +++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> @@ -1435,6 +1435,8 @@ TcgGetNextTcgUid(
>      return TcgResultFailure;
>    }
> 
> +  ASSERT (ByteSeq != NULL);
> +
>    CopyMem(Uid, ByteSeq, sizeof(TCG_UID));
> 
>    return TcgResultSuccess;
> --
> 1.9.5.msysgit.0
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel


      reply	other threads:[~2016-11-21  7:57 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-21  7:52 [PATCH] SecurityPkg TcgStorageCoreLib: ASSERT to ensure 'ByteSeq' is not NULL Hao Wu
2016-11-21  7:57 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C50386D8139@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox