[PATCH] SecurityPkg TcgStorageCoreLib: ASSERT to ensure 'ByteSeq' is not NULL

[PATCH] SecurityPkg TcgStorageCoreLib: ASSERT to ensure 'ByteSeq' is not NULL

[Hao Wu]

Add ASSERT to make sure 'ByteSeq' is not NULL before comsumed by
CopyMem().

Cc: Eric Dong <eric.dong@intel.com>
Cc: Feng Tian <feng.tian@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Hao Wu <hao.a.wu@intel.com>
---
 SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
index e333b55..76b25a3 100644
--- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
+++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
@@ -1435,6 +1435,8 @@ TcgGetNextTcgUid(
     return TcgResultFailure;
   }
 
+  ASSERT (ByteSeq != NULL);
+
   CopyMem(Uid, ByteSeq, sizeof(TCG_UID));
 
   return TcgResultSuccess;
-- 
1.9.5.msysgit.0

Re: [PATCH] SecurityPkg TcgStorageCoreLib: ASSERT to ensure 'ByteSeq' is not NULL

[Yao, Jiewen]

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Hao Wu
> Sent: Monday, November 21, 2016 3:52 PM
> To: edk2-devel@lists.01.org
> Cc: Wu, Hao A <hao.a.wu@intel.com>; Tian, Feng <feng.tian@intel.com>;
> Dong, Eric <eric.dong@intel.com>
> Subject: [edk2] [PATCH] SecurityPkg TcgStorageCoreLib: ASSERT to ensure
> 'ByteSeq' is not NULL
> 
> Add ASSERT to make sure 'ByteSeq' is not NULL before comsumed by
> CopyMem().
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Feng Tian <feng.tian@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Hao Wu <hao.a.wu@intel.com>
> ---
>  SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> index e333b55..76b25a3 100644
> --- a/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> +++ b/SecurityPkg/Library/TcgStorageCoreLib/TcgStorageCore.c
> @@ -1435,6 +1435,8 @@ TcgGetNextTcgUid(
>      return TcgResultFailure;
>    }
> 
> +  ASSERT (ByteSeq != NULL);
> +
>    CopyMem(Uid, ByteSeq, sizeof(TCG_UID));
> 
>    return TcgResultSuccess;
> --
> 1.9.5.msysgit.0
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel