From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga11.intel.com (mga11.intel.com [192.55.52.93]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 6DD1881ED7 for ; Wed, 23 Nov 2016 19:12:11 -0800 (PST) Received: from fmsmga006.fm.intel.com ([10.253.24.20]) by fmsmga102.fm.intel.com with ESMTP; 23 Nov 2016 19:12:11 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,689,1473145200"; d="scan'208";a="35065909" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga006.fm.intel.com with ESMTP; 23 Nov 2016 19:12:11 -0800 Received: from fmsmsx151.amr.corp.intel.com (10.18.125.4) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 23 Nov 2016 19:12:10 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by FMSMSX151.amr.corp.intel.com (10.18.125.4) with Microsoft SMTP Server (TLS) id 14.3.248.2; Wed, 23 Nov 2016 19:12:10 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.239]) with mapi id 14.03.0248.002; Thu, 24 Nov 2016 11:12:08 +0800 From: "Yao, Jiewen" To: "Wu, Hao A" , "edk2-devel@lists.01.org" Thread-Topic: [PATCH 0/5] Code refinements in MdeModulePkg/EbcDebugger Thread-Index: AQHSRf5nrJ1KQjBkbkeDOPyRiKA/IKDndQyQ Date: Thu, 24 Nov 2016 03:12:07 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386D9FFA@shsmsx102.ccr.corp.intel.com> References: <1479956195-10764-1-git-send-email-hao.a.wu@intel.com> In-Reply-To: <1479956195-10764-1-git-send-email-hao.a.wu@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [PATCH 0/5] Code refinements in MdeModulePkg/EbcDebugger X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 03:12:11 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable All reviewed-by: Jiewen.yao@intel.com > -----Original Message----- > From: Wu, Hao A > Sent: Thursday, November 24, 2016 10:57 AM > To: edk2-devel@lists.01.org > Cc: Wu, Hao A ; Yao, Jiewen > Subject: [PATCH 0/5] Code refinements in MdeModulePkg/EbcDebugger >=20 > Cc: Jiewen Yao >=20 > Hao Wu (5): > MdeModulePkg/EbcDebugger: Operands of same size for bitwise > operation > MdeModulePkg/EbcDebugger: Add check for invalid 'CommandArg' > MdeModulePkg/EbcDebugger: Add missing check for symbol not found > MdeModulePkg/EbcDebugger: Add ASSERT to ensure FieldBuffer is not > NULL > MdeModulePkg/EbcDebugger: Compare ASCII char with '\0' >=20 > MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c | 6 > +++--- > .../Universal/EbcDxe/EbcDebugger/EdbCmdBreakpoint.c | 14 > +++++++++++++- > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 4 > ++-- > .../Universal/EbcDxe/EbcDebugger/EdbSupportString.c | 4 ++-- > MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbSymbol.c | 3 > ++- > 5 files changed, 22 insertions(+), 9 deletions(-) >=20 > -- > 1.9.5.msysgit.0