Re: [PATCH 3/3] SecurityPkg Tcg2ConfigDxe: Remove BlockSID actions and related strings

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Zeng, Star
> Sent: Thursday, November 24, 2016 5:14 PM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>; Dong, Eric <eric.dong@intel.com>
> Subject: [PATCH 3/3] SecurityPkg Tcg2ConfigDxe: Remove BlockSID actions
> and related strings
> 
> Tcg2ConfigDxe has no related code to handle BlockSID related actions
> that have been covered by OpalPasswordDxe driver.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Cc: Eric Dong <eric.dong@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr        | 3 ---
>  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni | 3 ---
>  2 files changed, 6 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr
> b/SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr
> index a72f8246d100..48e99430f396 100644
> --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr
> +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2Config.vfr
> @@ -109,9 +109,6 @@ formset
>              option text = STRING_TOKEN(STR_TCG2_CHANGE_EPS),
> value = TCG2_PHYSICAL_PRESENCE_CHANGE_EPS, flags =
> RESET_REQUIRED;
>              option text = STRING_TOKEN(STR_TCG2_LOG_ALL_DIGESTS),
> value = TCG2_PHYSICAL_PRESENCE_LOG_ALL_DIGESTS, flags =
> RESET_REQUIRED;
>              option text =
> STRING_TOKEN(STR_TCG2_DISABLE_ENDORSEMENT_ENABLE_STORAGE_HI
> ERARCHY), value =
> TCG2_PHYSICAL_PRESENCE_DISABLE_ENDORSEMENT_ENABLE_STORAGE_
> HIERARCHY, flags = RESET_REQUIRED;
> -
> -            option text =
> STRING_TOKEN(STR_TCG2_ENABLE_BLOCK_SID), value =
> TCG2_PHYSICAL_PRESENCE_ENABLE_BLOCK_SID, flags = RESET_REQUIRED;
> -            option text =
> STRING_TOKEN(STR_TCG2_DISABLE_BLOCK_SID), value =
> TCG2_PHYSICAL_PRESENCE_DISABLE_BLOCK_SID, flags =
> RESET_REQUIRED;
>      endoneof;
> 
>      suppressif NOT questionref(Tpm2Operation) ==
> TCG2_PHYSICAL_PRESENCE_SET_PCR_BANKS;
> diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni
> b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni
> index 49cd4430ce88..948179d336bd 100644
> --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni
> +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni
> @@ -58,9 +58,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF
> ANY KIND, EITHER EXPRESS OR IMPLIED.
>  #string STR_TCG2_OPERATION_PARAMETER       #language en-US
> "TPM2 Operation Parameter"
>  #string STR_TCG2_OPERATION_PARAMETER_HELP  #language en-US
> "Additional TPM2 Operation Parameter need be sent with Operation Code
> (required for SetPCRBanks)"
> 
> -#string STR_TCG2_ENABLE_BLOCK_SID             #language en-US
> "TCG2 Storage Enable Block SID"
> -#string STR_TCG2_DISABLE_BLOCK_SID            #language en-US
> "TCG2 Storage Disable Block SID"
> -
>  #string STR_TCG2_TPM_DISABLE               #language en-US
> "Disable"
>  #string STR_TCG2_TPM_1_2                   #language en-US "TPM
> 1.2"
>  #string STR_TCG2_TPM_2_0_DTPM              #language en-US
> "TPM 2.0"
> --
> 2.7.0.windows.1