Re: [PATCH v2 1/1] MdeModulePkg/EbcDxe: add EBC Debugger configuration application

["Yao, Jiewen" <jiewen.yao@intel.com>]

SHELL_STATUS is for SHELL command. They are different.
This APPLICATION is still a normal UEFI application. So we should return EFI_STATUS.

I think we need change all SHELL_STATUS to EFI_STATUS.

Thank you
Yao Jiewen


From: Pete Batard [mailto:pete@akeo.ie]
Sent: Friday, November 25, 2016 12:12 AM
To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
Subject: Re: [PATCH v2 1/1] MdeModulePkg/EbcDxe: add EBC Debugger configuration application

On 2016.11.24 15:55, Yao, Jiewen wrote:
> I suddenly realize you added AppPkg/AppPkg.dec, too. That is another dependency violation.

You're right, I forgot to remove that dependency.

> I do not see any need to add this AppPkg.dec. Can you try to remove this from INF?

Just confirmed that it isn't needed.

However, while testing this, I found an issue when building X64, which I
guess has to do with trying to return SHELL_STATUS instead of EFI_STATUS
for InitializeEbcDebuggerConfig().

This didn't matter for v1, and I only tested v2 with IA32, so I didn't
spot it earlier. But I guess EFI_STATUS and SHELL_STATUS don't have the
same size on X64 (and likely AARCH64), so I have to ask:

Should the shell application return SHELL_STATUS or EFI_STATUS?

I was under the impression that, because the Shell error codes are
expected to be positive, SHELL_STATUS is preferred over EFI_STATUS.
But then, I am not sure what is the right way to set an application
entrypoint for an X64 app that returns SHELL_STATUS...

Once we agree on the return type, I can submit a new updated patch.

Regards,

/Pete