From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id B000081EA0 for ; Thu, 24 Nov 2016 08:35:42 -0800 (PST) Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga101.fm.intel.com with ESMTP; 24 Nov 2016 08:35:42 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,543,1473145200"; d="scan'208,217";a="1063765539" Received: from fmsmsx104.amr.corp.intel.com ([10.18.124.202]) by orsmga001.jf.intel.com with ESMTP; 24 Nov 2016 08:35:41 -0800 Received: from shsmsx101.ccr.corp.intel.com (10.239.4.153) by fmsmsx104.amr.corp.intel.com (10.18.124.202) with Microsoft SMTP Server (TLS) id 14.3.248.2; Thu, 24 Nov 2016 08:35:41 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX101.ccr.corp.intel.com ([169.254.1.239]) with mapi id 14.03.0248.002; Fri, 25 Nov 2016 00:35:39 +0800 From: "Yao, Jiewen" To: Pete Batard , "edk2-devel@lists.01.org" CC: "Yao, Jiewen" Thread-Topic: [PATCH v2 1/1] MdeModulePkg/EbcDxe: add EBC Debugger configuration application Thread-Index: AQHSRmnu1rU//QdsdEmBjxZ8vkHR8aDoR+rw//+AMQCAAIx0cA== Date: Thu, 24 Nov 2016 16:35:38 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386DA6E5@shsmsx102.ccr.corp.intel.com> References: <20161124154601.8024-1-pete@akeo.ie> <20161124154601.8024-2-pete@akeo.ie> <74D8A39837DF1E4DA445A8C0B3885C50386DA63E@shsmsx102.ccr.corp.intel.com> In-Reply-To: Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH v2 1/1] MdeModulePkg/EbcDxe: add EBC Debugger configuration application X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 24 Nov 2016 16:35:42 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable SHELL_STATUS is for SHELL command. They are different. This APPLICATION is still a normal UEFI application. So we should return EF= I_STATUS. I think we need change all SHELL_STATUS to EFI_STATUS. Thank you Yao Jiewen From: Pete Batard [mailto:pete@akeo.ie] Sent: Friday, November 25, 2016 12:12 AM To: Yao, Jiewen ; edk2-devel@lists.01.org Subject: Re: [PATCH v2 1/1] MdeModulePkg/EbcDxe: add EBC Debugger configura= tion application On 2016.11.24 15:55, Yao, Jiewen wrote: > I suddenly realize you added AppPkg/AppPkg.dec, too. That is another depe= ndency violation. You're right, I forgot to remove that dependency. > I do not see any need to add this AppPkg.dec. Can you try to remove this = from INF? Just confirmed that it isn't needed. However, while testing this, I found an issue when building X64, which I guess has to do with trying to return SHELL_STATUS instead of EFI_STATUS for InitializeEbcDebuggerConfig(). This didn't matter for v1, and I only tested v2 with IA32, so I didn't spot it earlier. But I guess EFI_STATUS and SHELL_STATUS don't have the same size on X64 (and likely AARCH64), so I have to ask: Should the shell application return SHELL_STATUS or EFI_STATUS? I was under the impression that, because the Shell error codes are expected to be positive, SHELL_STATUS is preferred over EFI_STATUS. But then, I am not sure what is the right way to set an application entrypoint for an X64 app that returns SHELL_STATUS... Once we agree on the return type, I can submit a new updated patch. Regards, /Pete