public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [PATCH] SecurityPkg Tcg2ConfigDxe: Align Attempt TPM Device help with options
Date: Fri, 25 Nov 2016 02:50:25 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386DAA3E@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1480041605-103840-1-git-send-email-star.zeng@intel.com>

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Zeng, Star
> Sent: Friday, November 25, 2016 10:40 AM
> To: edk2-devel@lists.01.org
> Cc: Zeng, Star <star.zeng@intel.com>; Yao, Jiewen <jiewen.yao@intel.com>;
> Zhang, Chao B <chao.b.zhang@intel.com>
> Subject: [PATCH] SecurityPkg Tcg2ConfigDxe: Align Attempt TPM Device help
> with options
> 
> Current options only have TPM 1.2 and TPM 2.0,
> but help shows Disable, TPM1.2, or TPM2.0,
> they are mismatched.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Star Zeng <star.zeng@intel.com>
> ---
>  SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni | 5 ++---
>  1 file changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni
> b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni
> index 948179d336bd..f55efb471f64 100644
> --- a/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni
> +++ b/SecurityPkg/Tcg/Tcg2Config/Tcg2ConfigStrings.uni
> @@ -1,5 +1,5 @@
>  /** @file
> -  String definitions for TCG configuration form.
> +  String definitions for TCG2 configuration form.
> 
>  Copyright (c) 2015 - 2016, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
> @@ -22,7 +22,7 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF
> ANY KIND, EITHER EXPRESS OR IMPLIED.
>  #string STR_TCG2_DEVICE_STATE_CONTENT       #language en-US ""
> 
>  #string STR_TCG2_DEVICE_PROMPT              #language en-US
> "Attempt TPM Device"
> -#string STR_TCG2_DEVICE_HELP                #language en-US
> "Attempt TPM Device: Disable, TPM1.2, or TPM2.0"
> +#string STR_TCG2_DEVICE_HELP                #language en-US
> "Attempt TPM Device: TPM1.2, or TPM2.0"
>  #string STR_TCG2_DEVICE_CONTENT             #language en-US ""
> 
>  #string STR_TCG2_DEVICE_INTERFACE_STATE_PROMPT
> #language en-US "Current TPM Device Interface"
> @@ -58,7 +58,6 @@ WITHOUT WARRANTIES OR REPRESENTATIONS OF
> ANY KIND, EITHER EXPRESS OR IMPLIED.
>  #string STR_TCG2_OPERATION_PARAMETER       #language en-US
> "TPM2 Operation Parameter"
>  #string STR_TCG2_OPERATION_PARAMETER_HELP  #language en-US
> "Additional TPM2 Operation Parameter need be sent with Operation Code
> (required for SetPCRBanks)"
> 
> -#string STR_TCG2_TPM_DISABLE               #language en-US
> "Disable"
>  #string STR_TCG2_TPM_1_2                   #language en-US "TPM
> 1.2"
>  #string STR_TCG2_TPM_2_0_DTPM              #language en-US
> "TPM 2.0"
> 
> --
> 2.7.0.windows.1



      reply	other threads:[~2016-11-25  2:50 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-25  2:40 [PATCH] SecurityPkg Tcg2ConfigDxe: Align Attempt TPM Device help with options Star Zeng
2016-11-25  2:50 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C50386DAA3E@shsmsx102.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox