From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga06.intel.com (mga06.intel.com [134.134.136.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id AC4B081CC3 for ; Tue, 29 Nov 2016 17:47:46 -0800 (PST) Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga104.jf.intel.com with ESMTP; 29 Nov 2016 17:47:46 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.31,719,1473145200"; d="scan'208";a="37029441" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga005.jf.intel.com with ESMTP; 29 Nov 2016 17:47:46 -0800 Received: from fmsmsx102.amr.corp.intel.com (10.18.124.200) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 29 Nov 2016 17:47:45 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by FMSMSX102.amr.corp.intel.com (10.18.124.200) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 29 Nov 2016 17:47:45 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.96]) with mapi id 14.03.0248.002; Wed, 30 Nov 2016 09:47:42 +0800 From: "Yao, Jiewen" To: "Kinney, Michael D" , "edk2-devel@lists.01.org" CC: "Wei, David" , "Guo, Mang" Thread-Topic: [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections Thread-Index: AQHSSnXoOSo77610F0Gb5ap52vTaZKDwu2FA Date: Wed, 30 Nov 2016 01:47:42 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386DC7B2@shsmsx102.ccr.corp.intel.com> References: <1480447327-13908-1-git-send-email-michael.d.kinney@intel.com> In-Reply-To: <1480447327-13908-1-git-send-email-michael.d.kinney@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 30 Nov 2016 01:47:46 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable HI Mike I agree on this change. But I would like to mention that the protection does not takes effect, unti= l all VLV2 binary uses this build option, too. We should feedback to VLV2 binary provider as well. Reviewed-by: Jiewen.yao@intel.com Thank you Yao Jiewen > -----Original Message----- > From: Kinney, Michael D > Sent: Wednesday, November 30, 2016 3:22 AM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Wei, David > ; Guo, Mang > Subject: [Patch] Vlv2TbltDevicePkg: Use 4K aligned PE/COFF sections >=20 > Update [BuildOptions] to use of 4K aligned PE/COFF > image sections to support page level protection of > DXE_RUNTIME_DRIVER, SMM_CORE, and DXE_SMM_DRIVER > modules. >=20 > Cc: Jiewen Yao > Cc: David Wei > Cc: Mang Guo > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Michael Kinney > --- > Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc | 16 ++++++++++++++++ > Vlv2TbltDevicePkg/PlatformPkgIA32.dsc | 16 ++++++++++++++++ > Vlv2TbltDevicePkg/PlatformPkgX64.dsc | 16 ++++++++++++++++ > 3 files changed, 48 insertions(+) >=20 > diff --git a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > index c3dc25f..6da2a8a 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgGccX64.dsc > @@ -1676,6 +1676,22 @@ > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fT > PMInitPeim.inf > INTEL:*_*_X64_GENFW_FLAGS =3D --keepexceptiontable > !endif >=20 > +# > +# Force PE/COFF sections to be aligned at 4KB boundaries to support page > level > +# protection of DXE_RUNTIME_DRIVER modules > +# > +[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > + > +# > +# Force PE/COFF sections to be aligned at 4KB boundaries to support page > level > +# protection of DXE_SMM_DRIVER/SMM_CORE modules > +# > +[BuildOptions.common.EDKII.DXE_SMM_DRIVER, > BuildOptions.common.EDKII.SMM_CORE] > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > + > [BuildOptions.Common.EDK] >=20 > # > diff --git a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > index 3a5776a..5b5523f 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgIA32.dsc > @@ -1659,6 +1659,22 @@ > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fT > PMInitPeim.inf >=20 > !endif >=20 > +# > +# Force PE/COFF sections to be aligned at 4KB boundaries to support page > level > +# protection of DXE_RUNTIME_DRIVER modules > +# > +[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > + > +# > +# Force PE/COFF sections to be aligned at 4KB boundaries to support page > level > +# protection of DXE_SMM_DRIVER/SMM_CORE modules > +# > +[BuildOptions.common.EDKII.DXE_SMM_DRIVER, > BuildOptions.common.EDKII.SMM_CORE] > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > + > [BuildOptions.Common.EDK] >=20 > # > diff --git a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > index 83cbb0a..54d2b81 100644 > --- a/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > +++ b/Vlv2TbltDevicePkg/PlatformPkgX64.dsc > @@ -1668,6 +1668,22 @@ > $(PLATFORM_BINARY_PACKAGE)/$(DXE_ARCHITECTURE)$(TARGET)/IA32/fT > PMInitPeim.inf >=20 > !endif >=20 > +# > +# Force PE/COFF sections to be aligned at 4KB boundaries to support page > level > +# protection of DXE_RUNTIME_DRIVER modules > +# > +[BuildOptions.common.EDKII.DXE_RUNTIME_DRIVER] > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > + > +# > +# Force PE/COFF sections to be aligned at 4KB boundaries to support page > level > +# protection of DXE_SMM_DRIVER/SMM_CORE modules > +# > +[BuildOptions.common.EDKII.DXE_SMM_DRIVER, > BuildOptions.common.EDKII.SMM_CORE] > + MSFT:*_*_*_DLINK_FLAGS =3D /ALIGN:4096 > + GCC:*_*_*_DLINK_FLAGS =3D -z common-page-size=3D0x1000 > + > [BuildOptions.Common.EDK] >=20 > # > -- > 2.6.3.windows.1