From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id A32D981F5F for ; Fri, 2 Dec 2016 15:56:56 -0800 (PST) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP; 02 Dec 2016 15:56:56 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,289,1477983600"; d="scan'208,217";a="908179055" Received: from fmsmsx105.amr.corp.intel.com ([10.18.124.203]) by orsmga003.jf.intel.com with ESMTP; 02 Dec 2016 15:56:55 -0800 Received: from fmsmsx117.amr.corp.intel.com (10.18.116.17) by FMSMSX105.amr.corp.intel.com (10.18.124.203) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 2 Dec 2016 15:56:55 -0800 Received: from shsmsx151.ccr.corp.intel.com (10.239.6.50) by fmsmsx117.amr.corp.intel.com (10.18.116.17) with Microsoft SMTP Server (TLS) id 14.3.248.2; Fri, 2 Dec 2016 15:56:55 -0800 Received: from shsmsx102.ccr.corp.intel.com ([169.254.2.239]) by SHSMSX151.ccr.corp.intel.com ([169.254.3.116]) with mapi id 14.03.0248.002; Sat, 3 Dec 2016 07:56:51 +0800 From: "Yao, Jiewen" To: Laszlo Ersek , "Zeng, Star" , edk2-devel-01 CC: "Kinney, Michael D" , "Tian, Feng" , "Gao, Liming" , "Wei, David" Thread-Topic: [edk2] [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL Thread-Index: AQHSS/w6dCVPVuVyn0uKYkMl5urvKaDz4t4w//+vfACAAFGcAIABcr5Q Date: Fri, 2 Dec 2016 23:56:51 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386DFC5F@shsmsx102.ccr.corp.intel.com> References: <20161201175556.2479-1-lersek@redhat.com> <74D8A39837DF1E4DA445A8C0B3885C50386DF380@shsmsx102.ccr.corp.intel.com> <315be37c-ddd0-1ddf-0953-bacf0624d67f@intel.com> <2fd9e769-1456-3892-41b3-5f4c1d1d360a@redhat.com> In-Reply-To: <2fd9e769-1456-3892-41b3-5f4c1d1d360a@redhat.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64-bit LoopTimes in S3 MEM_POLL X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 02 Dec 2016 23:56:56 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable HI Laszlo Would you please give me some time, so that I could discuss internal team t= o see if there is any concern on this API update? The estimation will be 1 work week at most. Usually adding a new API does not need compatibility check, but updating an= existing API always need. Thank you Yao Jiewen From: Laszlo Ersek [mailto:lersek@redhat.com] Sent: Friday, December 2, 2016 5:47 PM To: Zeng, Star ; Yao, Jiewen ; e= dk2-devel-01 Cc: Kinney, Michael D ; Tian, Feng ; Gao, Liming ; Wei, David Subject: Re: [edk2] [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: 64= -bit LoopTimes in S3 MEM_POLL On 12/02/16 05:54, Zeng, Star wrote: > On 2016/12/2 9:53, Yao, Jiewen wrote: >> HI Laszlo >> Thank you to raise this long time existing issue. :-) >> >> There is historic reason that we inherit this undocumented API from >> EDK-I to EDKII. >> >> I do not object your update. Thanks! >> I am thinking if it is time to create a new API which can match PI >> specification, and suggest all consumers use the new API. >> >> RETURN_STATUS >> EFIAPI >> S3BootScriptSavePiMemPoll ( >> IN S3_BOOT_SCRIPT_LIB_WIDTH Width, >> IN UINT64 Address, >> IN VOID *Data, >> IN VOID *DataMask, >> IN UINT64 Delay, >> ); > > If the new API is introduced, the old one could be marked as deprecated > by DISABLE_NEW_DEPRECATED_INTERFACES. That's cool, but until then, can we please accept these patches? :) Thanks! Laszlo > Thanks, > Star > >> >> Thank you >> Yao Jiewen >> >> >>> -----Original Message----- >>> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of >>> Laszlo Ersek >>> Sent: Friday, December 2, 2016 1:56 AM >>> To: edk2-devel-01 > >>> Cc: Tian, Feng >; Gao, = Liming >>> >; >>> Kinney, Michael D >; Zeng, Star >>> >; Wei, David > >>> Subject: [edk2] [PATCH 0/3] MdePkg, MdeModulePkg, Vlv2TbltDevicePkg: >>> 64-bit LoopTimes in S3 MEM_POLL >>> >>> While working on S3 boot script related stuff in OVMF, I wanted to see >>> if infinite blocking was possible in the various POLL opcodes. While >>> edk2's implementation of IO_POLL, PCI_CONFIG_POLL and >>> PCI_CONFIG2_POLL >>> follows the PI spec vol5 closely, even internally (using 100ns delay >>> units), the MEM_POLL internals differ -- they are microseconds based. >>> >>> That's not a problem per se (it's just a different internal opcode >>> representation, which is fine); the problem is that the current >>> internals don't conform to the spec: in 32-bit builds, the UINT64 numbe= r >>> of 100ns units that the caller intends to wait for is silently >>> truncated, for no good reason. This issue is not hard to fix (we can >>> even keep the microseconds-based internals), so let's fix it. >>> >>> Repo: https://github.com/lersek/edk2/ >>> Branch: mempoll_looptimes_64bit >>> >>> Cc: David Wei > >>> Cc: Feng Tian > >>> Cc: Liming Gao > >>> Cc: Mang Guo > >>> Cc: Michael D Kinney > >>> Cc: Star Zeng > >>> >>> Thanks >>> Laszlo >>> >>> Laszlo Ersek (3): >>> MdePkg, MdeModulePkg: S3BootScriptSaveMemPoll(): accept 64-bit >>> LoopTimes >>> MdeModulePkg: S3SaveStateDxe, SmmS3SaveState: save 64-bit >>> LoopTimes >>> Vlv2TbltDevicePkg/BootScriptSaveDxe: save 64-bit LoopTimes >>> >>> MdeModulePkg/Library/PiDxeS3BootScriptLib/BootScriptSave.c | 2 +- >>> MdeModulePkg/Universal/Acpi/S3SaveStateDxe/S3SaveState.c | 8 >>> ++++---- >>> MdeModulePkg/Universal/Acpi/SmmS3SaveState/SmmS3SaveState.c | 8 >>> ++++---- >>> MdePkg/Include/Library/S3BootScriptLib.h | 2 +- >>> MdePkg/Library/BaseS3BootScriptLibNull/BootScriptLib.c | 2 +- >>> Vlv2TbltDevicePkg/BootScriptSaveDxe/ScriptSave.c | 4 ++-- >>> 6 files changed, 13 insertions(+), 13 deletions(-) >>> >>> -- >>> 2.9.2 >>> >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel >