From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch 0/5] MdeModulePkg/EbcDxe: Fix coding style issues
Date: Mon, 5 Dec 2016 12:45:30 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C50386E038F@shsmsx102.ccr.corp.intel.com> (raw)
In-Reply-To: <1480915641-59136-1-git-send-email-dandan.bi@intel.com>
Reviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Monday, December 5, 2016 1:27 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Pete Batard <pete@akeo.ie>
> Subject: [patch 0/5] MdeModulePkg/EbcDxe: Fix coding style issues
>
> These patch series make the coding style of EbcDxe follow
> the EDKII coding rules.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Pete Batard <pete@akeo.ie>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
>
>
> Dandan Bi (5):
> MdeModulePkg/EbcDxe: Make the comments align with EDKII coding
> style
> MdeModulePkg/EbcDxe: Initialize variable after declaration
> MdeModulePkg/EbcDxe: Make the variable name follow rules
> MdeModulePkg/EbcDxe: Avoid Non-Boolean type used as Boolean
> MdeModulePkg/EbcDxe: Add comments for functions
>
> .../EbcDxe/EbcDebugger/EbcDebuggerConfig.c | 21 +
> MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.c | 223 ++---
> MdeModulePkg/Universal/EbcDxe/EbcDebugger/Edb.h | 34 +-
> .../Universal/EbcDxe/EbcDebugger/EdbCmdBranch.c | 98 +-
> .../Universal/EbcDxe/EbcDebugger/EdbCmdBreak.c | 199 ++--
> .../EbcDxe/EbcDebugger/EdbCmdBreakpoint.c | 327 +++---
> .../Universal/EbcDxe/EbcDebugger/EdbCmdExtIo.c | 195 ++--
> .../Universal/EbcDxe/EbcDebugger/EdbCmdExtPci.c | 161 ++-
> .../Universal/EbcDxe/EbcDebugger/EdbCmdGo.c | 43 +-
> .../Universal/EbcDxe/EbcDebugger/EdbCmdHelp.c | 40 +-
> .../Universal/EbcDxe/EbcDebugger/EdbCmdMemory.c | 427 +++-----
> .../Universal/EbcDxe/EbcDebugger/EdbCmdQuit.c | 38 +-
> .../Universal/EbcDxe/EbcDebugger/EdbCmdRegister.c | 40 +-
> .../Universal/EbcDxe/EbcDebugger/EdbCmdScope.c | 70 +-
> .../Universal/EbcDxe/EbcDebugger/EdbCmdStep.c | 152 ++-
> .../Universal/EbcDxe/EbcDebugger/EdbCmdSymbol.c | 374 +++----
> .../Universal/EbcDxe/EbcDebugger/EdbCommand.c | 68 +-
> .../Universal/EbcDxe/EbcDebugger/EdbCommand.h | 35 +-
> .../Universal/EbcDxe/EbcDebugger/EdbCommon.h | 15 +-
> .../Universal/EbcDxe/EbcDebugger/EdbDisasm.c | 733
> ++++++--------
> .../Universal/EbcDxe/EbcDebugger/EdbDisasm.h | 14 +-
> .../EbcDxe/EbcDebugger/EdbDisasmSupport.c | 950
> +++++++-----------
> .../EbcDxe/EbcDebugger/EdbDisasmSupport.h | 352 ++++++-
> .../Universal/EbcDxe/EbcDebugger/EdbHook.c | 566
> ++++-------
> .../Universal/EbcDxe/EbcDebugger/EdbHook.h | 15 +-
> .../Universal/EbcDxe/EbcDebugger/EdbSupport.h | 279 +++++-
> .../Universal/EbcDxe/EbcDebugger/EdbSupportFile.c | 115 +--
> .../EbcDxe/EbcDebugger/EdbSupportString.c | 650
> ++++++------
> .../Universal/EbcDxe/EbcDebugger/EdbSupportUI.c | 168 ++--
> .../Universal/EbcDxe/EbcDebugger/EdbSymbol.c | 1050
> ++++++--------------
> .../Universal/EbcDxe/EbcDebugger/EdbSymbol.h | 142 ++-
> MdeModulePkg/Universal/EbcDxe/EbcDebuggerHook.c | 117 +++
> MdeModulePkg/Universal/EbcDxe/EbcDebuggerHook.h | 129 ++-
> MdeModulePkg/Universal/EbcDxe/EbcExecute.c | 4 +-
> 34 files changed, 3665 insertions(+), 4179 deletions(-)
>
> --
> 1.9.5.msysgit.1
prev parent reply other threads:[~2016-12-05 12:45 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 5:27 [patch 0/5] MdeModulePkg/EbcDxe: Fix coding style issues Dandan Bi
2016-12-05 5:27 ` [patch 1/5] MdeModulePkg/EbcDxe: Make the comments align with EDKII coding style Dandan Bi
2016-12-05 5:27 ` [patch 2/5] MdeModulePkg/EbcDxe: Initialize variable after declaration Dandan Bi
2016-12-05 5:27 ` [patch 3/5] MdeModulePkg/EbcDxe: Make the variable name follow rules Dandan Bi
2016-12-05 5:27 ` [patch 4/5] MdeModulePkg/EbcDxe: Avoid Non-Boolean type used as Boolean Dandan Bi
2016-12-05 5:27 ` [patch 5/5] MdeModulePkg/EbcDxe: Add comments for functions Dandan Bi
2016-12-05 12:45 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C50386E038F@shsmsx102.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox