From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Zeng, Star" <star.zeng@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Cc: "Zhang, Chao B" <chao.b.zhang@intel.com>
Subject: Re: [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation
Date: Mon, 12 Dec 2016 06:55:03 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8BAA6E@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <59526493-8ec1-43f4-02e8-5db845f6223a@intel.com>
Yes, I agree.
From: Zeng, Star
Sent: Monday, December 12, 2016 2:54 PM
To: Yao, Jiewen <jiewen.yao@intel.com>; edk2-devel@lists.01.org
Cc: Zhang, Chao B <chao.b.zhang@intel.com>; Zeng, Star <star.zeng@intel.com>
Subject: Re: [edk2] [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation
Jiewen,
Minor comments added inline below.
On 2016/12/12 14:35, Jiewen Yao wrote:
> Tcg2Dxe allocates event log below 4G. It is unnecessary.
>
> Cc: Chao Zhang <chao.b.zhang@intel.com<mailto:chao.b.zhang@intel.com>>
> Cc: Star Zeng <star.zeng@intel.com<mailto:star.zeng@intel.com>>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> ---
> SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> index 9e8dfae..ca28301 100644
> --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c
> @@ -1396,7 +1396,7 @@ SetupEventLog (
> mTcgDxeData.EventLogAreaStruct[Index].EventLogFormat = mTcg2EventInfo[Index].LogFormat;
> Lasa = (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1);
How about also removing this line to reduce confusion?
> Status = gBS->AllocatePages (
> - AllocateMaxAddress,
> + AllocateAnyPages,
> EfiBootServicesData,
> EFI_SIZE_TO_PAGES (PcdGet32 (PcdTcgLogAreaMinLen)),
> &Lasa
> @@ -1498,7 +1498,7 @@ SetupEventLog (
> if (mTcg2EventInfo[Index].LogFormat == EFI_TCG2_EVENT_LOG_FORMAT_TCG_2) {
> Lasa = (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1);
Same comment with above.
Thanks,
Star
> Status = gBS->AllocatePages (
> - AllocateMaxAddress,
> + AllocateAnyPages,
> EfiACPIMemoryNVS,
> EFI_SIZE_TO_PAGES (PcdGet32 (PcdTcg2FinalLogAreaLen)),
> &Lasa
>
next prev parent reply other threads:[~2016-12-12 6:55 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-12 6:35 [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation Jiewen Yao
2016-12-12 6:53 ` Zeng, Star
2016-12-12 6:55 ` Yao, Jiewen [this message]
2016-12-12 6:56 ` Zeng, Star
-- strict thread matches above, loose matches on Subject: below --
2016-12-12 7:02 Jiewen Yao
2016-12-13 1:16 ` Zhang, Chao B
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A8BAA6E@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox