From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga04.intel.com (mga04.intel.com [192.55.52.120]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 407C7820DF for ; Sun, 11 Dec 2016 22:55:07 -0800 (PST) Received: from fmsmga004.fm.intel.com ([10.253.24.48]) by fmsmga104.fm.intel.com with ESMTP; 11 Dec 2016 22:55:06 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,334,1477983600"; d="scan'208,217";a="201530796" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga004.fm.intel.com with ESMTP; 11 Dec 2016 22:55:06 -0800 Received: from fmsmsx111.amr.corp.intel.com (10.18.116.5) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 11 Dec 2016 22:55:06 -0800 Received: from shsmsx102.ccr.corp.intel.com (10.239.4.154) by fmsmsx111.amr.corp.intel.com (10.18.116.5) with Microsoft SMTP Server (TLS) id 14.3.248.2; Sun, 11 Dec 2016 22:55:05 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.9]) by shsmsx102.ccr.corp.intel.com ([169.254.2.54]) with mapi id 14.03.0248.002; Mon, 12 Dec 2016 14:55:03 +0800 From: "Yao, Jiewen" To: "Zeng, Star" , "edk2-devel@lists.01.org" CC: "Zhang, Chao B" Thread-Topic: [edk2] [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation Thread-Index: AQHSVEH+d+YrGKEQ5UuFjtEiBQ3v0KEDWlGAgACGduA= Date: Mon, 12 Dec 2016 06:55:03 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8BAA6E@SHSMSX104.ccr.corp.intel.com> References: <1481524542-3492-1-git-send-email-jiewen.yao@intel.com> <59526493-8ec1-43f4-02e8-5db845f6223a@intel.com> In-Reply-To: <59526493-8ec1-43f4-02e8-5db845f6223a@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 12 Dec 2016 06:55:07 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Yes, I agree. From: Zeng, Star Sent: Monday, December 12, 2016 2:54 PM To: Yao, Jiewen ; edk2-devel@lists.01.org Cc: Zhang, Chao B ; Zeng, Star Subject: Re: [edk2] [PATCH] SecurityPkg:/Tcg2Dxe: remove 4G limitation Jiewen, Minor comments added inline below. On 2016/12/12 14:35, Jiewen Yao wrote: > Tcg2Dxe allocates event log below 4G. It is unnecessary. > > Cc: Chao Zhang > > Cc: Star Zeng > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Jiewen Yao > > --- > SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c b/SecurityPkg/Tcg/Tcg2Dxe/= Tcg2Dxe.c > index 9e8dfae..ca28301 100644 > --- a/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > +++ b/SecurityPkg/Tcg/Tcg2Dxe/Tcg2Dxe.c > @@ -1396,7 +1396,7 @@ SetupEventLog ( > mTcgDxeData.EventLogAreaStruct[Index].EventLogFormat =3D mTcg2Even= tInfo[Index].LogFormat; > Lasa =3D (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1); How about also removing this line to reduce confusion? > Status =3D gBS->AllocatePages ( > - AllocateMaxAddress, > + AllocateAnyPages, > EfiBootServicesData, > EFI_SIZE_TO_PAGES (PcdGet32 (PcdTcgLogAreaMinLen))= , > &Lasa > @@ -1498,7 +1498,7 @@ SetupEventLog ( > if (mTcg2EventInfo[Index].LogFormat =3D=3D EFI_TCG2_EVENT_LOG_FORM= AT_TCG_2) { > Lasa =3D (EFI_PHYSICAL_ADDRESS) (SIZE_4GB - 1); Same comment with above. Thanks, Star > Status =3D gBS->AllocatePages ( > - AllocateMaxAddress, > + AllocateAnyPages, > EfiACPIMemoryNVS, > EFI_SIZE_TO_PAGES (PcdGet32 (PcdTcg2FinalLogArea= Len)), > &Lasa >