From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id C6E028216D for ; Tue, 13 Dec 2016 00:46:58 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP; 13 Dec 2016 00:46:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,340,1477983600"; d="scan'208";a="41912491" Received: from fmsmsx106.amr.corp.intel.com ([10.18.124.204]) by fmsmga005.fm.intel.com with ESMTP; 13 Dec 2016 00:46:58 -0800 Received: from fmsmsx157.amr.corp.intel.com (10.18.116.73) by FMSMSX106.amr.corp.intel.com (10.18.124.204) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 13 Dec 2016 00:46:58 -0800 Received: from shsmsx103.ccr.corp.intel.com (10.239.4.69) by FMSMSX157.amr.corp.intel.com (10.18.116.73) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 13 Dec 2016 00:46:57 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.9]) by SHSMSX103.ccr.corp.intel.com ([169.254.4.11]) with mapi id 14.03.0248.002; Tue, 13 Dec 2016 16:46:56 +0800 From: "Yao, Jiewen" To: "Bi, Dandan" , "edk2-devel@lists.01.org" CC: "Fan, Jeff" Thread-Topic: [edk2] [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file Thread-Index: AQHSVR0QSTURQSG2Ck66nwL9vFZtuqEFkKpw Date: Tue, 13 Dec 2016 08:46:55 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8BC4A3@SHSMSX104.ccr.corp.intel.com> References: <1481618428-101904-1-git-send-email-dandan.bi@intel.com> <1481618428-101904-15-git-send-email-dandan.bi@intel.com> In-Reply-To: <1481618428-101904-15-git-send-email-dandan.bi@intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 Subject: Re: [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 13 Dec 2016 08:46:58 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable Reviewed-by: jiewen.yao@intel.com > -----Original Message----- > From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of > Dandan Bi > Sent: Tuesday, December 13, 2016 4:40 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen ; Fan, Jeff > Subject: [edk2] [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding s= tyle > issues in INF file >=20 > 1. Add MicrocodeUpdate.h to the [Sources] section. > 2. Fix the incorrect Guid/Protocol format issues. >=20 > Cc: Jiewen Yao > Cc: Jeff Fan > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi > --- > UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf > | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) >=20 > diff --git > a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in > f > b/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in > f > index 437d300..7aae348 100644 > --- > a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in > f > +++ > b/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in > f > @@ -28,10 +28,11 @@ [Defines] > # > # VALID_ARCHITECTURES =3D X64 > # >=20 > [Sources] > + MicrocodeUpdate.h > MicrocodeFmp.c > MicrocodeUpdate.c >=20 > [Packages] > MdePkg/MdePkg.dec > @@ -49,14 +50,14 @@ [LibraryClasses] > UefiRuntimeServicesTableLib > UefiDriverEntryPoint > MicrocodeFlashAccessLib >=20 > [Guids] > - gMicrocodeFmpImageTypeIdGuid > + gMicrocodeFmpImageTypeIdGuid ## CONSUMES ## > GUID >=20 > [Protocols] > - gEfiFirmwareManagementProtocolGuid ## > SOMTIMES_PRODUCE > + gEfiFirmwareManagementProtocolGuid ## PRODUCES >=20 > [Pcd] > gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress > ## CONSUMES > gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize > ## CONSUMES >=20 > -- > 1.9.5.msysgit.1 >=20 > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel