public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style issues in INF file
Date: Tue, 13 Dec 2016 08:49:55 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8BC50F@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1481618428-101904-9-git-send-email-dandan.bi@intel.com>

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style
> issues in INF file
> 
> Fix incorrect Guid/Pcd format issues in INF file.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  .../EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf    | 18
> +++++++++---------
>  1 file changed, 9 insertions(+), 9 deletions(-)
> 
> diff --git
> a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> index 3c629ee..a7c9607 100644
> ---
> a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> +++
> b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> @@ -45,17 +45,17 @@ [LibraryClasses]
>    DebugLib
>    MemoryAllocationLib
>    FmpAuthenticationLib
> 
>  [Pcd]
> -
> gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor
> -  gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareFileGuid
> -  gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer
> -  gEfiSecurityPkgTokenSpaceGuid.PcdPkcs7CertBuffer
> +
> gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor
> ## CONSUMES
> +  gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareFileGuid
> ## CONSUMES
> +  gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer
> ## CONSUMES
> +  gEfiSecurityPkgTokenSpaceGuid.PcdPkcs7CertBuffer
> ## CONSUMES
> 
>  [Guids]
> -  gEdkiiSystemFirmwareImageDescriptorFileGuid
> -  gEdkiiSystemFmpCapsuleConfigFileGuid
> -  gEdkiiSystemFmpCapsuleDriverFvFileGuid
> -  gEfiCertPkcs7Guid
> -  gEfiCertTypeRsa2048Sha256Guid
> +  gEdkiiSystemFirmwareImageDescriptorFileGuid          ## CONSUMES
> ## GUID
> +  gEdkiiSystemFmpCapsuleConfigFileGuid                 ## CONSUMES
> ## GUID
> +  gEdkiiSystemFmpCapsuleDriverFvFileGuid               ## CONSUMES
> ## GUID
> +  gEfiCertPkcs7Guid                                    ## CONSUMES
> ## GUID
> +  gEfiCertTypeRsa2048Sha256Guid                        ## CONSUMES
> ## GUID
> 
> --
> 1.9.5.msysgit.1



  reply	other threads:[~2016-12-13  8:50 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-13  8:40 [patch 00/18] Fix coding style issues Dandan Bi
2016-12-13  8:40 ` [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: " Dandan Bi
2016-12-13 16:16   ` Carsey, Jaben
2016-12-13  8:40 ` [patch 02/18] ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format Dandan Bi
2016-12-13 16:16   ` Carsey, Jaben
2016-12-13  8:40 ` [patch 03/18] ShellPkg/UefiShellNetwork2CommandsLib: " Dandan Bi
2016-12-13 16:16   ` Carsey, Jaben
2016-12-13  8:40 ` [patch 04/18] Security:Add info string to UNI file for PcdPkcs7CertBuffer Dandan Bi
     [not found]   ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DCA@SHSMSX103.ccr.corp.intel.com>
2016-12-14  2:45     ` Yao, Jiewen
2016-12-13  8:40 ` [patch 05/18] SecurityPkg/FmpAuthenticationLibPkcs7: Fix incorrect Guid format Dandan Bi
2016-12-13  8:50   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 06/18] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Fix Guid/pcd format issues Dandan Bi
2016-12-13  8:50   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function Dandan Bi
2016-12-14  5:18   ` Dong, Eric
2016-12-13  8:40 ` [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style issues in INF file Dandan Bi
2016-12-13  8:49   ` Yao, Jiewen [this message]
2016-12-13  8:40 ` [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source file to " Dandan Bi
2016-12-13  8:49   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: " Dandan Bi
2016-12-13  8:48   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name Dandan Bi
2016-12-13  8:49   ` Yao, Jiewen
2016-12-14  2:36     ` Yao, Jiewen
2016-12-13  8:40 ` [patch 12/18] UefiCpuPkg: Make the comments align with the functions Dandan Bi
2016-12-14  2:50   ` Fan, Jeff
2016-12-13  8:40 ` [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable Dandan Bi
     [not found]   ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DE3@SHSMSX103.ccr.corp.intel.com>
2016-12-14  2:41     ` Yao, Jiewen
2016-12-14  2:51   ` Fan, Jeff
2016-12-13  8:40 ` [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file Dandan Bi
2016-12-13  8:46   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues Dandan Bi
2016-12-13  8:47   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 16/18] MdeModulePkg: Make the comments align with the function Dandan Bi
2016-12-13  8:46   ` Yao, Jiewen
2016-12-13  8:40 ` [patch 17/18] MdeModulePkg: Add missing info string for PCDs Dandan Bi
     [not found]   ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DD7@SHSMSX103.ccr.corp.intel.com>
2016-12-14  2:42     ` Yao, Jiewen
2016-12-13  8:40 ` [patch 18/18] MdeModulePkg/CapsuleApp: Fix GUID/protocol format issues Dandan Bi
2016-12-13  8:46   ` Yao, Jiewen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A8BC50F@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox