Re: [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name

["Yao, Jiewen" <jiewen.yao@intel.com>]

I checked code again.

May we can we use a better name, such as INI_COMMENT_LINE or INI_SECTION_ITEM?

Thank you

From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao, Jiewen
Sent: Tuesday, December 13, 2016 4:50 PM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org
Subject: Re: [edk2] [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name

This seems odd.

This is a C file. No one should include 2 files at same time.

I suggest we keep it as is.

Thank you
Yao Jiewen




> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> Subject: [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
>
> 1. Change _SECTION_ITEM to _SECTION_ITEMS
> 2. Change _COMMENT_LINE to _COMMENT_LINES
> Because _SECTION_ITEM  and _COMMENT_LINE are duplicated with
> the one defined in IntelFrameworkModulePkg\Universal\
> FirmwareVolume\UpdateDriverDxe\UpdateDriver.h
>
> Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com<mailto:dandan.bi@intel.com>>
> ---
>  SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 8 ++++----
>  1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> index 5c975f7..cce9f6a 100644
> --- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> +++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> @@ -48,21 +48,21 @@
>  #define IS_NULL(a)                 ((a) == '\0')
>
>  // This is default allocation. Reallocation will happen if it is not enough.
>  #define MAX_LINE_LENGTH           512
>
> -typedef struct _SECTION_ITEM SECTION_ITEM;
> -struct _SECTION_ITEM {
> +typedef struct _SECTION_ITEMS SECTION_ITEM;
> +struct _SECTION_ITEMS {
>    CHAR8                           *PtrSection;
>    UINTN                           SecNameLen;
>    CHAR8                           *PtrEntry;
>    CHAR8                           *PtrValue;
>    SECTION_ITEM                    *PtrNext;
>  };
>
> -typedef struct _COMMENT_LINE COMMENT_LINE;
> -struct _COMMENT_LINE {
> +typedef struct _COMMENT_LINES COMMENT_LINE;
> +struct _COMMENT_LINES {
>    CHAR8                           *PtrComment;
>    COMMENT_LINE                    *PtrNext;
>  };
>
>  typedef struct {
> --
> 1.9.5.msysgit.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel