From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 8D9A5821DE for ; Tue, 13 Dec 2016 18:36:21 -0800 (PST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga105.jf.intel.com with ESMTP; 13 Dec 2016 18:36:20 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.33,344,1477983600"; d="scan'208,217";a="42252666" Received: from fmsmsx103.amr.corp.intel.com ([10.18.124.201]) by fmsmga005.fm.intel.com with ESMTP; 13 Dec 2016 18:36:20 -0800 Received: from shsmsx152.ccr.corp.intel.com (10.239.6.52) by FMSMSX103.amr.corp.intel.com (10.18.124.201) with Microsoft SMTP Server (TLS) id 14.3.248.2; Tue, 13 Dec 2016 18:36:20 -0800 Received: from shsmsx104.ccr.corp.intel.com ([169.254.5.9]) by SHSMSX152.ccr.corp.intel.com ([169.254.6.235]) with mapi id 14.03.0248.002; Wed, 14 Dec 2016 10:36:18 +0800 From: "Yao, Jiewen" To: "Yao, Jiewen" , "Bi, Dandan" , "edk2-devel@lists.01.org" Thread-Topic: [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name Thread-Index: AQHSVR0At2LgfX+/MUiScjtqkcCcnaEFkOeggAEqUvA= Date: Wed, 14 Dec 2016 02:36:17 +0000 Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8BCC5E@SHSMSX104.ccr.corp.intel.com> References: <1481618428-101904-1-git-send-email-dandan.bi@intel.com> <1481618428-101904-12-git-send-email-dandan.bi@intel.com> <74D8A39837DF1E4DA445A8C0B3885C503A8BC4EF@SHSMSX104.ccr.corp.intel.com> In-Reply-To: <74D8A39837DF1E4DA445A8C0B3885C503A8BC4EF@SHSMSX104.ccr.corp.intel.com> Accept-Language: zh-CN, en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.239.127.40] MIME-Version: 1.0 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 Subject: Re: [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Dec 2016 02:36:21 -0000 Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable I checked code again. May we can we use a better name, such as INI_COMMENT_LINE or INI_SECTION_IT= EM? Thank you From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao,= Jiewen Sent: Tuesday, December 13, 2016 4:50 PM To: Bi, Dandan ; edk2-devel@lists.01.org Subject: Re: [edk2] [patch 11/18] SignedCapsulePkg/IniParsingLib: Update st= ruct name This seems odd. This is a C file. No one should include 2 files at same time. I suggest we keep it as is. Thank you Yao Jiewen > -----Original Message----- > From: Bi, Dandan > Sent: Tuesday, December 13, 2016 4:40 PM > To: edk2-devel@lists.01.org > Cc: Yao, Jiewen > > Subject: [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name > > 1. Change _SECTION_ITEM to _SECTION_ITEMS > 2. Change _COMMENT_LINE to _COMMENT_LINES > Because _SECTION_ITEM and _COMMENT_LINE are duplicated with > the one defined in IntelFrameworkModulePkg\Universal\ > FirmwareVolume\UpdateDriverDxe\UpdateDriver.h > > Cc: Jiewen Yao > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Dandan Bi = > > --- > SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c > b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c > index 5c975f7..cce9f6a 100644 > --- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c > +++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c > @@ -48,21 +48,21 @@ > #define IS_NULL(a) ((a) =3D=3D '\0') > > // This is default allocation. Reallocation will happen if it is not eno= ugh. > #define MAX_LINE_LENGTH 512 > > -typedef struct _SECTION_ITEM SECTION_ITEM; > -struct _SECTION_ITEM { > +typedef struct _SECTION_ITEMS SECTION_ITEM; > +struct _SECTION_ITEMS { > CHAR8 *PtrSection; > UINTN SecNameLen; > CHAR8 *PtrEntry; > CHAR8 *PtrValue; > SECTION_ITEM *PtrNext; > }; > > -typedef struct _COMMENT_LINE COMMENT_LINE; > -struct _COMMENT_LINE { > +typedef struct _COMMENT_LINES COMMENT_LINE; > +struct _COMMENT_LINES { > CHAR8 *PtrComment; > COMMENT_LINE *PtrNext; > }; > > typedef struct { > -- > 1.9.5.msysgit.1 _______________________________________________ edk2-devel mailing list edk2-devel@lists.01.org https://lists.01.org/mailman/listinfo/edk2-devel