* [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: Fix coding style issues
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 16:16 ` Carsey, Jaben
2016-12-13 8:40 ` [patch 02/18] ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format Dandan Bi
` (16 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Ruiyu Ni
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
index 7133881..bb2c0b9 100644
--- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
+++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
@@ -82,12 +82,12 @@ GetAttrType (
}
/**
Convert binary to hex format string.
- @param[in] BufferSize The size in bytes of the binary data.
@param[in] Buffer The binary data.
+ @param[in] BufferSize The size in bytes of the binary data.
@param[in, out] HexString Hex format string.
@param[in] HexStringSize The size in bytes of the string.
@return The hex format string.
**/
@@ -421,10 +421,11 @@ CascadeProcessVariables (
UINT32 Atts;
SHELL_STATUS ShellStatus;
UINTN NameSize;
CHAR16 *AttrString;
CHAR16 *HexString;
+ EFI_STATUS SetStatus;
if (ShellGetExecutionBreakFlag()) {
return (SHELL_ABORTED);
}
@@ -546,11 +547,11 @@ CascadeProcessVariables (
}
} else if (Type == DmpStoreDelete) {
//
// We only need name to delete it...
//
- EFI_STATUS SetStatus = gRT->SetVariable (FoundVarName, &FoundVarGuid, Atts, 0, NULL);
+ SetStatus = gRT->SetVariable (FoundVarName, &FoundVarGuid, Atts, 0, NULL);
if (StandardFormatOutput) {
if (SetStatus == EFI_SUCCESS) {
ShellPrintHiiEx (
-1, -1, NULL, STRING_TOKEN (STR_DMPSTORE_NO_VAR_FOUND_NG_SFO), gShellDebug1HiiHandle,
FoundVarName, &FoundVarGuid
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: Fix coding style issues
2016-12-13 8:40 ` [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: " Dandan Bi
@ 2016-12-13 16:16 ` Carsey, Jaben
0 siblings, 0 replies; 39+ messages in thread
From: Carsey, Jaben @ 2016-12-13 16:16 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Carsey, Jaben
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 12:40 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>
> Subject: [edk2] [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: Fix
> coding style issues
> Importance: High
>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> index 7133881..bb2c0b9 100644
> --- a/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> +++ b/ShellPkg/Library/UefiShellDebug1CommandsLib/DmpStore.c
> @@ -82,12 +82,12 @@ GetAttrType (
> }
>
> /**
> Convert binary to hex format string.
>
> - @param[in] BufferSize The size in bytes of the binary data.
> @param[in] Buffer The binary data.
> + @param[in] BufferSize The size in bytes of the binary data.
> @param[in, out] HexString Hex format string.
> @param[in] HexStringSize The size in bytes of the string.
>
> @return The hex format string.
> **/
> @@ -421,10 +421,11 @@ CascadeProcessVariables (
> UINT32 Atts;
> SHELL_STATUS ShellStatus;
> UINTN NameSize;
> CHAR16 *AttrString;
> CHAR16 *HexString;
> + EFI_STATUS SetStatus;
>
> if (ShellGetExecutionBreakFlag()) {
> return (SHELL_ABORTED);
> }
>
> @@ -546,11 +547,11 @@ CascadeProcessVariables (
> }
> } else if (Type == DmpStoreDelete) {
> //
> // We only need name to delete it...
> //
> - EFI_STATUS SetStatus = gRT->SetVariable (FoundVarName,
> &FoundVarGuid, Atts, 0, NULL);
> + SetStatus = gRT->SetVariable (FoundVarName, &FoundVarGuid, Atts, 0,
> NULL);
> if (StandardFormatOutput) {
> if (SetStatus == EFI_SUCCESS) {
> ShellPrintHiiEx (
> -1, -1, NULL, STRING_TOKEN
> (STR_DMPSTORE_NO_VAR_FOUND_NG_SFO), gShellDebug1HiiHandle,
> FoundVarName, &FoundVarGuid
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 02/18] ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
2016-12-13 8:40 ` [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: " Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 16:16 ` Carsey, Jaben
2016-12-13 8:40 ` [patch 03/18] ShellPkg/UefiShellNetwork2CommandsLib: " Dandan Bi
` (15 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Fu Siyuan, Ruiyu Ni
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
index 25b2e14..ffa6778 100644
--- a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
+++ b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
@@ -53,11 +53,11 @@ [LibraryClasses]
[Pcd]
gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUMES
[Protocols]
gEfiCpuArchProtocolGuid ## CONSUMES
- gEfiTimerArchProtocolGuid
+ gEfiTimerArchProtocolGuid ## CONSUMES
gEfiIp6ProtocolGuid ## SOMETIMES_CONSUMES
gEfiIp6ServiceBindingProtocolGuid ## SOMETIMES_CONSUMES
gEfiIp6ConfigProtocolGuid ## SOMETIMES_CONSUMES
gEfiIp4ProtocolGuid ## SOMETIMES_CONSUMES
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 02/18] ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format
2016-12-13 8:40 ` [patch 02/18] ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format Dandan Bi
@ 2016-12-13 16:16 ` Carsey, Jaben
0 siblings, 0 replies; 39+ messages in thread
From: Carsey, Jaben @ 2016-12-13 16:16 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Fu, Siyuan, Carsey, Jaben
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 12:40 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [edk2] [patch 02/18] ShellPkg/UefiShellNetwork1CommandsLib: Fix
> incorrect Protocol format
> Importance: High
>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../UefiShellNetwork1CommandsLib/UefiShellNetwork1CommandsLib.inf
> | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.inf
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.inf
> index 25b2e14..ffa6778 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.inf
> +++
> b/ShellPkg/Library/UefiShellNetwork1CommandsLib/UefiShellNetwork1Com
> mandsLib.inf
> @@ -53,11 +53,11 @@ [LibraryClasses]
> [Pcd]
> gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUMES
>
> [Protocols]
> gEfiCpuArchProtocolGuid ## CONSUMES
> - gEfiTimerArchProtocolGuid
> + gEfiTimerArchProtocolGuid ## CONSUMES
> gEfiIp6ProtocolGuid ## SOMETIMES_CONSUMES
> gEfiIp6ServiceBindingProtocolGuid ## SOMETIMES_CONSUMES
> gEfiIp6ConfigProtocolGuid ## SOMETIMES_CONSUMES
>
> gEfiIp4ProtocolGuid ## SOMETIMES_CONSUMES
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 03/18] ShellPkg/UefiShellNetwork2CommandsLib: Fix incorrect Protocol format
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
2016-12-13 8:40 ` [patch 01/18] ShellPkg/UefiShellDebug1CommandsLib: " Dandan Bi
2016-12-13 8:40 ` [patch 02/18] ShellPkg/UefiShellNetwork1CommandsLib: Fix incorrect Protocol format Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 16:16 ` Carsey, Jaben
2016-12-13 8:40 ` [patch 04/18] Security:Add info string to UNI file for PcdPkcs7CertBuffer Dandan Bi
` (14 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Fu Siyuan, Ruiyu Ni
Cc: Fu Siyuan <siyuan.fu@intel.com>
Cc: Ruiyu Ni <ruiyu.ni@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
index 8f253d2..3502d2a 100644
--- a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
+++ b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
@@ -53,11 +53,11 @@ [LibraryClasses]
[Pcd]
gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUMES
[Protocols]
gEfiCpuArchProtocolGuid ## CONSUMES
- gEfiTimerArchProtocolGuid
+ gEfiTimerArchProtocolGuid ## CONSUMES
gEfiIp6ProtocolGuid ## SOMETIMES_CONSUMES
gEfiIp6ServiceBindingProtocolGuid ## SOMETIMES_CONSUMES
gEfiIp6ConfigProtocolGuid ## SOMETIMES_CONSUMES
[Guids]
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 03/18] ShellPkg/UefiShellNetwork2CommandsLib: Fix incorrect Protocol format
2016-12-13 8:40 ` [patch 03/18] ShellPkg/UefiShellNetwork2CommandsLib: " Dandan Bi
@ 2016-12-13 16:16 ` Carsey, Jaben
0 siblings, 0 replies; 39+ messages in thread
From: Carsey, Jaben @ 2016-12-13 16:16 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Ni, Ruiyu, Fu, Siyuan, Carsey, Jaben
Reviewed-by: Jaben Carsey <jaben.carsey@intel.com>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 12:40 AM
> To: edk2-devel@lists.01.org
> Cc: Ni, Ruiyu <ruiyu.ni@intel.com>; Fu, Siyuan <siyuan.fu@intel.com>
> Subject: [edk2] [patch 03/18] ShellPkg/UefiShellNetwork2CommandsLib: Fix
> incorrect Protocol format
> Importance: High
>
> Cc: Fu Siyuan <siyuan.fu@intel.com>
> Cc: Ruiyu Ni <ruiyu.ni@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../UefiShellNetwork2CommandsLib/UefiShellNetwork2CommandsLib.inf
> | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.inf
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.inf
> index 8f253d2..3502d2a 100644
> ---
> a/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.inf
> +++
> b/ShellPkg/Library/UefiShellNetwork2CommandsLib/UefiShellNetwork2Com
> mandsLib.inf
> @@ -53,11 +53,11 @@ [LibraryClasses]
> [Pcd]
> gEfiShellPkgTokenSpaceGuid.PcdShellProfileMask ## CONSUMES
>
> [Protocols]
> gEfiCpuArchProtocolGuid ## CONSUMES
> - gEfiTimerArchProtocolGuid
> + gEfiTimerArchProtocolGuid ## CONSUMES
> gEfiIp6ProtocolGuid ## SOMETIMES_CONSUMES
> gEfiIp6ServiceBindingProtocolGuid ## SOMETIMES_CONSUMES
> gEfiIp6ConfigProtocolGuid ## SOMETIMES_CONSUMES
>
> [Guids]
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 04/18] Security:Add info string to UNI file for PcdPkcs7CertBuffer
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (2 preceding siblings ...)
2016-12-13 8:40 ` [patch 03/18] ShellPkg/UefiShellNetwork2CommandsLib: " Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
[not found] ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DCA@SHSMSX103.ccr.corp.intel.com>
2016-12-13 8:40 ` [patch 05/18] SecurityPkg/FmpAuthenticationLibPkcs7: Fix incorrect Guid format Dandan Bi
` (13 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chao Zhang
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
SecurityPkg/SecurityPkg.uni | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/SecurityPkg/SecurityPkg.uni b/SecurityPkg/SecurityPkg.uni
index 17a6842..6d99638 100644
--- a/SecurityPkg/SecurityPkg.uni
+++ b/SecurityPkg/SecurityPkg.uni
@@ -212,5 +212,10 @@
#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdUserPhysicalPresence_HELP
#language en-US
"Indicate whether a physical presence user exist. "
"When it is configured to Dynamic or DynamicEx, it can be set through detection using "
"a platform-specific method (e.g. Button pressed) in a actual platform in early boot phase.<BR><BR>"
+#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPkcs7CertBuffer_PROMPT #language en-US "One PKCS7 cert used to verify Recovery and Capsule Update images"
+
+#string STR_gEfiSecurityPkgTokenSpaceGuid_PcdPkcs7CertBuffer_HELP #language en-US "Provides one PKCS7 cert used to verify Recovery and Capsule Update images\n"
+ "WARNING: The default value is treated as test key. Please do not use default value in the production."
+
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [patch 05/18] SecurityPkg/FmpAuthenticationLibPkcs7: Fix incorrect Guid format
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (3 preceding siblings ...)
2016-12-13 8:40 ` [patch 04/18] Security:Add info string to UNI file for PcdPkcs7CertBuffer Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:50 ` Yao, Jiewen
2016-12-13 8:40 ` [patch 06/18] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Fix Guid/pcd format issues Dandan Bi
` (12 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chao Zhang
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf b/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
index ac263bf..bce958d 100644
--- a/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
+++ b/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf
@@ -44,6 +44,6 @@ [LibraryClasses]
DebugLib
MemoryAllocationLib
BaseCryptLib
[Guids]
- gEfiCertPkcs7Guid
+ gEfiCertPkcs7Guid ## CONSUMES
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 05/18] SecurityPkg/FmpAuthenticationLibPkcs7: Fix incorrect Guid format
2016-12-13 8:40 ` [patch 05/18] SecurityPkg/FmpAuthenticationLibPkcs7: Fix incorrect Guid format Dandan Bi
@ 2016-12-13 8:50 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:50 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Zhang, Chao B
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>
> Subject: [edk2] [patch 05/18] SecurityPkg/FmpAuthenticationLibPkcs7: Fix
> incorrect Guid format
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.inf | 2
> +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git
> a/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.i
> nf
> b/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.i
> nf
> index ac263bf..bce958d 100644
> ---
> a/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.i
> nf
> +++
> b/SecurityPkg/Library/FmpAuthenticationLibPkcs7/FmpAuthenticationLibPkcs7.i
> nf
> @@ -44,6 +44,6 @@ [LibraryClasses]
> DebugLib
> MemoryAllocationLib
> BaseCryptLib
>
> [Guids]
> - gEfiCertPkcs7Guid
> + gEfiCertPkcs7Guid ## CONSUMES
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 06/18] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Fix Guid/pcd format issues
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (4 preceding siblings ...)
2016-12-13 8:40 ` [patch 05/18] SecurityPkg/FmpAuthenticationLibPkcs7: Fix incorrect Guid format Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:50 ` Yao, Jiewen
2016-12-13 8:40 ` [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function Dandan Bi
` (11 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Chao Zhang
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../FmpAuthenticationLibRsa2048Sha256.inf | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
index fbff00e..b58966d 100644
--- a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
+++ b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationLibRsa2048Sha256.inf
@@ -44,10 +44,10 @@ [LibraryClasses]
DebugLib
MemoryAllocationLib
BaseCryptLib
[Pcd]
- gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer
+ gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer ## CONSUMES
[Guids]
- gEfiCertTypeRsa2048Sha256Guid
- gEfiHashAlgorithmSha256Guid
+ gEfiCertTypeRsa2048Sha256Guid ## CONSUMES
+ gEfiHashAlgorithmSha256Guid ## CONSUMES
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 06/18] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Fix Guid/pcd format issues
2016-12-13 8:40 ` [patch 06/18] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Fix Guid/pcd format issues Dandan Bi
@ 2016-12-13 8:50 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:50 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Zhang, Chao B
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Zhang, Chao B
> <chao.b.zhang@intel.com>
> Subject: [patch 06/18] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Fix
> Guid/pcd format issues
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../FmpAuthenticationLibRsa2048Sha256.inf | 6
> +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationL
> ibRsa2048Sha256.inf
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthentication
> LibRsa2048Sha256.inf
> index fbff00e..b58966d 100644
> ---
> a/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthenticationL
> ibRsa2048Sha256.inf
> +++
> b/SecurityPkg/Library/FmpAuthenticationLibRsa2048Sha256/FmpAuthentication
> LibRsa2048Sha256.inf
> @@ -44,10 +44,10 @@ [LibraryClasses]
> DebugLib
> MemoryAllocationLib
> BaseCryptLib
>
> [Pcd]
> - gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer
> + gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer ##
> CONSUMES
>
> [Guids]
> - gEfiCertTypeRsa2048Sha256Guid
> - gEfiHashAlgorithmSha256Guid
> + gEfiCertTypeRsa2048Sha256Guid ## CONSUMES
> + gEfiHashAlgorithmSha256Guid ## CONSUMES
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (5 preceding siblings ...)
2016-12-13 8:40 ` [patch 06/18] SecurityPkg/FmpAuthenticationLibRsa2048Sha256: Fix Guid/pcd format issues Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-14 5:18 ` Dong, Eric
2016-12-13 8:40 ` [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style issues in INF file Dandan Bi
` (10 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Eric Dong, Chao Zhang
Cc: Eric Dong <eric.dong@intel.com>
Cc: Chao Zhang <chao.b.zhang@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
index 4f82c1c..74d1c1f 100644
--- a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
+++ b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
@@ -1174,11 +1174,11 @@ HiiPasswordEntered(
}
/**
Update block sid info.
- @param Enable Enable/disable BlockSid.
+ @param PpRequest TPM physical presence operation request.
@retval EFI_SUCCESS Do the required action success.
@retval Others Other error occur.
**/
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function
2016-12-13 8:40 ` [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function Dandan Bi
@ 2016-12-14 5:18 ` Dong, Eric
0 siblings, 0 replies; 39+ messages in thread
From: Dong, Eric @ 2016-12-14 5:18 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Zhang, Chao B
Please also update the function comment to "Send BlockSid request through TPM physical presence module."
With this change, the patch is good.
Reviewed-by: Eric Dong <eric.dong@intel.com>
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Dong, Eric; Zhang, Chao B
> Subject: [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function
>
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Chao Zhang <chao.b.zhang@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
> index 4f82c1c..74d1c1f 100644
> --- a/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
> +++ b/SecurityPkg/Tcg/Opal/OpalPasswordDxe/OpalHii.c
> @@ -1174,11 +1174,11 @@ HiiPasswordEntered(
> }
>
> /**
> Update block sid info.
>
> - @param Enable Enable/disable BlockSid.
> + @param PpRequest TPM physical presence operation request.
>
> @retval EFI_SUCCESS Do the required action success.
> @retval Others Other error occur.
>
> **/
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style issues in INF file
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (6 preceding siblings ...)
2016-12-13 8:40 ` [patch 07/18] SecurityPkg/OpalPasswordDxe: Make comments align with the function Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:49 ` Yao, Jiewen
2016-12-13 8:40 ` [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source file to " Dandan Bi
` (9 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
Fix incorrect Guid/Pcd format issues in INF file.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
index 3c629ee..a7c9607 100644
--- a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
+++ b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
@@ -45,17 +45,17 @@ [LibraryClasses]
DebugLib
MemoryAllocationLib
FmpAuthenticationLib
[Pcd]
- gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor
- gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareFileGuid
- gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer
- gEfiSecurityPkgTokenSpaceGuid.PcdPkcs7CertBuffer
+ gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor ## CONSUMES
+ gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareFileGuid ## CONSUMES
+ gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer ## CONSUMES
+ gEfiSecurityPkgTokenSpaceGuid.PcdPkcs7CertBuffer ## CONSUMES
[Guids]
- gEdkiiSystemFirmwareImageDescriptorFileGuid
- gEdkiiSystemFmpCapsuleConfigFileGuid
- gEdkiiSystemFmpCapsuleDriverFvFileGuid
- gEfiCertPkcs7Guid
- gEfiCertTypeRsa2048Sha256Guid
+ gEdkiiSystemFirmwareImageDescriptorFileGuid ## CONSUMES ## GUID
+ gEdkiiSystemFmpCapsuleConfigFileGuid ## CONSUMES ## GUID
+ gEdkiiSystemFmpCapsuleDriverFvFileGuid ## CONSUMES ## GUID
+ gEfiCertPkcs7Guid ## CONSUMES ## GUID
+ gEfiCertTypeRsa2048Sha256Guid ## CONSUMES ## GUID
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style issues in INF file
2016-12-13 8:40 ` [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style issues in INF file Dandan Bi
@ 2016-12-13 8:49 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:49 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style
> issues in INF file
>
> Fix incorrect Guid/Pcd format issues in INF file.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf | 18
> +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git
> a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> index 3c629ee..a7c9607 100644
> ---
> a/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> +++
> b/SignedCapsulePkg/Library/EdkiiSystemCapsuleLib/EdkiiSystemCapsuleLib.inf
> @@ -45,17 +45,17 @@ [LibraryClasses]
> DebugLib
> MemoryAllocationLib
> FmpAuthenticationLib
>
> [Pcd]
> -
> gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor
> - gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareFileGuid
> - gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer
> - gEfiSecurityPkgTokenSpaceGuid.PcdPkcs7CertBuffer
> +
> gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareImageDescriptor
> ## CONSUMES
> + gEfiSignedCapsulePkgTokenSpaceGuid.PcdEdkiiSystemFirmwareFileGuid
> ## CONSUMES
> + gEfiSecurityPkgTokenSpaceGuid.PcdRsa2048Sha256PublicKeyBuffer
> ## CONSUMES
> + gEfiSecurityPkgTokenSpaceGuid.PcdPkcs7CertBuffer
> ## CONSUMES
>
> [Guids]
> - gEdkiiSystemFirmwareImageDescriptorFileGuid
> - gEdkiiSystemFmpCapsuleConfigFileGuid
> - gEdkiiSystemFmpCapsuleDriverFvFileGuid
> - gEfiCertPkcs7Guid
> - gEfiCertTypeRsa2048Sha256Guid
> + gEdkiiSystemFirmwareImageDescriptorFileGuid ## CONSUMES
> ## GUID
> + gEdkiiSystemFmpCapsuleConfigFileGuid ## CONSUMES
> ## GUID
> + gEdkiiSystemFmpCapsuleDriverFvFileGuid ## CONSUMES
> ## GUID
> + gEfiCertPkcs7Guid ## CONSUMES
> ## GUID
> + gEfiCertTypeRsa2048Sha256Guid ## CONSUMES
> ## GUID
>
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source file to INF file
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (7 preceding siblings ...)
2016-12-13 8:40 ` [patch 08/18] SignedCapsulePkg/EdkiiSystemCapsuleLib: Fix coding style issues in INF file Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:49 ` Yao, Jiewen
2016-12-13 8:40 ` [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: " Dandan Bi
` (8 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
Add RecoveryModuleLoadPei.h to [Sources] section of INF file.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf | 1 +
1 file changed, 1 insertion(+)
diff --git a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf
index 563be18..96a0cdd 100644
--- a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf
+++ b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf
@@ -29,10 +29,11 @@ [Defines]
#
# VALID_ARCHITECTURES = IA32 X64 IPF EBC
#
[Sources]
+ RecoveryModuleLoadPei.h
RecoveryModuleLoadPei.c
ParseConfigProfile.c
[Packages]
MdePkg/MdePkg.dec
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source file to INF file
2016-12-13 8:40 ` [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source file to " Dandan Bi
@ 2016-12-13 8:49 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:49 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source
> file to INF file
>
> Add RecoveryModuleLoadPei.h to [Sources] section of INF file.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../Universal/RecoveryModuleLoadPei/RecoveryModuleLoadPei.inf
> | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.inf
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoad
> Pei.inf
> index 563be18..96a0cdd 100644
> ---
> a/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoadP
> ei.inf
> +++
> b/SignedCapsulePkg/Universal/RecoveryModuleLoadPei/RecoveryModuleLoad
> Pei.inf
> @@ -29,10 +29,11 @@ [Defines]
> #
> # VALID_ARCHITECTURES = IA32 X64 IPF EBC
> #
>
> [Sources]
> + RecoveryModuleLoadPei.h
> RecoveryModuleLoadPei.c
> ParseConfigProfile.c
>
> [Packages]
> MdePkg/MdePkg.dec
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: Add source file to INF file
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (8 preceding siblings ...)
2016-12-13 8:40 ` [patch 09/18] SignedCapsulePkg/RecoveryModuleLoadPei: Add source file to " Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:48 ` Yao, Jiewen
2016-12-13 8:40 ` [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name Dandan Bi
` (7 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
Add SystemFirmwareDxe.h to [Sources] section of INF file.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
.../Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf | 1 +
.../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf | 1 +
2 files changed, 2 insertions(+)
diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf
index 89a86ff..cc9614e 100644
--- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf
+++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf
@@ -28,10 +28,11 @@ [Defines]
#
# VALID_ARCHITECTURES = X64
#
[Sources]
+ SystemFirmwareDxe.h
SystemFirmwareCommonDxe.c
SystemFirmwareReportDxe.c
[Packages]
MdePkg/MdePkg.dec
diff --git a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf
index 7a6ca54..2695fb6 100644
--- a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf
+++ b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf
@@ -28,10 +28,11 @@ [Defines]
#
# VALID_ARCHITECTURES = X64
#
[Sources]
+ SystemFirmwareDxe.h
SystemFirmwareCommonDxe.c
SystemFirmwareUpdateDxe.c
ParseConfigProfile.c
[Packages]
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: Add source file to INF file
2016-12-13 8:40 ` [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: " Dandan Bi
@ 2016-12-13 8:48 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:48 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: Add source
> file to INF file
>
> Add SystemFirmwareDxe.h to [Sources] section of INF file.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> .../Universal/SystemFirmwareUpdate/SystemFirmwareReportDxe.inf
> | 1 +
> .../Universal/SystemFirmwareUpdate/SystemFirmwareUpdateDxe.inf
> | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReport
> Dxe.inf
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReport
> Dxe.inf
> index 89a86ff..cc9614e 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReport
> Dxe.inf
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareReport
> Dxe.inf
> @@ -28,10 +28,11 @@ [Defines]
> #
> # VALID_ARCHITECTURES = X64
> #
>
> [Sources]
> + SystemFirmwareDxe.h
> SystemFirmwareCommonDxe.c
> SystemFirmwareReportDxe.c
>
> [Packages]
> MdePkg/MdePkg.dec
> diff --git
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdat
> eDxe.inf
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdat
> eDxe.inf
> index 7a6ca54..2695fb6 100644
> ---
> a/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdat
> eDxe.inf
> +++
> b/SignedCapsulePkg/Universal/SystemFirmwareUpdate/SystemFirmwareUpdat
> eDxe.inf
> @@ -28,10 +28,11 @@ [Defines]
> #
> # VALID_ARCHITECTURES = X64
> #
>
> [Sources]
> + SystemFirmwareDxe.h
> SystemFirmwareCommonDxe.c
> SystemFirmwareUpdateDxe.c
> ParseConfigProfile.c
>
> [Packages]
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (9 preceding siblings ...)
2016-12-13 8:40 ` [patch 10/18] SignedCapsulePkg/SystemFirmwareUpdate: " Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:49 ` Yao, Jiewen
2016-12-13 8:40 ` [patch 12/18] UefiCpuPkg: Make the comments align with the functions Dandan Bi
` (6 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
1. Change _SECTION_ITEM to _SECTION_ITEMS
2. Change _COMMENT_LINE to _COMMENT_LINES
Because _SECTION_ITEM and _COMMENT_LINE are duplicated with
the one defined in IntelFrameworkModulePkg\Universal\
FirmwareVolume\UpdateDriverDxe\UpdateDriver.h
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
index 5c975f7..cce9f6a 100644
--- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
+++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
@@ -48,21 +48,21 @@
#define IS_NULL(a) ((a) == '\0')
// This is default allocation. Reallocation will happen if it is not enough.
#define MAX_LINE_LENGTH 512
-typedef struct _SECTION_ITEM SECTION_ITEM;
-struct _SECTION_ITEM {
+typedef struct _SECTION_ITEMS SECTION_ITEM;
+struct _SECTION_ITEMS {
CHAR8 *PtrSection;
UINTN SecNameLen;
CHAR8 *PtrEntry;
CHAR8 *PtrValue;
SECTION_ITEM *PtrNext;
};
-typedef struct _COMMENT_LINE COMMENT_LINE;
-struct _COMMENT_LINE {
+typedef struct _COMMENT_LINES COMMENT_LINE;
+struct _COMMENT_LINES {
CHAR8 *PtrComment;
COMMENT_LINE *PtrNext;
};
typedef struct {
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
2016-12-13 8:40 ` [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name Dandan Bi
@ 2016-12-13 8:49 ` Yao, Jiewen
2016-12-14 2:36 ` Yao, Jiewen
0 siblings, 1 reply; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:49 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
This seems odd.
This is a C file. No one should include 2 files at same time.
I suggest we keep it as is.
Thank you
Yao Jiewen
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
>
> 1. Change _SECTION_ITEM to _SECTION_ITEMS
> 2. Change _COMMENT_LINE to _COMMENT_LINES
> Because _SECTION_ITEM and _COMMENT_LINE are duplicated with
> the one defined in IntelFrameworkModulePkg\Universal\
> FirmwareVolume\UpdateDriverDxe\UpdateDriver.h
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> index 5c975f7..cce9f6a 100644
> --- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> +++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> @@ -48,21 +48,21 @@
> #define IS_NULL(a) ((a) == '\0')
>
> // This is default allocation. Reallocation will happen if it is not enough.
> #define MAX_LINE_LENGTH 512
>
> -typedef struct _SECTION_ITEM SECTION_ITEM;
> -struct _SECTION_ITEM {
> +typedef struct _SECTION_ITEMS SECTION_ITEM;
> +struct _SECTION_ITEMS {
> CHAR8 *PtrSection;
> UINTN SecNameLen;
> CHAR8 *PtrEntry;
> CHAR8 *PtrValue;
> SECTION_ITEM *PtrNext;
> };
>
> -typedef struct _COMMENT_LINE COMMENT_LINE;
> -struct _COMMENT_LINE {
> +typedef struct _COMMENT_LINES COMMENT_LINE;
> +struct _COMMENT_LINES {
> CHAR8 *PtrComment;
> COMMENT_LINE *PtrNext;
> };
>
> typedef struct {
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 39+ messages in thread* Re: [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
2016-12-13 8:49 ` Yao, Jiewen
@ 2016-12-14 2:36 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-14 2:36 UTC (permalink / raw)
To: Yao, Jiewen, Bi, Dandan, edk2-devel@lists.01.org
I checked code again.
May we can we use a better name, such as INI_COMMENT_LINE or INI_SECTION_ITEM?
Thank you
From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of Yao, Jiewen
Sent: Tuesday, December 13, 2016 4:50 PM
To: Bi, Dandan <dandan.bi@intel.com>; edk2-devel@lists.01.org
Subject: Re: [edk2] [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
This seems odd.
This is a C file. No one should include 2 files at same time.
I suggest we keep it as is.
Thank you
Yao Jiewen
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
> Cc: Yao, Jiewen <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> Subject: [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
>
> 1. Change _SECTION_ITEM to _SECTION_ITEMS
> 2. Change _COMMENT_LINE to _COMMENT_LINES
> Because _SECTION_ITEM and _COMMENT_LINE are duplicated with
> the one defined in IntelFrameworkModulePkg\Universal\
> FirmwareVolume\UpdateDriverDxe\UpdateDriver.h
>
> Cc: Jiewen Yao <jiewen.yao@intel.com<mailto:jiewen.yao@intel.com>>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com<mailto:dandan.bi@intel.com>>
> ---
> SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> index 5c975f7..cce9f6a 100644
> --- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> +++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> @@ -48,21 +48,21 @@
> #define IS_NULL(a) ((a) == '\0')
>
> // This is default allocation. Reallocation will happen if it is not enough.
> #define MAX_LINE_LENGTH 512
>
> -typedef struct _SECTION_ITEM SECTION_ITEM;
> -struct _SECTION_ITEM {
> +typedef struct _SECTION_ITEMS SECTION_ITEM;
> +struct _SECTION_ITEMS {
> CHAR8 *PtrSection;
> UINTN SecNameLen;
> CHAR8 *PtrEntry;
> CHAR8 *PtrValue;
> SECTION_ITEM *PtrNext;
> };
>
> -typedef struct _COMMENT_LINE COMMENT_LINE;
> -struct _COMMENT_LINE {
> +typedef struct _COMMENT_LINES COMMENT_LINE;
> +struct _COMMENT_LINES {
> CHAR8 *PtrComment;
> COMMENT_LINE *PtrNext;
> };
>
> typedef struct {
> --
> 1.9.5.msysgit.1
_______________________________________________
edk2-devel mailing list
edk2-devel@lists.01.org<mailto:edk2-devel@lists.01.org>
https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 12/18] UefiCpuPkg: Make the comments align with the functions
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (10 preceding siblings ...)
2016-12-13 8:40 ` [patch 11/18] SignedCapsulePkg/IniParsingLib: Update struct name Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-14 2:50 ` Fan, Jeff
2016-12-13 8:40 ` [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable Dandan Bi
` (5 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jeff Fan
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
UefiCpuPkg/CpuDxe/CpuMp.c | 2 +-
UefiCpuPkg/Include/Library/MpInitLib.h | 4 ++--
UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 4 ++--
UefiCpuPkg/Library/MpInitLib/MpLib.c | 11 ++++++-----
UefiCpuPkg/Library/MpInitLib/MpLib.h | 4 ++--
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 4 ++--
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +-
UefiCpuPkg/SecCore/SecBist.c | 16 ++++++++--------
8 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c
index 3e4f83f..9659bd2 100644
--- a/UefiCpuPkg/CpuDxe/CpuMp.c
+++ b/UefiCpuPkg/CpuDxe/CpuMp.c
@@ -320,11 +320,11 @@ StartupAllAPs (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
this AP to finish this Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
this AP returns from Procedure, then Procedure
on the AP is terminated. The
diff --git a/UefiCpuPkg/Include/Library/MpInitLib.h b/UefiCpuPkg/Include/Library/MpInitLib.h
index 3e19382..05e9c6b 100644
--- a/UefiCpuPkg/Include/Library/MpInitLib.h
+++ b/UefiCpuPkg/Include/Library/MpInitLib.h
@@ -114,11 +114,11 @@ MpInitLibGetProcessorInfo (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
all APs return from Procedure, then Procedure
on the failed APs is terminated. All enabled
@@ -200,11 +200,11 @@ MpInitLibStartupAllAPs (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
this AP to finish this Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
this AP returns from Procedure, then Procedure
on the AP is terminated. The
diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
index 8f5074b..e75c269 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
@@ -408,11 +408,11 @@ InitMpGlobalData (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
all APs return from Procedure, then Procedure
on the failed APs is terminated. All enabled
@@ -518,11 +518,11 @@ MpInitLibStartupAllAPs (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
this AP to finish this Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
this AP returns from Procedure, then Procedure
on the AP is terminated. The
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
index ed22ce6..0495b0f 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
@@ -335,12 +335,12 @@ ApInitializeSync (
}
/**
Find the current Processor number by APIC ID.
- @param[in] CpuMpData Pointer to PEI CPU MP Data
- @param[in] ProcessorNumber Return the pocessor number found
+ @param[in] CpuMpData Pointer to PEI CPU MP Data
+ @param[out] ProcessorNumber Return the pocessor number found
@retval EFI_SUCCESS ProcessorNumber is found and returned.
@retval EFI_NOT_FOUND ProcessorNumber is not found.
**/
EFI_STATUS
@@ -418,16 +418,17 @@ CollectProcessorCount (
DEBUG ((DEBUG_INFO, "MpInitLib: Find %d processors in system.\n", CpuMpData->CpuCount));
return CpuMpData->CpuCount;
}
-/*
+/**
Initialize CPU AP Data when AP is wakeup at the first time.
@param[in, out] CpuMpData Pointer to PEI CPU MP Data
@param[in] ProcessorNumber The handle number of processor
@param[in] BistData Processor BIST data
+ @param[in] ApTopOfStack Top of AP stack
**/
VOID
InitializeApData (
IN OUT CPU_MP_DATA *CpuMpData,
@@ -1704,11 +1705,11 @@ MpInitLibGetNumberOfProcessors (
number. If FALSE, then all the enabled APs
execute the function specified by Procedure
simultaneously.
@param[in] WaitEvent The event created by the caller with CreateEvent()
service.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode.
@param[in] ProcedureArgument The parameter passed into Procedure for
all APs.
@param[out] FailedCpuList If all APs finish successfully, then its
@@ -1858,11 +1859,11 @@ StartupAllAPsWorker (
@param[in] Procedure A pointer to the function to be run on
enabled APs of the system.
@param[in] ProcessorNumber The handle number of the AP.
@param[in] WaitEvent The event created by the caller with CreateEvent()
service.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode.
@param[in] ProcedureArgument The parameter passed into Procedure for
all APs.
@param[out] Finished If AP returns from Procedure before the
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 49305ad..9861a5c 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -363,11 +363,11 @@ InitMpGlobalData (
number. If FALSE, then all the enabled APs
execute the function specified by Procedure
simultaneously.
@param[in] WaitEvent The event created by the caller with CreateEvent()
service.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode.
@param[in] ProcedureArgument The parameter passed into Procedure for
all APs.
@param[out] FailedCpuList If all APs finish successfully, then its
@@ -400,11 +400,11 @@ StartupAllAPsWorker (
@param[in] Procedure A pointer to the function to be run on
enabled APs of the system.
@param[in] ProcessorNumber The handle number of the AP.
@param[in] WaitEvent The event created by the caller with CreateEvent()
service.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode.
@param[in] ProcedureArgument The parameter passed into Procedure for
all APs.
@param[out] Finished If AP returns from Procedure before the
diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
index 1f2fcb8..a4166a4 100644
--- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
@@ -361,11 +361,11 @@ InitMpGlobalData (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
all APs return from Procedure, then Procedure
on the failed APs is terminated. All enabled
@@ -461,11 +461,11 @@ MpInitLibStartupAllAPs (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
this AP to finish this Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
this AP returns from Procedure, then Procedure
on the AP is terminated. The
diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
index c146795..c7aa48b 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
@@ -897,11 +897,11 @@ SetCacheability (
/**
Schedule a procedure to run on the specified CPU.
@param[in] Procedure The address of the procedure to run
@param[in] CpuIndex Target CPU Index
- @param[in, OUT] ProcArguments The parameter to pass to the procedure
+ @param[in, out] ProcArguments The parameter to pass to the procedure
@param[in] BlockingMode Startup AP in blocking mode or not
@retval EFI_INVALID_PARAMETER CpuNumber not valid
@retval EFI_INVALID_PARAMETER CpuNumber specifying BSP
@retval EFI_INVALID_PARAMETER The AP specified by CpuNumber did not enter SMM
diff --git a/UefiCpuPkg/SecCore/SecBist.c b/UefiCpuPkg/SecCore/SecBist.c
index ba7d7ca..5eb8b3a 100644
--- a/UefiCpuPkg/SecCore/SecBist.c
+++ b/UefiCpuPkg/SecCore/SecBist.c
@@ -35,12 +35,12 @@ EFI_PEI_PPI_DESCRIPTOR mPeiSecPlatformInformation2 = {
};
/**
Worker function to parse CPU BIST information from Guided HOB.
- @param[out] StructureSize Pointer to the variable describing size of the input buffer.
- @param[out] StructureBuffer Pointer to the buffer save CPU BIST information.
+ @param[in, out] StructureSize Pointer to the variable describing size of the input buffer.
+ @param[in, out] StructureBuffer Pointer to the buffer save CPU BIST information.
@retval EFI_SUCCESS The data was successfully returned.
@retval EFI_BUFFER_TOO_SMALL The buffer was too small.
**/
@@ -77,13 +77,13 @@ GetBistFromHob (
}
/**
Implementation of the PlatformInformation service in EFI_SEC_PLATFORM_INFORMATION_PPI.
- @param[in] PeiServices Pointer to the PEI Services Table.
- @param[out] StructureSize Pointer to the variable describing size of the input buffer.
- @param[out PlatformInformationRecord Pointer to the EFI_SEC_PLATFORM_INFORMATION_RECORD.
+ @param[in] PeiServices Pointer to the PEI Services Table.
+ @param[in, out] StructureSize Pointer to the variable describing size of the input buffer.
+ @param[out PlatformInformationRecord Pointer to the EFI_SEC_PLATFORM_INFORMATION_RECORD.
@retval EFI_SUCCESS The data was successfully returned.
@retval EFI_BUFFER_TOO_SMALL The buffer was too small.
**/
@@ -99,13 +99,13 @@ SecPlatformInformationBist (
}
/**
Implementation of the PlatformInformation2 service in EFI_SEC_PLATFORM_INFORMATION2_PPI.
- @param[in] PeiServices The pointer to the PEI Services Table.
- @param[out] StructureSize The pointer to the variable describing size of the input buffer.
- @param[out] PlatformInformationRecord2 The pointer to the EFI_SEC_PLATFORM_INFORMATION_RECORD2.
+ @param[in] PeiServices The pointer to the PEI Services Table.
+ @param[in, out] StructureSize The pointer to the variable describing size of the input buffer.
+ @param[out] PlatformInformationRecord2 The pointer to the EFI_SEC_PLATFORM_INFORMATION_RECORD2.
@retval EFI_SUCCESS The data was successfully returned.
@retval EFI_BUFFER_TOO_SMALL The buffer was too small. The current buffer size needed to
hold the record is returned in StructureSize.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 12/18] UefiCpuPkg: Make the comments align with the functions
2016-12-13 8:40 ` [patch 12/18] UefiCpuPkg: Make the comments align with the functions Dandan Bi
@ 2016-12-14 2:50 ` Fan, Jeff
0 siblings, 0 replies; 39+ messages in thread
From: Fan, Jeff @ 2016-12-14 2:50 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
Please help to add missing ']' on @param[out PlatformInformationRecord.
Reviewed-by: Jeff Fan <jeff.fan@intel.com> with this update.
Thanks!
-----Original Message-----
From: Bi, Dandan
Sent: Tuesday, December 13, 2016 4:40 PM
To: edk2-devel@lists.01.org
Cc: Fan, Jeff
Subject: [patch 12/18] UefiCpuPkg: Make the comments align with the functions
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
UefiCpuPkg/CpuDxe/CpuMp.c | 2 +-
UefiCpuPkg/Include/Library/MpInitLib.h | 4 ++-- UefiCpuPkg/Library/MpInitLib/DxeMpLib.c | 4 ++--
UefiCpuPkg/Library/MpInitLib/MpLib.c | 11 ++++++-----
UefiCpuPkg/Library/MpInitLib/MpLib.h | 4 ++--
UefiCpuPkg/Library/MpInitLib/PeiMpLib.c | 4 ++--
UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c | 2 +-
UefiCpuPkg/SecCore/SecBist.c | 16 ++++++++--------
8 files changed, 24 insertions(+), 23 deletions(-)
diff --git a/UefiCpuPkg/CpuDxe/CpuMp.c b/UefiCpuPkg/CpuDxe/CpuMp.c index 3e4f83f..9659bd2 100644
--- a/UefiCpuPkg/CpuDxe/CpuMp.c
+++ b/UefiCpuPkg/CpuDxe/CpuMp.c
@@ -320,11 +320,11 @@ StartupAllAPs (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
this AP to finish this Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
this AP returns from Procedure, then Procedure
on the AP is terminated. The diff --git a/UefiCpuPkg/Include/Library/MpInitLib.h b/UefiCpuPkg/Include/Library/MpInitLib.h
index 3e19382..05e9c6b 100644
--- a/UefiCpuPkg/Include/Library/MpInitLib.h
+++ b/UefiCpuPkg/Include/Library/MpInitLib.h
@@ -114,11 +114,11 @@ MpInitLibGetProcessorInfo (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
all APs return from Procedure, then Procedure
on the failed APs is terminated. All enabled @@ -200,11 +200,11 @@ MpInitLibStartupAllAPs (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
this AP to finish this Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
this AP returns from Procedure, then Procedure
on the AP is terminated. The diff --git a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
index 8f5074b..e75c269 100644
--- a/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/DxeMpLib.c
@@ -408,11 +408,11 @@ InitMpGlobalData (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
all APs return from Procedure, then Procedure
on the failed APs is terminated. All enabled @@ -518,11 +518,11 @@ MpInitLibStartupAllAPs (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
this AP to finish this Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
this AP returns from Procedure, then Procedure
on the AP is terminated. The diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.c b/UefiCpuPkg/Library/MpInitLib/MpLib.c
index ed22ce6..0495b0f 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.c
@@ -335,12 +335,12 @@ ApInitializeSync ( }
/**
Find the current Processor number by APIC ID.
- @param[in] CpuMpData Pointer to PEI CPU MP Data
- @param[in] ProcessorNumber Return the pocessor number found
+ @param[in] CpuMpData Pointer to PEI CPU MP Data
+ @param[out] ProcessorNumber Return the pocessor number found
@retval EFI_SUCCESS ProcessorNumber is found and returned.
@retval EFI_NOT_FOUND ProcessorNumber is not found.
**/
EFI_STATUS
@@ -418,16 +418,17 @@ CollectProcessorCount (
DEBUG ((DEBUG_INFO, "MpInitLib: Find %d processors in system.\n", CpuMpData->CpuCount));
return CpuMpData->CpuCount;
}
-/*
+/**
Initialize CPU AP Data when AP is wakeup at the first time.
@param[in, out] CpuMpData Pointer to PEI CPU MP Data
@param[in] ProcessorNumber The handle number of processor
@param[in] BistData Processor BIST data
+ @param[in] ApTopOfStack Top of AP stack
**/
VOID
InitializeApData (
IN OUT CPU_MP_DATA *CpuMpData,
@@ -1704,11 +1705,11 @@ MpInitLibGetNumberOfProcessors (
number. If FALSE, then all the enabled APs
execute the function specified by Procedure
simultaneously.
@param[in] WaitEvent The event created by the caller with CreateEvent()
service.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode.
@param[in] ProcedureArgument The parameter passed into Procedure for
all APs.
@param[out] FailedCpuList If all APs finish successfully, then its
@@ -1858,11 +1859,11 @@ StartupAllAPsWorker (
@param[in] Procedure A pointer to the function to be run on
enabled APs of the system.
@param[in] ProcessorNumber The handle number of the AP.
@param[in] WaitEvent The event created by the caller with CreateEvent()
service.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode.
@param[in] ProcedureArgument The parameter passed into Procedure for
all APs.
@param[out] Finished If AP returns from Procedure before the
diff --git a/UefiCpuPkg/Library/MpInitLib/MpLib.h b/UefiCpuPkg/Library/MpInitLib/MpLib.h
index 49305ad..9861a5c 100644
--- a/UefiCpuPkg/Library/MpInitLib/MpLib.h
+++ b/UefiCpuPkg/Library/MpInitLib/MpLib.h
@@ -363,11 +363,11 @@ InitMpGlobalData (
number. If FALSE, then all the enabled APs
execute the function specified by Procedure
simultaneously.
@param[in] WaitEvent The event created by the caller with CreateEvent()
service.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode.
@param[in] ProcedureArgument The parameter passed into Procedure for
all APs.
@param[out] FailedCpuList If all APs finish successfully, then its
@@ -400,11 +400,11 @@ StartupAllAPsWorker (
@param[in] Procedure A pointer to the function to be run on
enabled APs of the system.
@param[in] ProcessorNumber The handle number of the AP.
@param[in] WaitEvent The event created by the caller with CreateEvent()
service.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode.
@param[in] ProcedureArgument The parameter passed into Procedure for
all APs.
@param[out] Finished If AP returns from Procedure before the
diff --git a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
index 1f2fcb8..a4166a4 100644
--- a/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
+++ b/UefiCpuPkg/Library/MpInitLib/PeiMpLib.c
@@ -361,11 +361,11 @@ InitMpGlobalData (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
APs to return from Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
all APs return from Procedure, then Procedure
on the failed APs is terminated. All enabled @@ -461,11 +461,11 @@ MpInitLibStartupAllAPs (
can use the CheckEvent() or WaitForEvent()
services to check the state of event. Type
EFI_EVENT is defined in CreateEvent() in
the Unified Extensible Firmware Interface
Specification.
- @param[in] TimeoutInMicrosecsond Indicates the time limit in microseconds for
+ @param[in] TimeoutInMicroseconds Indicates the time limit in microseconds for
this AP to finish this Procedure, either for
blocking or non-blocking mode. Zero means
infinity. If the timeout expires before
this AP returns from Procedure, then Procedure
on the AP is terminated. The diff --git a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
index c146795..c7aa48b 100644
--- a/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
+++ b/UefiCpuPkg/PiSmmCpuDxeSmm/MpService.c
@@ -897,11 +897,11 @@ SetCacheability (
/**
Schedule a procedure to run on the specified CPU.
@param[in] Procedure The address of the procedure to run
@param[in] CpuIndex Target CPU Index
- @param[in, OUT] ProcArguments The parameter to pass to the procedure
+ @param[in, out] ProcArguments The parameter to pass to the procedure
@param[in] BlockingMode Startup AP in blocking mode or not
@retval EFI_INVALID_PARAMETER CpuNumber not valid
@retval EFI_INVALID_PARAMETER CpuNumber specifying BSP
@retval EFI_INVALID_PARAMETER The AP specified by CpuNumber did not enter SMM
diff --git a/UefiCpuPkg/SecCore/SecBist.c b/UefiCpuPkg/SecCore/SecBist.c index ba7d7ca..5eb8b3a 100644
--- a/UefiCpuPkg/SecCore/SecBist.c
+++ b/UefiCpuPkg/SecCore/SecBist.c
@@ -35,12 +35,12 @@ EFI_PEI_PPI_DESCRIPTOR mPeiSecPlatformInformation2 = { };
/**
Worker function to parse CPU BIST information from Guided HOB.
- @param[out] StructureSize Pointer to the variable describing size of the input buffer.
- @param[out] StructureBuffer Pointer to the buffer save CPU BIST information.
+ @param[in, out] StructureSize Pointer to the variable describing size of the input buffer.
+ @param[in, out] StructureBuffer Pointer to the buffer save CPU BIST information.
@retval EFI_SUCCESS The data was successfully returned.
@retval EFI_BUFFER_TOO_SMALL The buffer was too small.
**/
@@ -77,13 +77,13 @@ GetBistFromHob (
}
/**
Implementation of the PlatformInformation service in EFI_SEC_PLATFORM_INFORMATION_PPI.
- @param[in] PeiServices Pointer to the PEI Services Table.
- @param[out] StructureSize Pointer to the variable describing size of the input buffer.
- @param[out PlatformInformationRecord Pointer to the EFI_SEC_PLATFORM_INFORMATION_RECORD.
+ @param[in] PeiServices Pointer to the PEI Services Table.
+ @param[in, out] StructureSize Pointer to the variable describing size of the input buffer.
+ @param[out PlatformInformationRecord Pointer to the EFI_SEC_PLATFORM_INFORMATION_RECORD.
@retval EFI_SUCCESS The data was successfully returned.
@retval EFI_BUFFER_TOO_SMALL The buffer was too small.
**/
@@ -99,13 +99,13 @@ SecPlatformInformationBist ( }
/**
Implementation of the PlatformInformation2 service in EFI_SEC_PLATFORM_INFORMATION2_PPI.
- @param[in] PeiServices The pointer to the PEI Services Table.
- @param[out] StructureSize The pointer to the variable describing size of the input buffer.
- @param[out] PlatformInformationRecord2 The pointer to the EFI_SEC_PLATFORM_INFORMATION_RECORD2.
+ @param[in] PeiServices The pointer to the PEI Services Table.
+ @param[in, out] StructureSize The pointer to the variable describing size of the input buffer.
+ @param[out] PlatformInformationRecord2 The pointer to the EFI_SEC_PLATFORM_INFORMATION_RECORD2.
@retval EFI_SUCCESS The data was successfully returned.
@retval EFI_BUFFER_TOO_SMALL The buffer was too small. The current buffer size needed to
hold the record is returned in StructureSize.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread
* [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (11 preceding siblings ...)
2016-12-13 8:40 ` [patch 12/18] UefiCpuPkg: Make the comments align with the functions Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
[not found] ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DE3@SHSMSX103.ccr.corp.intel.com>
2016-12-14 2:51 ` Fan, Jeff
2016-12-13 8:40 ` [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file Dandan Bi
` (4 subsequent siblings)
17 siblings, 2 replies; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Jeff Fan
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
UefiCpuPkg/UefiCpuPkg.uni | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni
index 13f0e41..298ed7e 100644
--- a/UefiCpuPkg/UefiCpuPkg.uni
+++ b/UefiCpuPkg/UefiCpuPkg.uni
@@ -145,5 +145,13 @@
#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuApTargetCstate_PROMPT #language en-US "The specified AP target C-state for Mwait"
#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuApTargetCstate_HELP #language en-US "Specifies the AP target C-state for Mwait during POST phase."
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStaticPageTable_PROMPT #language en-US "Use static page table for all memory in SMM."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStaticPageTable_HELP #language en-US "Indicates if SMM uses static page table.\n"
+ "If enabled, SMM will not use on-demand paging. SMM will build static page table for all memory.<BR><BR>\n"
+ "This flag only impacts X64 build, because SMM alway builds static page table for IA32.\n"
+ "TRUE - SMM uses static page table for all memory.<BR>\n"
+ "FALSE - SMM uses static page table for below 4G memory and use on-demand paging for above 4G memory.<BR>"
+
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread[parent not found: <3C0D5C461C9E904E8F62152F6274C0BB3B856DE3@SHSMSX103.ccr.corp.intel.com>]
* Re: [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable
[not found] ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DE3@SHSMSX103.ccr.corp.intel.com>
@ 2016-12-14 2:41 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-14 2:41 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Fan, Jeff
Reviewed-by: Jiewen.yao@intel.com
>
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Fan, Jeff <jeff.fan@intel.com>
> Subject: [edk2] [patch 13/18] UefiCpuPkg: Add info string to UNI file for
> PcdCpuSmmStaticPageTable
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jeff Fan <jeff.fan@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> UefiCpuPkg/UefiCpuPkg.uni | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index
> 13f0e41..298ed7e 100644
> --- a/UefiCpuPkg/UefiCpuPkg.uni
> +++ b/UefiCpuPkg/UefiCpuPkg.uni
> @@ -145,5 +145,13 @@
>
> #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuApTargetCstate_PROMPT
> #language en-US "The specified AP target C-state for Mwait"
>
> #string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuApTargetCstate_HELP
> #language en-US "Specifies the AP target C-state for Mwait during POST phase."
>
> +#string
> STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStaticPageTable_PROMPT
> #language en-US "Use static page table for all memory in SMM."
> +
> +#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStaticPageTable_HELP
> #language en-US "Indicates if SMM uses static page table.\n"
> +
> "If enabled, SMM will not use on-demand paging. SMM will build static page
> table for all memory.<BR><BR>\n"
> +
> "This flag only impacts X64 build, because SMM alway builds static page table for
> IA32.\n"
> +
> "TRUE - SMM uses static page table for all memory.<BR>\n"
> +
> "FALSE - SMM uses static page table for below 4G memory and use on-demand
> paging for above 4G memory.<BR>"
> +
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 39+ messages in thread
* Re: [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable
2016-12-13 8:40 ` [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable Dandan Bi
[not found] ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DE3@SHSMSX103.ccr.corp.intel.com>
@ 2016-12-14 2:51 ` Fan, Jeff
1 sibling, 0 replies; 39+ messages in thread
From: Fan, Jeff @ 2016-12-14 2:51 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Yao, Jiewen
Reviewed-by: Jeff Fan <jeff.fan@intel.com>
-----Original Message-----
From: Bi, Dandan
Sent: Tuesday, December 13, 2016 4:40 PM
To: edk2-devel@lists.01.org
Cc: Yao, Jiewen; Fan, Jeff
Subject: [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
UefiCpuPkg/UefiCpuPkg.uni | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/UefiCpuPkg/UefiCpuPkg.uni b/UefiCpuPkg/UefiCpuPkg.uni index 13f0e41..298ed7e 100644
--- a/UefiCpuPkg/UefiCpuPkg.uni
+++ b/UefiCpuPkg/UefiCpuPkg.uni
@@ -145,5 +145,13 @@
#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuApTargetCstate_PROMPT #language en-US "The specified AP target C-state for Mwait"
#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuApTargetCstate_HELP #language en-US "Specifies the AP target C-state for Mwait during POST phase."
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStaticPageTable_PROMPT #language en-US "Use static page table for all memory in SMM."
+
+#string STR_gUefiCpuPkgTokenSpaceGuid_PcdCpuSmmStaticPageTable_HELP #language en-US "Indicates if SMM uses static page table.\n"
+ "If enabled, SMM will not use on-demand paging. SMM will build static page table for all memory.<BR><BR>\n"
+ "This flag only impacts X64 build, because SMM alway builds static page table for IA32.\n"
+ "TRUE - SMM uses static page table for all memory.<BR>\n"
+ "FALSE - SMM uses static page table for below 4G memory and use on-demand paging for above 4G memory.<BR>"
+
--
1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (12 preceding siblings ...)
2016-12-13 8:40 ` [patch 13/18] UefiCpuPkg: Add info string to UNI file for PcdCpuSmmStaticPageTable Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:46 ` Yao, Jiewen
2016-12-13 8:40 ` [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues Dandan Bi
` (3 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Jeff Fan
1. Add MicrocodeUpdate.h to the [Sources] section.
2. Fix the incorrect Guid/Protocol format issues.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf b/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
index 437d300..7aae348 100644
--- a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
+++ b/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
@@ -28,10 +28,11 @@ [Defines]
#
# VALID_ARCHITECTURES = X64
#
[Sources]
+ MicrocodeUpdate.h
MicrocodeFmp.c
MicrocodeUpdate.c
[Packages]
MdePkg/MdePkg.dec
@@ -49,14 +50,14 @@ [LibraryClasses]
UefiRuntimeServicesTableLib
UefiDriverEntryPoint
MicrocodeFlashAccessLib
[Guids]
- gMicrocodeFmpImageTypeIdGuid
+ gMicrocodeFmpImageTypeIdGuid ## CONSUMES ## GUID
[Protocols]
- gEfiFirmwareManagementProtocolGuid ## SOMTIMES_PRODUCE
+ gEfiFirmwareManagementProtocolGuid ## PRODUCES
[Pcd]
gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress ## CONSUMES
gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize ## CONSUMES
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file
2016-12-13 8:40 ` [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file Dandan Bi
@ 2016-12-13 8:46 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:46 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Fan, Jeff
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Fan, Jeff <jeff.fan@intel.com>
> Subject: [edk2] [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style
> issues in INF file
>
> 1. Add MicrocodeUpdate.h to the [Sources] section.
> 2. Fix the incorrect Guid/Protocol format issues.
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jeff Fan <jeff.fan@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.inf
> | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git
> a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in
> f
> b/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in
> f
> index 437d300..7aae348 100644
> ---
> a/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in
> f
> +++
> b/UefiCpuPkg/Feature/Capsule/MicrocodeUpdateDxe/MicrocodeUpdateDxe.in
> f
> @@ -28,10 +28,11 @@ [Defines]
> #
> # VALID_ARCHITECTURES = X64
> #
>
> [Sources]
> + MicrocodeUpdate.h
> MicrocodeFmp.c
> MicrocodeUpdate.c
>
> [Packages]
> MdePkg/MdePkg.dec
> @@ -49,14 +50,14 @@ [LibraryClasses]
> UefiRuntimeServicesTableLib
> UefiDriverEntryPoint
> MicrocodeFlashAccessLib
>
> [Guids]
> - gMicrocodeFmpImageTypeIdGuid
> + gMicrocodeFmpImageTypeIdGuid ## CONSUMES ##
> GUID
>
> [Protocols]
> - gEfiFirmwareManagementProtocolGuid ##
> SOMTIMES_PRODUCE
> + gEfiFirmwareManagementProtocolGuid ## PRODUCES
>
> [Pcd]
> gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchAddress
> ## CONSUMES
> gUefiCpuPkgTokenSpaceGuid.PcdCpuMicrocodePatchRegionSize
> ## CONSUMES
>
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (13 preceding siblings ...)
2016-12-13 8:40 ` [patch 14/18] UefiCpuPkg/MicrocodeUpdateDxe: Fix coding style issues in INF file Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:47 ` Yao, Jiewen
2016-12-13 8:40 ` [patch 16/18] MdeModulePkg: Make the comments align with the function Dandan Bi
` (2 subsequent siblings)
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao, Jeff Fan
Cc: Jiewen Yao <jiewen.yao@intel.com>
Cc: Jeff Fan <jeff.fan@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc | 1 +
UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc | 1 +
2 files changed, 2 insertions(+)
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc b/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc
index b8ab08d..1b22c55 100644
--- a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc
+++ b/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc
@@ -1,6 +1,7 @@
## @file
+# MicrocodeCapsulePdb
#
# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
diff --git a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc b/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
index 9b7e026..a66f89b 100644
--- a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
+++ b/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
@@ -1,6 +1,7 @@
## @file
+# MicrocodeCapsuleTxt
#
# Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
#
# This program and the accompanying materials
# are licensed and made available under the terms and conditions of the BSD License
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues
2016-12-13 8:40 ` [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues Dandan Bi
@ 2016-12-13 8:47 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:47 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org; +Cc: Fan, Jeff
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>; Fan, Jeff <jeff.fan@intel.com>
> Subject: [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Cc: Jeff Fan <jeff.fan@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>
> UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.dsc
> | 1 +
> UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
> | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git
> a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.d
> sc
> b/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.d
> sc
> index b8ab08d..1b22c55 100644
> ---
> a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.d
> sc
> +++
> b/UefiCpuPkg/Feature/Capsule/MicrocodeCapsulePdb/MicrocodeCapsulePdb.d
> sc
> @@ -1,6 +1,7 @@
> ## @file
> +# MicrocodeCapsulePdb
> #
> # Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the
> BSD License
> diff --git
> a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
> b/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
> index 9b7e026..a66f89b 100644
> ---
> a/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
> +++
> b/UefiCpuPkg/Feature/Capsule/MicrocodeCapsuleTxt/MicrocodeCapsuleTxt.dsc
> @@ -1,6 +1,7 @@
> ## @file
> +# MicrocodeCapsuleTxt
> #
> # Copyright (c) 2016, Intel Corporation. All rights reserved.<BR>
> #
> # This program and the accompanying materials
> # are licensed and made available under the terms and conditions of the
> BSD License
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 16/18] MdeModulePkg: Make the comments align with the function
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (14 preceding siblings ...)
2016-12-13 8:40 ` [patch 15/18] UefiCpuPkg/Capsule: Fix coding style issues Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:46 ` Yao, Jiewen
2016-12-13 8:40 ` [patch 17/18] MdeModulePkg: Add missing info string for PCDs Dandan Bi
2016-12-13 8:40 ` [patch 18/18] MdeModulePkg/CapsuleApp: Fix GUID/protocol format issues Dandan Bi
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
MdeModulePkg/Application/CapsuleApp/AppSupport.c | 10 +++++-----
MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 6 +++---
MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 8 ++++----
MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 ++--
4 files changed, 14 insertions(+), 14 deletions(-)
diff --git a/MdeModulePkg/Application/CapsuleApp/AppSupport.c b/MdeModulePkg/Application/CapsuleApp/AppSupport.c
index a5fd0ca..edc5f29 100644
--- a/MdeModulePkg/Application/CapsuleApp/AppSupport.c
+++ b/MdeModulePkg/Application/CapsuleApp/AppSupport.c
@@ -348,15 +348,15 @@ ReadFileFromVol (
If ScanFs is FLASE, it will use this Vol as default Fs.
If ScanFs is TRUE, it will scan all FS and check the file.
If there is only one file match the name, it will be read.
If there is more than one file match the name, it will return Error.
- @param[in] ThisVol File System Volume
- @param[in] FileName The file to be read.
- @param[out] BufferSize The file buffer size
- @param[out] Buffer The file buffer
- @param[in] ScanFs Need Scan all FS
+ @param[in,out] ThisVol File System Volume
+ @param[in] FileName The file to be read.
+ @param[out] BufferSize The file buffer size
+ @param[out] Buffer The file buffer
+ @param[in] ScanFs Need Scan all FS
@retval EFI_SUCCESS Read file successfully
@retval EFI_NOT_FOUND File not found
@retval EFI_NO_MAPPING There is duplicated files found
**/
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
index 3d83ec4..8f44e5e 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
@@ -29,13 +29,13 @@
#include <IndustryStandard/WindowsUxCapsule.h>
/**
Read a file.
- @param[in] FileName The file to be read.
- @param[in] BufferSize The file buffer size
- @param[in] Buffer The file buffer
+ @param[in] FileName The file to be read.
+ @param[out] BufferSize The file buffer size
+ @param[out] Buffer The file buffer
@retval EFI_SUCCESS Read file successfully
@retval EFI_NOT_FOUND File not found
**/
EFI_STATUS
diff --git a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
index f8edb78..eba938e 100644
--- a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
+++ b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
@@ -144,14 +144,14 @@ SmmMemoryAttributesTableConsistencyCheck (
}
/**
Sort memory map entries based upon PhysicalStart, from low to high.
- @param[in] MemoryMap A pointer to the buffer in which firmware places
- the current memory map.
- @param[in] MemoryMapSize Size, in bytes, of the MemoryMap buffer.
- @param[in] DescriptorSize Size, in bytes, of an individual EFI_MEMORY_DESCRIPTOR.
+ @param[in,out] MemoryMap A pointer to the buffer in which firmware places
+ the current memory map.
+ @param[in] MemoryMapSize Size, in bytes, of the MemoryMap buffer.
+ @param[in] DescriptorSize Size, in bytes, of an individual EFI_MEMORY_DESCRIPTOR.
**/
STATIC
VOID
SortMemoryMap (
IN OUT EFI_MEMORY_DESCRIPTOR *MemoryMap,
diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
index 5d46709..3ba3b9c 100644
--- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
+++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
@@ -774,12 +774,12 @@ DumpFmpCapsule (
EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER and
EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER are correct.
This function need support nested FMP capsule.
- @param[in] CapsuleHeader Points to a capsule header.
- @param[in] AreAllImagesProcessed If all the FMP images in the capsule are processed.
+ @param[in] CapsuleHeader Points to a capsule header.
+ @param[out] AreAllImagesProcessed If all the FMP images in the capsule are processed.
@retval EFI_SUCESS Process Capsule Image successfully.
@retval EFI_UNSUPPORTED Capsule image is not supported by the firmware.
@retval EFI_VOLUME_CORRUPTED FV volume in the capsule is corrupted.
@retval EFI_OUT_OF_RESOURCES Not enough memory.
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 16/18] MdeModulePkg: Make the comments align with the function
2016-12-13 8:40 ` [patch 16/18] MdeModulePkg: Make the comments align with the function Dandan Bi
@ 2016-12-13 8:46 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:46 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [patch 16/18] MdeModulePkg: Make the comments align with the
> function
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> MdeModulePkg/Application/CapsuleApp/AppSupport.c | 10 +++++-----
> MdeModulePkg/Application/CapsuleApp/CapsuleDump.c | 6 +++---
> MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c | 8 ++++----
> MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c | 4 ++--
> 4 files changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/MdeModulePkg/Application/CapsuleApp/AppSupport.c
> b/MdeModulePkg/Application/CapsuleApp/AppSupport.c
> index a5fd0ca..edc5f29 100644
> --- a/MdeModulePkg/Application/CapsuleApp/AppSupport.c
> +++ b/MdeModulePkg/Application/CapsuleApp/AppSupport.c
> @@ -348,15 +348,15 @@ ReadFileFromVol (
> If ScanFs is FLASE, it will use this Vol as default Fs.
> If ScanFs is TRUE, it will scan all FS and check the file.
> If there is only one file match the name, it will be read.
> If there is more than one file match the name, it will return Error.
>
> - @param[in] ThisVol File System Volume
> - @param[in] FileName The file to be read.
> - @param[out] BufferSize The file buffer size
> - @param[out] Buffer The file buffer
> - @param[in] ScanFs Need Scan all FS
> + @param[in,out] ThisVol File System Volume
> + @param[in] FileName The file to be read.
> + @param[out] BufferSize The file buffer size
> + @param[out] Buffer The file buffer
> + @param[in] ScanFs Need Scan all FS
>
> @retval EFI_SUCCESS Read file successfully
> @retval EFI_NOT_FOUND File not found
> @retval EFI_NO_MAPPING There is duplicated files found
> **/
> diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
> b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
> index 3d83ec4..8f44e5e 100644
> --- a/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
> +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleDump.c
> @@ -29,13 +29,13 @@
> #include <IndustryStandard/WindowsUxCapsule.h>
>
> /**
> Read a file.
>
> - @param[in] FileName The file to be read.
> - @param[in] BufferSize The file buffer size
> - @param[in] Buffer The file buffer
> + @param[in] FileName The file to be read.
> + @param[out] BufferSize The file buffer size
> + @param[out] Buffer The file buffer
>
> @retval EFI_SUCCESS Read file successfully
> @retval EFI_NOT_FOUND File not found
> **/
> EFI_STATUS
> diff --git a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> index f8edb78..eba938e 100644
> --- a/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> +++ b/MdeModulePkg/Core/PiSmmCore/MemoryAttributesTable.c
> @@ -144,14 +144,14 @@ SmmMemoryAttributesTableConsistencyCheck (
> }
>
> /**
> Sort memory map entries based upon PhysicalStart, from low to high.
>
> - @param[in] MemoryMap A pointer to the buffer in which
> firmware places
> - the current memory map.
> - @param[in] MemoryMapSize Size, in bytes, of the MemoryMap
> buffer.
> - @param[in] DescriptorSize Size, in bytes, of an individual
> EFI_MEMORY_DESCRIPTOR.
> + @param[in,out] MemoryMap A pointer to the buffer in which
> firmware places
> + the current memory map.
> + @param[in] MemoryMapSize Size, in bytes, of the MemoryMap
> buffer.
> + @param[in] DescriptorSize Size, in bytes, of an individual
> EFI_MEMORY_DESCRIPTOR.
> **/
> STATIC
> VOID
> SortMemoryMap (
> IN OUT EFI_MEMORY_DESCRIPTOR *MemoryMap,
> diff --git a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> index 5d46709..3ba3b9c 100644
> --- a/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> +++ b/MdeModulePkg/Library/DxeCapsuleLibFmp/DxeCapsuleLib.c
> @@ -774,12 +774,12 @@ DumpFmpCapsule (
> EFI_FIRMWARE_MANAGEMENT_CAPSULE_HEADER and
> EFI_FIRMWARE_MANAGEMENT_CAPSULE_IMAGE_HEADER are correct.
>
> This function need support nested FMP capsule.
>
> - @param[in] CapsuleHeader Points to a capsule header.
> - @param[in] AreAllImagesProcessed If all the FMP images in the capsule are
> processed.
> + @param[in] CapsuleHeader Points to a capsule header.
> + @param[out] AreAllImagesProcessed If all the FMP images in the capsule
> are processed.
>
> @retval EFI_SUCESS Process Capsule Image successfully.
> @retval EFI_UNSUPPORTED Capsule image is not supported by the
> firmware.
> @retval EFI_VOLUME_CORRUPTED FV volume in the capsule is corrupted.
> @retval EFI_OUT_OF_RESOURCES Not enough memory.
> --
> 1.9.5.msysgit.1
^ permalink raw reply [flat|nested] 39+ messages in thread
* [patch 17/18] MdeModulePkg: Add missing info string for PCDs
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (15 preceding siblings ...)
2016-12-13 8:40 ` [patch 16/18] MdeModulePkg: Make the comments align with the function Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
[not found] ` <3C0D5C461C9E904E8F62152F6274C0BB3B856DD7@SHSMSX103.ccr.corp.intel.com>
2016-12-13 8:40 ` [patch 18/18] MdeModulePkg/CapsuleApp: Fix GUID/protocol format issues Dandan Bi
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
Some Pcds are added to the dec file, but miss to add the
prompt&&help info to the uni file, now add them.
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
MdeModulePkg/MdeModulePkg.dec | 1 +
MdeModulePkg/MdeModulePkg.uni | 69 +++++++++++++++++++++++++++++++++++++++++++
2 files changed, 70 insertions(+)
diff --git a/MdeModulePkg/MdeModulePkg.dec b/MdeModulePkg/MdeModulePkg.dec
index a5eb901..7307191 100644
--- a/MdeModulePkg/MdeModulePkg.dec
+++ b/MdeModulePkg/MdeModulePkg.dec
@@ -1672,10 +1672,11 @@ [PcdsFixedAtBuild, PcdsPatchableInModule, PcdsDynamic, PcdsDynamicEx]
## This is recover file name in PEI phase.
# The file must be in the root directory.
# The file name must be the 8.3 format.
# The PCD data must be in UNICODE format.
+ # @Prompt Recover file name in PEI phase
gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"FVMAIN.FV"|VOID*|0x30001045
## This PCD hold a list GUIDs for the ImageTypeId to indicate the
# FMP capsule is a system FMP.
# @Prompt A list of system FMP ImageTypeId GUIDs
diff --git a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
index 136eec9..5436b60 100644
--- a/MdeModulePkg/MdeModulePkg.uni
+++ b/MdeModulePkg/MdeModulePkg.uni
@@ -1004,5 +1004,74 @@
"On X64 platforms, Option ROMs may contain code that executes in the context of a legacy BIOS (CSM),"
"which requires that all PCI MMIO BARs are located below 4 GB.<BR>"
"TRUE - All PCI MMIO BARs of a device will be located below 4 GB if it has an option ROM.<BR>"
"FALSE - PCI MMIO BARs of a device may be located above 4 GB even if it has an option ROM.<BR>"
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdStatusCodeSubClassCapsule_PROMPT #language en-US "Status Code for Capsule subclass definitions"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdStatusCodeSubClassCapsule_HELP #language en-US "Status Code for Capsule subclass definitions.<BR><BR>\n"
+ "EFI_OEM_SPECIFIC_SUBCLASS_CAPSULE = 0x00810000<BR>\n"
+ "NOTE: The default value of this PCD may collide with other OEM specific status codes.\n"
+ "Override the value of this PCD in the platform DSC file as needed."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeProcessCapsulesBegin_PROMPT #language en-US "Status Code for Capsule Process Begin"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeProcessCapsulesBegin_HELP #language en-US "Status Code for Capsule Process Begin.<BR><BR>\n"
+ "EFI_CAPSULE_PROCESS_CAPSULES_BEGIN = (EFI_OEM_SPECIFIC | 0x00000001) = 0x00008001<BR>\n"
+ "NOTE: The default value of this PCD may collide with other OEM specific status codes.\n"
+ "Override the value of this PCD in the platform DSC file as needed."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeProcessCapsulesEnd_PROMPT #language en-US "Status Code for Capsule Process End"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeProcessCapsulesEnd_HELP #language en-US "Status Code for Capsule Process End.<BR><BR>\n"
+ "EFI_CAPSULE_PROCESS_CAPSULES_END = (EFI_OEM_SPECIFIC | 0x00000002) = 0x00008002<BR>\n"
+ "NOTE: The default value of this PCD may collide with other OEM specific status codes.\n"
+ "Override the value of this PCD in the platform DSC file as needed."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdatingFirmware_PROMPT #language en-US "Status Code for Capsule Process Updating Firmware"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdatingFirmware_HELP #language en-US "Status Code for Capsule Process Updating Firmware.<BR><BR>\n"
+ "EFI_CAPSULE_UPDATING_FIRMWARE = (EFI_OEM_SPECIFIC | 0x00000003) = 0x00008003<BR>\n"
+ "NOTE: The default value of this PCD may collide with other OEM specific status codes.\n"
+ "Override the value of this PCD in the platform DSC file as needed."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdateFirmwareSuccess_PROMPT #language en-US "Status Code for Capsule Process Update Firmware Success"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdateFirmwareSuccess_HELP #language en-US "Status Code for Capsule Process Update Firmware Success.<BR><BR>\n"
+ "EFI_CAPSULE_UPDATE_FIRMWARE_SUCCESS = (EFI_OEM_SPECIFIC | 0x00000004) = 0x00008004<BR>\n"
+ "NOTE: The default value of this PCD may collide with other OEM specific status codes.\n"
+ "Override the value of this PCD in the platform DSC file as needed."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdateFirmwareFailed_PROMPT #language en-US "Status Code for Capsule Process Update Firmware Failed"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdateFirmwareFailed_HELP #language en-US "Status Code for Capsule Process Update Firmware Failed.<BR><BR>\n"
+ "EFI_CAPSULE_UPDATE_FIRMWARE_FAILED = (EFI_OEM_SPECIFIC | 0x00000005) = 0x00008005<BR>\n"
+ "NOTE: The default value of this PCD may collide with other OEM specific status codes.\n"
+ "Override the value of this PCD in the platform DSC file as needed."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeResettingSystem_PROMPT #language en-US "Status Code for Capsule Resetting System"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeResettingSystem_HELP #language en-US "Status Code for Capsule Resetting System.<BR><BR>\n"
+ "EFI_CAPSULE_RESETTING_SYSTEM = (EFI_OEM_SPECIFIC | 0x00000006) = 0x00008006<BR>\n"
+ "NOTE: The default value of this PCD may collide with other OEM specific status codes.\n"
+ "Override the value of this PCD in the platform DSC file as needed."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleMax_PROMPT #language en-US "CapsuleMax value in capsule report variable."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleMax_HELP #language en-US "CapsuleMax value in capsule report variable."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdRecoveryFileName_PROMPT #language en-US "Recover file name in PEI phase"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdRecoveryFileName_HELP #language en-US "This is recover file name in PEI phase.\n"
+ "The file must be in the root directory.\n"
+ "The file name must be the 8.3 format.\n"
+ "The PCD data must be in UNICODE format."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSystemFmpCapsuleImageTypeIdGuid_PROMPT #language en-US "A list of system FMP ImageTypeId GUIDs"
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSystemFmpCapsuleImageTypeIdGuid_HELP #language en-US "This PCD hold a list GUIDs for the ImageTypeId to indicate the\n"
+ "FMP capsule is a system FMP."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_PROMPT #language en-US "If there is any test key used by the platform."
+
+#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_HELP #language en-US "This dynamic PCD holds the information if there is any test key used by the platform."
+
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* [patch 18/18] MdeModulePkg/CapsuleApp: Fix GUID/protocol format issues
2016-12-13 8:40 [patch 00/18] Fix coding style issues Dandan Bi
` (16 preceding siblings ...)
2016-12-13 8:40 ` [patch 17/18] MdeModulePkg: Add missing info string for PCDs Dandan Bi
@ 2016-12-13 8:40 ` Dandan Bi
2016-12-13 8:46 ` Yao, Jiewen
17 siblings, 1 reply; 39+ messages in thread
From: Dandan Bi @ 2016-12-13 8:40 UTC (permalink / raw)
To: edk2-devel; +Cc: Jiewen Yao
Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Dandan Bi <dandan.bi@intel.com>
---
MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf | 28 +++++++++++-----------
1 file changed, 14 insertions(+), 14 deletions(-)
diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf
index 2084e5f..97cd9ba 100644
--- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf
+++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf
@@ -38,26 +38,26 @@ [Sources]
[Packages]
MdePkg/MdePkg.dec
MdeModulePkg/MdeModulePkg.dec
[Guids]
- gEfiFileInfoGuid
- gEfiPartTypeSystemPartGuid
- gEfiGlobalVariableGuid
- gEfiCapsuleReportGuid
- gEfiFmpCapsuleGuid
- gWindowsUxCapsuleGuid
- gEfiCertTypeRsa2048Sha256Guid
- gEfiCertPkcs7Guid
- gEfiSystemResourceTableGuid
+ gEfiFileInfoGuid ## CONSUMES
+ gEfiPartTypeSystemPartGuid ## CONSUMES
+ gEfiGlobalVariableGuid ## CONSUMES
+ gEfiCapsuleReportGuid ## CONSUMES
+ gEfiFmpCapsuleGuid ## CONSUMES
+ gWindowsUxCapsuleGuid ## CONSUMES
+ gEfiCertTypeRsa2048Sha256Guid ## CONSUMES
+ gEfiCertPkcs7Guid ## CONSUMES
+ gEfiSystemResourceTableGuid ## CONSUMES
[Protocols]
- gEfiLoadedImageProtocolGuid
- gEfiSimpleFileSystemProtocolGuid
- gEfiGraphicsOutputProtocolGuid
- gEfiFirmwareManagementProtocolGuid
- gEfiShellParametersProtocolGuid
+ gEfiLoadedImageProtocolGuid ## CONSUMES
+ gEfiSimpleFileSystemProtocolGuid ## CONSUMES
+ gEfiGraphicsOutputProtocolGuid ## CONSUMES
+ gEfiFirmwareManagementProtocolGuid ## CONSUMES
+ gEfiShellParametersProtocolGuid ## CONSUMES
[LibraryClasses]
BaseLib
UefiApplicationEntryPoint
DebugLib
--
1.9.5.msysgit.1
^ permalink raw reply related [flat|nested] 39+ messages in thread* Re: [patch 18/18] MdeModulePkg/CapsuleApp: Fix GUID/protocol format issues
2016-12-13 8:40 ` [patch 18/18] MdeModulePkg/CapsuleApp: Fix GUID/protocol format issues Dandan Bi
@ 2016-12-13 8:46 ` Yao, Jiewen
0 siblings, 0 replies; 39+ messages in thread
From: Yao, Jiewen @ 2016-12-13 8:46 UTC (permalink / raw)
To: Bi, Dandan, edk2-devel@lists.01.org
Reviewed-by: jiewen.yao@intel.com
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [edk2] [patch 18/18] MdeModulePkg/CapsuleApp: Fix GUID/protocol
> format issues
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf | 28
> +++++++++++-----------
> 1 file changed, 14 insertions(+), 14 deletions(-)
>
> diff --git a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf
> b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf
> index 2084e5f..97cd9ba 100644
> --- a/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf
> +++ b/MdeModulePkg/Application/CapsuleApp/CapsuleApp.inf
> @@ -38,26 +38,26 @@ [Sources]
> [Packages]
> MdePkg/MdePkg.dec
> MdeModulePkg/MdeModulePkg.dec
>
> [Guids]
> - gEfiFileInfoGuid
> - gEfiPartTypeSystemPartGuid
> - gEfiGlobalVariableGuid
> - gEfiCapsuleReportGuid
> - gEfiFmpCapsuleGuid
> - gWindowsUxCapsuleGuid
> - gEfiCertTypeRsa2048Sha256Guid
> - gEfiCertPkcs7Guid
> - gEfiSystemResourceTableGuid
> + gEfiFileInfoGuid ## CONSUMES
> + gEfiPartTypeSystemPartGuid ## CONSUMES
> + gEfiGlobalVariableGuid ## CONSUMES
> + gEfiCapsuleReportGuid ## CONSUMES
> + gEfiFmpCapsuleGuid ## CONSUMES
> + gWindowsUxCapsuleGuid ## CONSUMES
> + gEfiCertTypeRsa2048Sha256Guid ## CONSUMES
> + gEfiCertPkcs7Guid ## CONSUMES
> + gEfiSystemResourceTableGuid ## CONSUMES
>
> [Protocols]
> - gEfiLoadedImageProtocolGuid
> - gEfiSimpleFileSystemProtocolGuid
> - gEfiGraphicsOutputProtocolGuid
> - gEfiFirmwareManagementProtocolGuid
> - gEfiShellParametersProtocolGuid
> + gEfiLoadedImageProtocolGuid ## CONSUMES
> + gEfiSimpleFileSystemProtocolGuid ## CONSUMES
> + gEfiGraphicsOutputProtocolGuid ## CONSUMES
> + gEfiFirmwareManagementProtocolGuid ## CONSUMES
> + gEfiShellParametersProtocolGuid ## CONSUMES
>
> [LibraryClasses]
> BaseLib
> UefiApplicationEntryPoint
> DebugLib
> --
> 1.9.5.msysgit.1
>
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel
^ permalink raw reply [flat|nested] 39+ messages in thread