Re: [patch 17/18] MdeModulePkg: Add missing info string for PCDs

["Yao, Jiewen" <jiewen.yao@intel.com>]

Reviewed-by: Jiewen.yao@intel.com

> 
> -----Original Message-----
> From: edk2-devel [mailto:edk2-devel-bounces@lists.01.org] On Behalf Of
> Dandan Bi
> Sent: Tuesday, December 13, 2016 4:40 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [edk2] [patch 17/18] MdeModulePkg: Add missing info string for PCDs
> 
> Some Pcds are added to the dec file, but miss to add the prompt&&help info to
> the uni file, now add them.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
>  MdeModulePkg/MdeModulePkg.dec |  1 +
>  MdeModulePkg/MdeModulePkg.uni | 69
> +++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 70 insertions(+)
> 
> diff --git a/MdeModulePkg/MdeModulePkg.dec
> b/MdeModulePkg/MdeModulePkg.dec index a5eb901..7307191 100644
> --- a/MdeModulePkg/MdeModulePkg.dec
> +++ b/MdeModulePkg/MdeModulePkg.dec
> @@ -1672,10 +1672,11 @@ [PcdsFixedAtBuild, PcdsPatchableInModule,
> PcdsDynamic, PcdsDynamicEx]
> 
>    ## This is recover file name in PEI phase.
>    #  The file must be in the root directory.
>    #  The file name must be the 8.3 format.
>    #  The PCD data must be in UNICODE format.
> +  # @Prompt Recover file name in PEI phase
> 
> gEfiMdeModulePkgTokenSpaceGuid.PcdRecoveryFileName|L"FVMAIN.FV"|VOI
> D*|0x30001045
> 
>    ## This PCD hold a list GUIDs for the ImageTypeId to indicate the
>    #  FMP capsule is a system FMP.
>    # @Prompt A list of system FMP ImageTypeId GUIDs diff --git
> a/MdeModulePkg/MdeModulePkg.uni b/MdeModulePkg/MdeModulePkg.uni
> index 136eec9..5436b60 100644
> --- a/MdeModulePkg/MdeModulePkg.uni
> +++ b/MdeModulePkg/MdeModulePkg.uni
> @@ -1004,5 +1004,74 @@
> 
> "On X64 platforms, Option ROMs may contain code that executes in the context
> of a legacy BIOS (CSM),"
> 
> "which requires that all PCI MMIO BARs are located below 4 GB.<BR>"
> 
> "TRUE  - All PCI MMIO BARs of a device will be located below 4 GB if it has an
> option ROM.<BR>"
> 
> "FALSE - PCI MMIO BARs of a device may be located above 4 GB even if it has an
> option ROM.<BR>"
> 
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdStatusCodeSubClassCapsule_PRO
> MPT  #language en-US "Status Code for Capsule subclass definitions"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdStatusCodeSubClassCapsule_HELP
> #language en-US "Status Code for Capsule subclass definitions.<BR><BR>\n"
> +
> "EFI_OEM_SPECIFIC_SUBCLASS_CAPSULE  = 0x00810000<BR>\n"
> +
> "NOTE: The default value of this PCD may collide with other OEM specific status
> codes.\n"
> +
> "Override the value of this PCD in the platform DSC file as needed."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeProcessCapsul
> esBegin_PROMPT  #language en-US "Status Code for Capsule Process Begin"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeProcessCapsul
> esBegin_HELP  #language en-US "Status Code for Capsule Process
> Begin.<BR><BR>\n"
> +
> "EFI_CAPSULE_PROCESS_CAPSULES_BEGIN  = (EFI_OEM_SPECIFIC |
> 0x00000001) = 0x00008001<BR>\n"
> +
> "NOTE: The default value of this PCD may collide with other OEM specific status
> codes.\n"
> +
> "Override the value of this PCD in the platform DSC file as needed."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeProcessCapsul
> esEnd_PROMPT  #language en-US "Status Code for Capsule Process End"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeProcessCapsul
> esEnd_HELP  #language en-US "Status Code for Capsule Process
> End.<BR><BR>\n"
> +
> "EFI_CAPSULE_PROCESS_CAPSULES_END    = (EFI_OEM_SPECIFIC |
> 0x00000002) = 0x00008002<BR>\n"
> +
> "NOTE: The default value of this PCD may collide with other OEM specific status
> codes.\n"
> +
> "Override the value of this PCD in the platform DSC file as needed."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdatingFirmw
> are_PROMPT  #language en-US "Status Code for Capsule Process Updating
> Firmware"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdatingFirmw
> are_HELP  #language en-US "Status Code for Capsule Process Updating
> Firmware.<BR><BR>\n"
> +
> "EFI_CAPSULE_UPDATING_FIRMWARE       = (EFI_OEM_SPECIFIC |
> 0x00000003) = 0x00008003<BR>\n"
> +
> "NOTE: The default value of this PCD may collide with other OEM specific status
> codes.\n"
> +
> "Override the value of this PCD in the platform DSC file as needed."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdateFirmwa
> reSuccess_PROMPT  #language en-US "Status Code for Capsule Process Update
> Firmware Success"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdateFirmwa
> reSuccess_HELP  #language en-US "Status Code for Capsule Process Update
> Firmware Success.<BR><BR>\n"
> +
> "EFI_CAPSULE_UPDATE_FIRMWARE_SUCCESS = (EFI_OEM_SPECIFIC |
> 0x00000004) = 0x00008004<BR>\n"
> +
> "NOTE: The default value of this PCD may collide with other OEM specific status
> codes.\n"
> +
> "Override the value of this PCD in the platform DSC file as needed."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdateFirmwa
> reFailed_PROMPT  #language en-US "Status Code for Capsule Process Update
> Firmware Failed"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeUpdateFirmwa
> reFailed_HELP  #language en-US "Status Code for Capsule Process Update
> Firmware Failed.<BR><BR>\n"
> +
> "EFI_CAPSULE_UPDATE_FIRMWARE_FAILED  = (EFI_OEM_SPECIFIC |
> 0x00000005) = 0x00008005<BR>\n"
> +
> "NOTE: The default value of this PCD may collide with other OEM specific status
> codes.\n"
> +
> "Override the value of this PCD in the platform DSC file as needed."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeResettingSyste
> m_PROMPT  #language en-US "Status Code for Capsule Resetting System"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleStatusCodeResettingSyste
> m_HELP  #language en-US "Status Code for Capsule Resetting
> System.<BR><BR>\n"
> +
> "EFI_CAPSULE_RESETTING_SYSTEM        = (EFI_OEM_SPECIFIC | 0x00000006)
> = 0x00008006<BR>\n"
> +
> "NOTE: The default value of this PCD may collide with other OEM specific status
> codes.\n"
> +
> "Override the value of this PCD in the platform DSC file as needed."
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleMax_PROMPT
> #language en-US "CapsuleMax value in capsule report variable."
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdCapsuleMax_HELP
> #language en-US "CapsuleMax value in capsule report variable."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdRecoveryFileName_PROMPT
> #language en-US "Recover file name in PEI phase"
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdRecoveryFileName_HELP
> #language en-US "This is recover file name in PEI phase.\n"
> +
> "The file must be in the root directory.\n"
> +
> "The file name must be the 8.3 format.\n"
> +
> "The PCD data must be in UNICODE format."
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSystemFmpCapsuleImageTypeIdG
> uid_PROMPT  #language en-US "A list of system FMP ImageTypeId GUIDs"
> +
> +#string
> STR_gEfiMdeModulePkgTokenSpaceGuid_PcdSystemFmpCapsuleImageTypeIdG
> uid_HELP  #language en-US "This PCD hold a list GUIDs for the ImageTypeId to
> indicate the\n"
> +
> "FMP capsule is a system FMP."
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_PROMPT
> #language en-US "If there is any test key used by the platform."
> +
> +#string STR_gEfiMdeModulePkgTokenSpaceGuid_PcdTestKeyUsed_HELP
> #language en-US "This dynamic PCD holds the information if there is any test key
> used by the platform."
> +
> --
> 1.9.5.msysgit.1
> 
> _______________________________________________
> edk2-devel mailing list
> edk2-devel@lists.01.org
> https://lists.01.org/mailman/listinfo/edk2-devel