From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Bi, Dandan" <dandan.bi@intel.com>,
"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [PATCH v2 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
Date: Wed, 14 Dec 2016 03:34:13 +0000 [thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8BCD6A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1481686269-105384-1-git-send-email-dandan.bi@intel.com>
Rviewed-by: Jiewen.yao@intel.com
> -----Original Message-----
> From: Bi, Dandan
> Sent: Wednesday, December 14, 2016 11:31 AM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [PATCH v2 11/18] SignedCapsulePkg/IniParsingLib: Update struct name
>
> 1. Change _SECTION_ITEM to _INI_SECTION_ITEM
> 2. Change _COMMENT_LINE to _INI_COMMENT_LINE
> Because _SECTION_ITEM and _COMMENT_LINE are duplicated with
> the one defined in IntelFrameworkModulePkg\Universal\
> FirmwareVolume\UpdateDriverDxe\UpdateDriver.h
>
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Dandan Bi <dandan.bi@intel.com>
> ---
> SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> index 5c975f7..270380e 100644
> --- a/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> +++ b/SignedCapsulePkg/Library/IniParsingLib/IniParsingLib.c
> @@ -48,21 +48,21 @@
> #define IS_NULL(a) ((a) == '\0')
>
> // This is default allocation. Reallocation will happen if it is not enough.
> #define MAX_LINE_LENGTH 512
>
> -typedef struct _SECTION_ITEM SECTION_ITEM;
> -struct _SECTION_ITEM {
> +typedef struct _INI_SECTION_ITEM SECTION_ITEM;
> +struct _INI_SECTION_ITEM {
> CHAR8 *PtrSection;
> UINTN SecNameLen;
> CHAR8 *PtrEntry;
> CHAR8 *PtrValue;
> SECTION_ITEM *PtrNext;
> };
>
> -typedef struct _COMMENT_LINE COMMENT_LINE;
> -struct _COMMENT_LINE {
> +typedef struct _INI_COMMENT_LINE COMMENT_LINE;
> +struct _INI_COMMENT_LINE {
> CHAR8 *PtrComment;
> COMMENT_LINE *PtrNext;
> };
>
> typedef struct {
> --
> 1.9.5.msysgit.1
prev parent reply other threads:[~2016-12-14 3:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-14 3:31 [PATCH v2 11/18] SignedCapsulePkg/IniParsingLib: Update struct name Dandan Bi
2016-12-14 3:34 ` Yao, Jiewen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A8BCD6A@SHSMSX104.ccr.corp.intel.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox