public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Yao, Jiewen" <jiewen.yao@intel.com>
To: "Gao, Liming" <liming.gao@intel.com>,
	"edk2-devel@lists.01.org" <edk2-devel@lists.01.org>
Subject: Re: [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure
Date: Wed, 14 Dec 2016 05:41:54 +0000	[thread overview]
Message-ID: <74D8A39837DF1E4DA445A8C0B3885C503A8BCE9A@SHSMSX104.ccr.corp.intel.com> (raw)
In-Reply-To: <1481692786-6416-1-git-send-email-liming.gao@intel.com>

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, December 14, 2016 1:20 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure
> 
> Change structure value assignment with CopyMem() API.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> index 7592def..c95a22d 100644
> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> @@ -1,6 +1,6 @@
>  /** @file
> 
> -Copyright (c) 2007, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -134,7 +134,10 @@ EbcDebuggerPushCallstackDest (
>      //
>      ASSERT
> (mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_TRACE_MAX].Type == Type);
>      for (Index = 0; Index < EFI_DEBUGGER_CALLSTACK_MAX; Index++) {
> -      mDebuggerPrivate.CallStackEntry[Index] =
> mDebuggerPrivate.CallStackEntry[Index + 1];
> +      CopyMem (&mDebuggerPrivate.CallStackEntry[Index],
> +               &mDebuggerPrivate.CallStackEntry[Index + 1],
> +               sizeof (mDebuggerPrivate.CallStackEntry[Index])
> +               );
>      }
>      mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_CALLSTACK_MAX -
> 1].DestAddress = DestEntry;
>      mDebuggerPrivate.CallStackEntryCount =
> EFI_DEBUGGER_CALLSTACK_MAX;
> --
> 2.8.0.windows.1



      reply	other threads:[~2016-12-14  5:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-14  5:19 [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure Liming Gao
2016-12-14  5:41 ` Yao, Jiewen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=74D8A39837DF1E4DA445A8C0B3885C503A8BCE9A@SHSMSX104.ccr.corp.intel.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox