[Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure

[Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure

[Liming Gao]

Change structure value assignment with CopyMem() API.

Cc: Jiewen Yao <jiewen.yao@intel.com>
Contributed-under: TianoCore Contribution Agreement 1.0
Signed-off-by: Liming Gao <liming.gao@intel.com>
---
 MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
index 7592def..c95a22d 100644
--- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
+++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
@@ -1,6 +1,6 @@
 /** @file
 
-Copyright (c) 2007, Intel Corporation. All rights reserved.<BR>
+Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
 This program and the accompanying materials
 are licensed and made available under the terms and conditions of the BSD License
 which accompanies this distribution.  The full text of the license may be found at
@@ -134,7 +134,10 @@ EbcDebuggerPushCallstackDest (
     //
     ASSERT (mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_TRACE_MAX].Type == Type);
     for (Index = 0; Index < EFI_DEBUGGER_CALLSTACK_MAX; Index++) {
-      mDebuggerPrivate.CallStackEntry[Index] = mDebuggerPrivate.CallStackEntry[Index + 1];
+      CopyMem (&mDebuggerPrivate.CallStackEntry[Index],
+               &mDebuggerPrivate.CallStackEntry[Index + 1],
+               sizeof (mDebuggerPrivate.CallStackEntry[Index])
+               );
     }
     mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_CALLSTACK_MAX - 1].DestAddress = DestEntry;
     mDebuggerPrivate.CallStackEntryCount = EFI_DEBUGGER_CALLSTACK_MAX;
-- 
2.8.0.windows.1

Re: [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure

[Yao, Jiewen]

Reviewed-by: jiewen.yao@intel.com

> -----Original Message-----
> From: Gao, Liming
> Sent: Wednesday, December 14, 2016 1:20 PM
> To: edk2-devel@lists.01.org
> Cc: Yao, Jiewen <jiewen.yao@intel.com>
> Subject: [Patch] MdeModulePkg EbcDxe: Fix CLANG38 build failure
> 
> Change structure value assignment with CopyMem() API.
> 
> Cc: Jiewen Yao <jiewen.yao@intel.com>
> Contributed-under: TianoCore Contribution Agreement 1.0
> Signed-off-by: Liming Gao <liming.gao@intel.com>
> ---
>  MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> index 7592def..c95a22d 100644
> --- a/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> +++ b/MdeModulePkg/Universal/EbcDxe/EbcDebugger/EdbHook.c
> @@ -1,6 +1,6 @@
>  /** @file
> 
> -Copyright (c) 2007, Intel Corporation. All rights reserved.<BR>
> +Copyright (c) 2007 - 2016, Intel Corporation. All rights reserved.<BR>
>  This program and the accompanying materials
>  are licensed and made available under the terms and conditions of the BSD
> License
>  which accompanies this distribution.  The full text of the license may be found
> at
> @@ -134,7 +134,10 @@ EbcDebuggerPushCallstackDest (
>      //
>      ASSERT
> (mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_TRACE_MAX].Type == Type);
>      for (Index = 0; Index < EFI_DEBUGGER_CALLSTACK_MAX; Index++) {
> -      mDebuggerPrivate.CallStackEntry[Index] =
> mDebuggerPrivate.CallStackEntry[Index + 1];
> +      CopyMem (&mDebuggerPrivate.CallStackEntry[Index],
> +               &mDebuggerPrivate.CallStackEntry[Index + 1],
> +               sizeof (mDebuggerPrivate.CallStackEntry[Index])
> +               );
>      }
>      mDebuggerPrivate.CallStackEntry[EFI_DEBUGGER_CALLSTACK_MAX -
> 1].DestAddress = DestEntry;
>      mDebuggerPrivate.CallStackEntryCount =
> EFI_DEBUGGER_CALLSTACK_MAX;
> --
> 2.8.0.windows.1